ci: Remove nix check from the critical path in ci.yaml
What the developer wrote
Authored by Christian Decker
ci: Remove nix check from the critical path in ci.yaml
What changed, and why it matters
This commit removes a Nix flake validation job from the project's GitHub Actions CI workflow. It is a routine build-infrastructure change with no direct security relevance to the Core Lightning software itself.
No security action required. If the project relies on Nix for reproducible builds or supply-chain assurance, maintainers may want to confirm the flake check is still run elsewhere or intentionally deprioritized.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes the check-flake job from .github/workflows/ci.yaml. That job previously checked out the repository, ran DeterminateSystems/flake-checker-action@v8, installed Nix, and executed nix flake check. Removing it means the CI pipeline no longer validates the Nix flake on every run, but this does not alter the shipped code, dependencies, or build artifacts of Core Lightning.
Changed components
.github/workflows/ci.yamlInspect captured patch +0 / −18
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 95779dfa..1ff00508 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -677,24 +677,6 @@ jobs:
cat config.vars
VALGRIND=0 uv run eatmydata pytest tests/ ${GLOBAL_PYTEST_OPTS} -n ${PYTEST_PAR} ${PYTEST_OPTS}
- check-flake:
- name: Check Nix Flake
- runs-on: ubuntu-22.04
- strategy:
- fail-fast: true
- steps:
- - name: Checkout
- uses: actions/checkout@v4
- with:
- submodules: 'recursive'
- - name: Check Nix flake inputs
- uses: DeterminateSystems/flake-checker-action@v8
- - name: Install Nix
- uses: cachix/install-nix-action@v31
- with:
- nix_path: nixpkgs=channel:nixos-unstable
- - name: Check flake
- run: nix flake check
gather:
# A dummy task that depends on the full matrix of tests, and
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.