wallet: remove notification on duplicate chain entries.
What the developer wrote
Authored by Rusty Russell
wallet: remove notification on duplicate chain entries.
We don't need it now bookkeeper uses the list commands.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit removes a notification that was previously sent when the wallet tried to record a blockchain movement that it had already seen. The change is described as cleanup because another component (bookkeeper) now uses list commands instead of relying on this duplicate notification. There is no direct evidence in the commit that this fixes an active security vulnerability.
Treat as routine cleanup. Review whether any downstream component still depends on duplicate chain movement notifications, since the removed comment suggests bookkeeper tests previously relied on it. No immediate security action is indicated by the diff alone.
Security signals we found
Removal of a duplicate-entry notification path
FIXME comment removed indicating prior workaround for offline bookkeeper tests
No input validation, memory safety, or cryptographic changes visible
Evidence from the diff
In wallet_save_chain_mvt(), when a chain movement was a duplicate, the code used to call notify_chain_mvt() before returning. The commit removes that notification and the associated FIXME comment, which stated it was required for bookkeeper tests when bookkeeper is offline. The change is framed as no longer needed because bookkeeper now uses list commands. The diff alone does not show a vulnerability; it shows removal of a workaround notification path.
Changed components
wallet/wallet.cwallet_save_chain_mvt()chain movement notification subsystemInspect captured patch +0 / −2
diff --git a/wallet/wallet.c b/wallet/wallet.c
index 6546ad57..c649696c 100644
--- a/wallet/wallet.c
+++ b/wallet/wallet.c
@@ -7009,8 +7009,6 @@ void wallet_save_chain_mvt(struct lightningd *ld,
/* It's a duplicate. Don't re-add. */
tal_free(stmt);
- /* FIXME: This is currently required for bookkeeper tests, if bookkeeper is offline */
- notify_chain_mvt(ld, chain_mvt, id);
goto out;
}
tal_free(stmt);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.