AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 17 Bitcoin

lightningd: have onchaind inform us when to make a channel penalty_adj.

Public commit record

What the developer wrote

Authored by Rusty Russell

73/100 · Adequate
lightningd: have onchaind inform us when to make a channel penalty_adj.

bookkeeper used to generate these as channel events, now lightningd does.

We also add a "journal" event, which we will need later too.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit moves bookkeeping of penalty-related channel balance adjustments from the bookkeeper plugin into the main lightningd process. It adds new internal accounting tags and a message so the on-chain subsystem can tell lightningd when to record these adjustments. There is no direct security vulnerability visible in the diff; it is a refactor of how internal accounting events are generated.

Recommended action

No immediate security action required. Treat as a normal refactor/functional change. Reviewers may want to confirm that the paired credit/debit events correctly preserve the channel accounting invariant and that no other bookkeeper logic relied on the removed penalty_adj generation.

Security signals we found

01

New wire message type added between onchaind and lightningd

02

Bookkeeper plugin stops generating penalty adjustment journal entries and now ignores the new tags

03

No input validation beyond fromwire parsing in the new handler

04

Paired credit/debit events are emitted for the same amount, preserving accounting balance

Risk score

Why this scored 17/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 1/15
Affected reach 2/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.