AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Bitcoin

msggen: propagate added and deprecated fields

Public commit record

What the developer wrote

Authored by daywalker90

68/100 · Adequate
msggen: propagate added and deprecated fields

Whenever we want to add a new rpc command or notification in msggen's `util.py` we get an error during `make`
that the `added` field of that new command or notification is missing even when it's clearly not.
We had to uncomment 2 lines in `patch.py` and override any missing `added` annotation to get it running.
We now pass any `added` or `deprecated` fields from the parent object correctly so we no longer have to do this.

Unfortunately we have commited wrong metadata to `.msggen.json` in the past.
This commit also includes missing `added` annotation for commands added after the `pre-v0.10.1` cutoff and
manual fixes of the metadata in `.msggen.json`
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit fixes a code-generator bug in Core Lightning's message generator (msggen). Previously, newly added RPC commands and fields could fail to build because version metadata wasn't inherited from parent objects. The patch makes the generator propagate 'added' and 'deprecated' annotations correctly and updates the generated RPC model files, gRPC proto, and JSON schema metadata to match. It is a build/tooling correctness fix, not a runtime security patch.

Recommended action

Treat as a routine tooling/generator fix. Reviewers should verify that regenerated RPC bindings still compile and that any changed field optionality matches the JSON schemas. No security response is indicated.

Security signals we found

01

No memory-unsafe code changes

02

No cryptographic or authorization logic changes

03

No network protocol parsing changes in the daemon

04

Generated gRPC/Rust model changes are metadata and optionality corrections

05

Commit message describes a build/generator bug, not a vulnerability

Risk score

Why this scored 19/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 3/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.