lightningd: remove unused `start_time` field in bitcoind_getfilteredblock.
What the developer wrote
Authored by Rusty Russell
lightningd: remove unused `start_time` field in bitcoind_getfilteredblock.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit removes an unused internal timestamp field (`start_time`) from a data structure used when fetching filtered Bitcoin blocks. It is a straightforward code cleanup with no functional or security change.
No action required; this is a non-security cleanup change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the start_time member of struct filteredblock_call and the single assignment call->start_time = time_now(); in bitcoind_getfilteredblock_(). The field is never read anywhere in the codebase, so this is pure dead-code elimination. No logic, API, or behavior changes.
Changed components
lightningd/bitcoind.cInspect captured patch +0 / −2
diff --git a/lightningd/bitcoind.c b/lightningd/bitcoind.c
index 3e092a5b..a7e9b876 100644
--- a/lightningd/bitcoind.c
+++ b/lightningd/bitcoind.c
@@ -694,7 +694,6 @@ struct filteredblock_call {
struct filteredblock *result;
struct filteredblock_outpoint **outpoints;
size_t current_outpoint;
- struct timeabs start_time;
u32 height;
};
@@ -849,7 +848,6 @@ void bitcoind_getfilteredblock_(const tal_t *ctx,
call->arg = arg;
call->height = height;
assert(call->cb != NULL);
- call->start_time = time_now();
call->result = NULL;
call->current_outpoint = 0;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.