plugins: rename bwatch output binary to cln-bwatch
What the developer wrote
Authored by Sangbida Chaudhuri
plugins: rename bwatch output binary to cln-bwatch
The bwatch plugin lived in plugins/bwatch/ and output its binary as
plugins/bwatch/bwatch. This caused make install to install it flat as
<plugindir>/bwatch, while lightningd expected it at <plugindir>/bwatch/bwatch, so plugin registration failed at startup with "failed to register plugin".
Fix by renaming the output to plugins/cln-bwatch, following the same
convention as cln-renepay, cln-xpay and cln-askrene.
Changelog-Fixed: bwatch plugin failed to register on startup after make install
What changed, and why it matters
This commit fixes a build/installation bug where a newly added plugin, bwatch, was not being registered when Core Lightning started after running 'make install'. The plugin's binary was being installed to the wrong path, so lightningd could not find it. The fix renames the plugin binary to follow the same naming convention as other plugins. There is no security vulnerability here—just a packaging/startup bug.
No security action needed. This is a build/installation correctness fix; users who build from source and run 'make install' should update to include this commit so the bwatch plugin loads correctly.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The bwatch plugin was built as plugins/bwatch/bwatch and installed flat into
Changed components
plugins/bwatch build targetplugins/Makefileplugins/.gitignoreInspect captured patch +3 / −3
diff --git a/plugins/.gitignore b/plugins/.gitignore
index 3fd6cefa..06daa728 100644
--- a/plugins/.gitignore
+++ b/plugins/.gitignore
@@ -22,4 +22,4 @@ exposesecret
cln-xpay
cln-lsps-client
cln-lsps-service
-bwatch
+cln-bwatch
diff --git a/plugins/Makefile b/plugins/Makefile
index ea90317c..d302cc74 100644
--- a/plugins/Makefile
+++ b/plugins/Makefile
@@ -122,7 +122,7 @@ C_PLUGINS := \
plugins/autoclean \
plugins/chanbackup \
plugins/bcli \
- plugins/bwatch/bwatch \
+ plugins/cln-bwatch \
plugins/commando \
plugins/funder \
plugins/topology \
@@ -205,7 +205,7 @@ plugins/bwatch/bwatch_store.o: $(PLUGIN_BWATCH_HEADER)
plugins/bwatch/bwatch_scanner.o: $(PLUGIN_BWATCH_HEADER)
plugins/bwatch/bwatch_interface.o: $(PLUGIN_BWATCH_HEADER)
plugins/bwatch/bwatch_wiregen.o: $(PLUGIN_BWATCH_HEADER)
-plugins/bwatch/bwatch: $(PLUGIN_BWATCH_OBJS) $(PLUGIN_LIB_OBJS) libcommon.a
+plugins/cln-bwatch: $(PLUGIN_BWATCH_OBJS) $(PLUGIN_LIB_OBJS) libcommon.a
plugins/keysend: $(PLUGIN_KEYSEND_OBJS) $(PLUGIN_LIB_OBJS) $(PLUGIN_PAY_LIB_OBJS) libcommon.a
$(PLUGIN_KEYSEND_OBJS): $(PLUGIN_PAY_LIB_HEADER) libcommon.a
Why this scored 20/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.