← Watch feed
pytest: fix test_sendpay_grouping regex.
Public commit record
68/100 · Adequate
What the developer wrote
Authored by Rusty Russell
pytest: fix test_sendpay_grouping regex.
It doesn't match "after 10 attempts":
```
with pytest.raises(RpcError, match=r'Ran out of routes to try after [1-9]+ attempts'):
> l1.rpc.pay(inv, amount_msat='100001msat')
tests/test_pay.py:5250:
...
elif "error" in resp:
> raise RpcError(method, payload, resp['error'])
E pyln.client.lightning.RpcError: RPC call failed: method: pay, payload: {'bolt11': 'lnbcrt1p5evy5ksp5ndq75geqkggp9jvkal5e36mwpyppf0vm8ftzv7qqv9plkw2u5hkspp53rw3mkve9896muty6wzpjxc6ucau0cvekmakg6ta5h5v0ar07m6qdq8v3jhxccxqyjw5qcqp9rzjqvuytqpdyk6wqaxvl47d3vee5swuwklej79qxjqqg394r4ptqaue5qqqvuqqqqgqqqqqqqqpqqqqqzsqqc9qxpqysgq53phr29544luhuduaqjajvj8d54yep69sy6cqtesk2t3q83htsas8nhluh9jjqm4se274pzzg8ma943xe8a5sg7d286n2vttraqd7dsq8s7k84', 'amount_msat': '100001msat'}, error: {'code': 210, 'message': 'Ran out of routes to try after 10 attempts: see `paystatus`', 'attempts': [{'status': 'failed', 'failreason': 'failed: WIRE_TEMPORARY_CHANNEL_FAILURE (reply from remote)', 'partid': 0, 'amount_msat': 100001}, {'status': 'pending', 'failreason': 'No path found', 'partid': 1, 'amount_msat': 100001, 'parent_partid': 0}, {'status': 'failed', 'failreason': 'failed: WIRE_TEMPORARY_CHANNEL_FAILURE (reply from remote)', 'partid': 2, 'amount_msat': 51394, 'parent_partid': 1}, {'status': 'failed', 'failreason': 'failed: WIRE_TEMPORARY_CHANNEL_FAILURE (reply from remote)', 'partid': 4, 'amount_msat': 51394, 'parent_partid': 2}, {'status': 'failed', 'failreason': 'No path found', 'partid': 6, 'amount_msat': 51394, 'parent_partid': 4}, {'status': 'failed', 'failreason': 'No path found', 'partid': 7, 'amount_msat': 51394, 'parent_partid': 6}, {'status': 'failed', 'failreason': 'failed: WIRE_TEMPORARY_CHANNEL_FAILURE (reply from remote)', 'partid': 3, 'amount_msat': 48607, 'parent_partid': 1}, {'status': 'failed', 'failreason': 'failed: WIRE_TEMPORARY_CHANNEL_FAILURE (reply from remote)', 'partid': 5, 'amount_msat': 48607, 'parent_partid': 3}, {'status': 'failed', 'failreason': 'failed: WIRE_TEMPORARY_CHANNEL_FAILURE (reply from remote)', 'partid': 8, 'amount_msat': 48607, 'parent_partid': 5}, {'status': 'failed', 'failreason': 'No path found', 'partid': 9, 'amount_msat': 48607, 'parent_partid': 8}]}
```
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
What changed, and why it matters
This commit fixes a test-only regular expression so it correctly matches error messages that say 'after 10 attempts'. It is a test-suite maintenance change with no effect on the actual Core Lightning payment software or its users.
Recommended action
No security action needed. Treat as a normal test-fix commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change updates two pytest regex assertions in tests/test_pay.py from ‘[1-9]+’ to ‘[0-9]+’. The old regex rejected the digit ‘0’ in ‘10’, causing the test to fail when the payment code legitimately reported 10 routing attempts. This is purely a test expectation fix; no production code is modified.
Changed components
tests/test_pay.pyInspect captured patch +2 / −2
diff --git a/tests/test_pay.py b/tests/test_pay.py
index 1f31762c..d7012193 100644
--- a/tests/test_pay.py
+++ b/tests/test_pay.py
@@ -5234,7 +5234,7 @@ def test_sendpay_grouping(node_factory, bitcoind):
assert(len(l1.db.query("SELECT * FROM payments")) == 0)
assert(len(l1.rpc.listpays()['pays']) == 0)
- with pytest.raises(RpcError, match=r'Ran out of routes to try after [1-9]+ attempts'):
+ with pytest.raises(RpcError, match=r'Ran out of routes to try after [0-9]+ attempts'):
l1.rpc.pay(inv, amount_msat='100002msat')
# After this one invocation we have one entry in `listpays`
@@ -5246,7 +5246,7 @@ def test_sendpay_grouping(node_factory, bitcoind):
wait_for(lambda: len(l1.rpc.listchannels()['channels']) == 6)
l3.stop()
- with pytest.raises(RpcError, match=r'Ran out of routes to try after [1-9]+ attempts'):
+ with pytest.raises(RpcError, match=r'Ran out of routes to try after [0-9]+ attempts'):
l1.rpc.pay(inv, amount_msat='100001msat')
# Surprise: we should have 2 entries after 2 invocations
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.