xpay: fakenet test: skip temporarily
What the developer wrote
Authored by Lagrang3
xpay: fakenet test: skip temporarily
channeld_fakenet sudbdaemon purposedly crafted for this test needs
updating to account for funds moving after every success payment.
I've tried to fix that but in doing so I also triggered an xpay bug not
related to this PR. Therefore, for the moment we skip this test.
Changelog-None
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
What changed, and why it matters
This commit simply skips a single automated test in the project's test suite. It does not change any production code, network protocol handling, or wallet logic. The commit message explains the test is being disabled temporarily because a fake-network helper used only for testing needs updating, and the author encountered an unrelated bug while trying to fix it. There is no security-relevant change here.
No security action needed. Treat as ordinary test-suite maintenance. Re-enable the test once channeld_fakenet is updated and the unrelated xpay bug is resolved.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds one line to tests/test_xpay.py: a @pytest.mark.skip decorator above the existing test_xpay_fakenet test. The test itself and all runtime code remain untouched. The stated reason is that channeld_fakenet, a test-only stub daemon, must be updated to track funds moving after each successful payment, and an unrelated xpay bug was triggered during attempted fixes. This is a test-maintenance change, not a vulnerability fix or feature change.
Changed components
tests/test_xpay.pyInspect captured patch +1 / −0
diff --git a/tests/test_xpay.py b/tests/test_xpay.py
index 4c4cec3f..90cb2a7e 100644
--- a/tests/test_xpay.py
+++ b/tests/test_xpay.py
@@ -228,6 +228,7 @@ def test_xpay_selfpay(node_factory):
canned_gossmap_badnodes = [19, 53, 69, 72, 86]
+@pytest.mark.skip(reason="channeld_fakenet needs updating")
@pytest.mark.slow_test
@unittest.skipIf(TEST_NETWORK != 'regtest', '29-way split for node 17 is too dusty on elements')
@pytest.mark.parametrize("slow_mode", [False, True])
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.