pytest: mark test_connection.py::test_disconnect_opener flaky.
What the developer wrote
Authored by Rusty Russell
pytest: mark test_connection.py::test_disconnect_opener flaky.
It's a real bug, which I've reported in
https://github.com/ElementsProject/lightning/issues/8822
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
What changed, and why it matters
This commit only marks an existing test as flaky because it exposes a known bug. It does not fix any code, change protocol behavior, or introduce a security vulnerability. The underlying bug is reported separately and is not described here as security-relevant.
No security action required for this commit. Monitor issue #8822 for the actual bug fix and assess that separately when available.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff adds a pytest @pytest.mark.flaky(reruns=1) decorator and a FIXME comment pointing to GitHub issue #8822 for test_connection.py::test_disconnect_opener. The commit message states ‘It’s a real bug, which I’ve reported,’ confirming this is a test-hygiene change, not a code fix. No production code is modified.
Changed components
tests/test_connection.pyInspect captured patch +2 / −0
diff --git a/tests/test_connection.py b/tests/test_connection.py
index ffbf3c9e..7a3e85f9 100644
--- a/tests/test_connection.py
+++ b/tests/test_connection.py
@@ -472,6 +472,8 @@ def test_disconnect(node_factory):
@pytest.mark.openchannel('v1')
@pytest.mark.openchannel('v2')
+# FIXME: https://github.com/ElementsProject/lightning/issues/8822
+@pytest.mark.flaky(reruns=1)
def test_disconnect_opener(node_factory):
# Now error on opener side during channel open.
disconnects = ['-WIRE_OPEN_CHANNEL',
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.