AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 70 Bitcoin

Ensure the seed isn't leaking to user with can sign permission (#7354)

Public commit record

What the developer wrote

Authored by Nicolas Dorier

58/100 · Thin
Ensure the seed isn't leaking to user with can sign permission (#7354)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a permission leak in BTCPay Server's hot wallet handling. Previously, users who only had permission to sign transactions ('can sign') could also see the wallet's secret seed phrase, which should be restricted to store administrators. The change introduces a new 'HotwalletSafe' gatekeeper that separates 'can sign' from 'can see seed' and stops the seed from being passed through web forms or displayed to lower-privileged users.

Recommended action

Review the HotwalletSafe authorization logic to confirm CanSee and CanSign checks cannot be bypassed, verify that no other controllers still read WellknownMetadataKeys.MasterHDKey directly, and ensure the removed antiforgery token change is accompanied by a working CSRF token in the calling UI.

Security signals we found

01

Privilege boundary added between transaction signing and seed visibility

02

Hot wallet seed no longer passed through client-side form fields

03

Centralized key retrieval in new HotwalletSafe service

04

Removal of IgnoreAntiforgeryToken from update-labels endpoint

05

HTML encoding/localization fix for user-supplied label/message in status message

Risk score

Why this scored 70/100

Our methodology →
Potential impact 22/30
Exploitability 14/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.