AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Bitcoin

Fix reserved addresses after wallet replacement (#7304)

Public commit record

What the developer wrote

Authored by thgO.O

91/100 · Strong
Fix reserved addresses after wallet replacement (#7304)

* fix(wallet): validate reserved addresses against nbxplorer

* test(playwright): cover reserved addresses after wallet replacement
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a bug where BTCPay Server's 'reserved addresses' list could show addresses from a previously replaced wallet. After a user swaps one wallet for another, the old reserved addresses are now filtered out by checking which addresses actually belong to the current wallet's derivation scheme in the NBXplorer database. The commit also adds a Playwright test that verifies old addresses disappear after wallet replacement and reappear if the original wallet is restored.

Recommended action

Review whether any other wallet views (transactions, labels, pull payments, payment requests) similarly rely on WalletId-scoped data without validating the current derivation scheme. Ensure the new NBXplorer query is performant for stores with many reserved addresses and that the error messages do not leak internal database state.

Security signals we found

01

Information disclosure: reserved addresses from a replaced wallet could remain visible to the store owner or users with wallet access

02

Address/wallet confusion: UI displayed addresses not controlled by the currently configured wallet

03

Missing authorization boundary between wallet derivations sharing the same WalletId

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.