What the developer wrote
Authored by Nicolas Dorier
Remove useless code
What changed, and why it matters
This commit removes a single line of code that treated the 'comment' field as a special verbose metadata field in invoice reports. The change appears to be a cleanup: the comment field is already exported separately as 'InvoiceComment', so this branch was redundant. There is no indication this affects security.
No security action required. Treat as routine code cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In InvoicesReportProvider.cs, the pattern match that skipped processing for metadata keys [‘posData’, ‘tax’] or [‘itemDesc’] or [‘comment’] was simplified to only skip [‘posData’, ‘tax’] or [‘itemDesc’]. The removed [‘comment’] branch was described in a comment as ‘Exported explicitly as the InvoiceComment column’, meaning it was already handled elsewhere and the branch had no effect. The remaining switch statement will now fall through to default handling for comment objects, but since the comment is already exported separately, this is a no-op cleanup.
Changed components
BTCPayServer/Services/Reporting/InvoicesReportProvider.csInspect captured patch +1 / −3
diff --git a/BTCPayServer/Services/Reporting/InvoicesReportProvider.cs b/BTCPayServer/Services/Reporting/InvoicesReportProvider.cs
index 9d23a95..1f4f7d2 100644
--- a/BTCPayServer/Services/Reporting/InvoicesReportProvider.cs
+++ b/BTCPayServer/Services/Reporting/InvoicesReportProvider.cs
@@ -234,9 +234,7 @@ public class InvoicesReportProvider : ReportProvider
// When we have this field to non-zero, then the invoice has a taxIncluded metadata
is ["posData", "tax"]
// Verbose data
- or ["itemDesc"]
- // Exported explicitly as the InvoiceComment column
- or ["comment"])
+ or ["itemDesc"])
return;
switch (obj)
{
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.