AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 66 Bitcoin

PoS: Any store users can now generate a login QR any other store user (#7303)

Public commit record

What the developer wrote

Authored by Nicolas Dorier

58/100 · Thin
PoS: Any store users can now generate a login QR any other store user (#7303)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit changes how login QR codes are generated for BTCPay Server's Point of Sale (PoS) feature. Previously, only store owners or admins could generate login codes, and there was a warning when selecting a store owner. After this change, any store user can generate a login QR code for any other store user, including store owners, without the previous confirmation step. The commit title itself says this is intentional: 'Any store users can now generate a login QR any other store user.' This appears to be a deliberate feature change, but it weakens access controls around sensitive login credentials.

Recommended action

Treat this commit as a security-relevant access-control change. Review whether any store user should be able to generate login credentials for any other store user, especially store owners. Verify that the login code/token mechanism behind UIAccountController.Login and UserLoginCode is single-use, time-limited, and requires the target user's explicit authentication. If the login code is a long-lived or reusable credential, consider reverting the removal of the owner confirmation and non-admin filtering. Add audit logging for QR-code generation on behalf of other users.

Security signals we found

01

Removal of privileged-user confirmation before displaying owner login QR code

02

Removal of non-admin self-only filter in FillUsers, exposing all store user emails to every store user

03

Change from user ID to email as login identifier in QR generation

04

Login action now redirects already-authenticated users when email matches, enabling QR-based login-as-other-user flows

05

Commit title explicitly frames change as 'Any store users can now generate a login QR any other store user'

Risk score

Why this scored 66/100

Our methodology →
Potential impact 18/30
Exploitability 16/25
Stealth signal 10/15
Affected reach 12/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.