AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 37 Bitcoin

Feature: Plugin can extend whether an account can login or not

Public commit record

What the developer wrote

Authored by Nicolas Dorier

50/100 · Thin
Feature: Plugin can extend whether an account can login or not
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
The short version

What changed, and why it matters

This commit refactors how BTCPay Server decides whether a user is allowed to log in. It replaces a simple built-in check with a new extensible system where plugins can add their own login-blocking rules. The change touches password logins, two-factor/FIDO2/LNURL logins, API key authentication, and basic HTTP authentication. It also fixes a small bug in basic authentication where the password was checked before the user was validated. There is no claim in the commit that this fixes a known security vulnerability, and no CVE or advisory is referenced.

Recommended action

Treat as a normal feature/refactor commit. Review the new LoginExtension surface to ensure plugins cannot silently deny login or bypass existing checks, and verify that BasicAuthenticationHandler's reordering does not introduce a timing oracle or change lockout behavior. No immediate security patch action is indicated by the commit itself.

Security signals we found

01

Authentication logic refactored to allow plugin-extensible login denial

02

Basic auth handler reordered to validate user can-login before password verification

03

API key handler now fails authentication when user cannot login

04

New LoginFailure model supports localized HTML messages, joined into TempData status messages

05

IsUserTheOnlyOneAdmin now depends on plugin-extensible CanLogin checks

Risk score

Why this scored 37/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 5/15
Affected reach 8/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.