CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Bitcoin

Fix: Selecting some rate source would crash the Stores/Rates page (#7095)

BT208f45dc View source ↗
Public commit record

What the developer wrote

Authored by Nicolas Dorier

70/100 · Adequate
Fix: Selecting some rate source would crash the Stores/Rates page (#7095)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug where choosing certain cryptocurrency exchange rate sources would crash the BTCPay Server 'Stores/Rates' settings page. The root cause was that some rate source IDs contained characters like dashes or dots that are not valid in C# identifiers, which caused the rate-rule parser to throw an exception and crash the page. The fix adds validation when creating rate-source IDs, changes one provider's ID to remove a hyphen, sanitizes several IDs in a large exchange list, and makes the controller gracefully fall back when a preferred source cannot be found or parsed.

Recommended action

Treat as a routine bug fix with minor hardening value. Review whether any other rate providers or persisted store settings contain non-identifier characters in rate-source IDs, and ensure the validation is enforced consistently across all code paths that construct RateSourceInfo or parse rate rules. No urgent security patch is indicated unless an attacker can reliably trigger the crash to deny access to the Rates page.

Security signals we found

01

Unhandled exception in UI controller leading to page crash (availability impact)

02

Rate source IDs used in dynamically parsed rate rules without prior validation

03

Use of First() without fallback could throw on missing/mismatched exchange

04

RateRules.Parse exception not handled in rule-generation path

05

Patch adds identifier validation and exception handling as defense in depth

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from BTCPay Server

Related watches

Informational 15 AI analysisMessage 18 · Opaque
BT BTCPay ServerBTCPay Server BitcoinLightning NetworkPayment infrastructure

Update Changelog

This commit only edits the wording of a changelog entry for BTCPay Server 2.4.2. It does not change any code, configuration, or executable files. The edit makes the release sound more urgent, but the commit itself is purely documentation a…

Changelog language changed to describe a critical, actively exploited vulnerability in release 2.4.2No code, configuration, or dependency changes present in the commitSecurity issue is referenced but not fixed or explained in this diff
fbf761f3by Nicolas Dorier+1−11 file
Vendor flagged security relevance
Open full analysis →Source commit ↗
Low 49 AI analysisMessage 28 · Opaque
BT BTCPay ServerBTCPay Server BitcoinLightning NetworkPayment infrastructure

Disabled unwanted routes

This commit marks several public methods on ASP.NET Core controllers with [NonAction], which prevents them from being exposed as web-accessible HTTP routes. Without this attribute, these helper methods could be reached directly via URL, po…

Public controller methods exposed as unintended HTTP routesRouting-level access-control hardeningPotential bypass of intended controller action flow
6689cad4by Nicolas Dorier+9−05 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 64 AI analysisMessage 38 · Opaque
BT BTCPay ServerBTCPay Server BitcoinLightning NetworkPayment infrastructure

Changelog for 2.4.2

This commit is a version bump and changelog for BTCPay Server 2.4.2. The changelog describes two security-related changes: disabling Basic authentication by default shortly after account creation, and fixing a TOTP two-factor authenticatio…

Vendor describes security fixes in changelogTOTP two-factor authentication bypass via Greenfield Basic authenticationBasic authentication disabled by default after account creation
3e2928cfby Nicolas Dorier+29−12 files
Vendor flagged security relevance
Open full analysis →Source commit ↗