What the developer wrote
Authored by Boris Nagaev
blockchain: load database blocks strictly
What changed, and why it matters
This commit changes how btcd reads blocks from its internal database when starting up. Previously it used a loose block parser (wire.MsgBlock.Deserialize) that could accept data with extra trailing bytes. Now it uses btcutil.NewBlockFromBytes, which is stricter and rejects malformed or padded block data. The change is defensive: it makes the node refuse to load a block from disk if the stored bytes are not a clean, exact block. This could prevent certain database corruption or tampering scenarios from being silently accepted at startup.
Treat as a defensive hardening patch. Review whether other database deserialization sites (headers, UTXO set, transaction indexes) use similarly strict parsing. No urgent incident response is indicated unless independent evidence shows this lenient parsing was exploitable.
Security signals we found
Stricter deserialization of attacker-influenced/local database content
Removal of lenient block parsing during chain initialization
Potential mitigation against stored-data tampering or corruption being silently accepted
Evidence from the diff
In blockchain/chainio.go initChainState(), the code previously deserialized stored block bytes with wire.MsgBlock.Deserialize and then wrapped the result in btcutil.NewBlock. That path did not enforce that the input buffer contained only the block data. The patch replaces it with btcutil.NewBlockFromBytes, which internally uses wire.MsgBlock.DeserializeNoWitness or a strict deserialization that expects the bytes to represent exactly one block. The downstream best-state initialization is updated to use the returned btcutil.Block directly. This is a hardening change at the data-loading boundary; it does not by itself fix a known remote-exploitable vulnerability, but it removes a lenient parsing path that could mask local database corruption or maliciously padded records.
Changed components
blockchain/chainio.goinitChainState()block database loading pathInspect captured patch +3 / −4
diff --git a/blockchain/chainio.go b/blockchain/chainio.go
index 5d2c033..9ce58b1 100644
--- a/blockchain/chainio.go
+++ b/blockchain/chainio.go
@@ -1277,8 +1277,7 @@ func (b *BlockChain) initChainState() error {
if err != nil {
return err
}
- var block wire.MsgBlock
- err = block.Deserialize(bytes.NewReader(blockBytes))
+ block, err := btcutil.NewBlockFromBytes(blockBytes)
if err != nil {
return err
}
@@ -1304,8 +1303,8 @@ func (b *BlockChain) initChainState() error {
// Initialize the state related to the best block.
blockSize := uint64(len(blockBytes))
- blockWeight := uint64(GetBlockWeight(btcutil.NewBlock(&block)))
- numTxns := uint64(len(block.Transactions))
+ blockWeight := uint64(GetBlockWeight(block))
+ numTxns := uint64(len(block.MsgBlock().Transactions))
b.stateSnapshot = newBestState(tip, blockSize, blockWeight,
numTxns, state.totalTxns, CalcPastMedianTime(tip))
Why this scored 44/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.