Merge bitcoin/bitcoin#36494: wallet: reject unknown options in sendall

### doc/release-notes-36494.md
@@ -0,0 +1,7 @@
+Wallet
+------
+
+- `sendall` now rejects unknown keys in its `options` object instead of
+  silently ignoring them, like `send`, `fundrawtransaction` and
+  `walletcreatefundedpsbt` already do. Option values are also type-checked
+  before any coin is selected.

### src/wallet/rpc/spend.cpp
@@ -1387,8 +1387,26 @@ RPCMethod sendall()
             pwallet->BlockUntilSyncedToCurrentChain();
 
             UniValue options{request.params[4].isNull() ? UniValue::VOBJ : request.params[4]};
+            RPCTypeCheckObj(options,
+                {
+                    {"add_to_wallet", UniValueType(UniValue::VBOOL)},
+                    {"fee_rate", UniValueType()},
+                    {"include_watching", UniValueType(UniValue::VBOOL)},
+                    {"inputs", UniValueType(UniValue::VARR)},
+                    {"locktime", UniValueType(UniValue::VNUM)},
+                    {"lock_unspents", UniValueType(UniValue::VBOOL)},
+                    {"psbt", UniValueType(UniValue::VBOOL)},
+                    {"send_max", UniValueType(UniValue::VBOOL)},
+                    {"minconf", UniValueType(UniValue::VNUM)},
+                    {"maxconf", UniValueType(UniValue::VNUM)},
+                    {"version", UniValueType(UniValue::VNUM)},
+                    {"conf_target", UniValueType(UniValue::VNUM)},
+                    {"estimate_mode", UniValueType(UniValue::VSTR)},
+                    {"replaceable", UniValueType(UniValue::VBOOL)},
+                    {"solving_data", UniValueType(UniValue::VOBJ)},
+                },
+                /*fAllowNull=*/true, /*fStrict=*/true);
             InterpretFeeEstimationInstructions(/*conf_target=*/request.params[1], /*estimate_mode=*/request.params[2], /*fee_rate=*/request.params[3], options);
-            PreventOutdatedOptions(options);
 
 
             std::set<CTxDestination> addresses_without_amount;

### test/functional/wallet_sendall.py
@@ -298,6 +298,14 @@ def sendall_fails_on_specific_inputs_with_send_max(self):
             recipients=[self.remainder_target],
             inputs=[utxo], send_max=True)
 
+    @cleanup
+    def sendall_fails_on_invalid_options(self):
+        self.log.info("Test sendall fails on unknown options or options of the wrong type")
+        assert_raises_rpc_error(-3, "Unexpected key add_to_wllt",
+                self.wallet.sendall, recipients=[self.remainder_target], options={"add_to_wllt": "false"})
+        assert_raises_rpc_error(-3, "JSON value of type string for field add_to_wallet is not of expected type bool",
+                self.wallet.sendall, recipients=[self.remainder_target], options={"add_to_wallet": "false"})
+
     @cleanup
     def sendall_fails_on_high_fee(self):
         self.log.info("Test sendall fails if the transaction fee exceeds the maxtxfee")
@@ -591,6 +599,9 @@ def run_test(self):
         # Sendall fails when using send_max while specifying inputs
         self.sendall_fails_on_specific_inputs_with_send_max()
 
+        # Sendall fails on unknown options or options of the wrong type
+        self.sendall_fails_on_invalid_options()
+
         # Sendall fails when providing a fee that is too high
         self.sendall_fails_on_high_fee()