AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Merge bitcoin/bitcoin#36706: policy: remove unused GetVirtualTransactionInputSize

Public commit record

What the developer wrote

Authored by merge-script

91/100 · Strong
Merge bitcoin/bitcoin#36706: policy: remove unused GetVirtualTransactionInputSize

3e2cf63da5090d59218c66dcc9a54c0f8c67e648 policy: remove unused GetVirtualTransactionInputSize (fanquake)

Pull request description:

The last non-test caller was removed in 9b7ec393b8 (#26567). Since then it has only been used by the `tx_in` fuzz target and a helper in `wallet_tests`.

ACKs for top commit:
jpk68:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
l0rinc:
lightly tested code review ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
ismaelsadeeq:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648
sedited:
ACK 3e2cf63da5090d59218c66dcc9a54c0f8c67e648

Tree-SHA512: 5d59717d0e6cc900817854c35275f9009a07fc45bbaa3fda7c73e726c6f12108a789e2d35723df5b96c68865aec55a57dba95bdc6d940faf442bcb78570202b9
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit removes an unused helper function called GetVirtualTransactionInputSize and updates the few remaining callers to use an equivalent calculation directly. It is a routine code cleanup with no security relevance.

Recommended action

No security action required. This is a benign refactoring/cleanup change.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.