TZ
← All projectsTrezor

Trezor firmware

Firmware monorepo for Trezor One, Model T, and Safe devices.

BitcoinHardware walletsNormal
Repository coverage

2703 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

932security candidates315second-pass queue2675AI analyses
320commits · 30 days
564commits · 60 days
1361commits · 180 days
2624commits · 365 days
Backfill bands
Aug 5 → Feb 61298 seen115 candidatesComplete
Feb 6 → Jun 6775 seen58 candidatesComplete
Jun 6 → Jul 6217 seen13 candidatesComplete
Jul 6 → Aug 5360 seen54 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
490Strong · 80–100
1339Adequate · 60–79
869Thin · 40–59
5Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
tychovrahe292104292461
Roman Zeyde587185580272
PrisionMike945994273
Andrew Kozlik782976267
obrusvit21376213164
Jakub Janků22919182
Martin Pastyřík24823173
cepetr19982196059
Ioan Bizău23076230059
M1nd3r21173208071
Lukas Bielesch846784067
Martin Milata18146176063
Analysis record

Published AI watches

Last scanned 22 minutes ago

Low 37 AI analysisMessage 100 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(core/fido): don't fail if `_KEEPALIVE_STATUS_PROCESSING` is blocked

This update fixes a bug in the Trezor hardware wallet's FIDO2/WebAuthn support. Previously, when the device was busy and tried to send a 'still processing' keepalive message to the computer, it would crash the whole FIDO operation if the U…

Denial-of-service hardening: prevents a transient USB buffer-full condition from aborting a FIDO authentication/registration workflowException boundary added around low-level USB HID writeChangelog explicitly frames the change as a fix for FIDO interaction failure
e7e15170by Roman Zeyde+12−62 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): drop `USBIF.write_blocking()` and simplify FIDO2 keep-alive sending

This commit is a small internal cleanup in the Trezor hardware wallet's FIDO2 (WebAuthn) code. It removes an unused 'blocking write' USB function and replaces a general synchronous send routine with a simpler one that only sends one-byte '…

Removal of unused blocking USB write path reduces attack surfaceNo change to FIDO2 command parsing, signature generation, or credential storage logicNo bounds-checking or input-validation changes observed
f269eccdby Roman Zeyde+8−513 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore: remove libtropic's pin to develop branch

This commit removes a single line from the project's Git submodule configuration. It stops pinning the libtropic submodule to the 'develop' branch, meaning the project will now use the submodule's default branch (likely 'main' or 'master')…

8290eeefby M1nd3r+0−11 file
No security note in commit
Low 37 AI analysisMessage 70 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core/embed): clear temporary buffer across Optiga/Tropic calls

This is a hardening change for the random number generator inside Trezor hardware wallets. It makes sure that temporary memory holding secret random values from the Optiga and Tropic security chips is wiped immediately after use, rather th…

Sensitive intermediate buffer not cleared promptlyPotential stale-buffer reuse across RNG source boundariesDefense-in-depth memory sanitization for secure-element entropy
01ebda93by Roman Zeyde+2−21 file
No security note in commit
Informational 15 AI analysisMessage 72 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

test(core/ethereum): EIP-7702 tuple nonce must be non-zero

This commit only changes test data and expected screen fingerprints for Trezor's Ethereum EIP-7702 signing tests. It replaces one test case that used a nonce of 0 with the same scenario using a nonce of 67, because the real-world protocol …

Test-only change with no production code modificationEIP-7702 tuple nonce constraint reflected in test dataExpected UI test hashes regenerated for renamed test vector
76cd2ed4by Roman Zeyde+28−282 files
No security note in commit
Informational 15 AI analysisMessage 72 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

test(core): drop an unused parameter of `make_payment_request()`

This commit only cleans up test code by removing an unused 'session' argument from a helper function used in automated tests. It does not change the actual Trezor firmware or any code that runs on the device, so it has no security impact f…

6dd19fdcby Roman Zeyde+0−188 files
No security note in commit
Informational 15 AI analysisMessage 67 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

docs(core): document rng_fill_buffer_strong_time()

This commit only adds a plain-English comment explaining an existing function that estimates how long a random-number generation call takes. No code behavior changed, and nothing was fixed or added that affects security.

c5687f76by Andrew Kozlik+11−01 file
No security note in commit
Low 44 AI analysisMessage 77 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore: guard against insecure PRNG in bare-metal build

This commit adds compile-time guards to prevent an intentionally insecure random-number generator from being accidentally included in firmware that runs directly on Trezor hardware. It does not fix an active bug, but it adds safety rails s…

Compile-time guard around insecure PRNGExplicit block of bare-metal / freestanding targetsExisting production-build guard already present
4f8f4586by Andrew Kozlik+11−01 file
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

build(core): propagate emulator feature from projects

This commit is a build-system cleanup for the Trezor firmware's Rust code. It changes how the 'emulator' feature flag is passed between different software components. The firmware project no longer supports the emulator feature (which make…

5642074cby matejcik+5−44 files
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(build-docker): stop swallowing pub-bin copy errors

This change fixes a build script that was ignoring copy errors. Previously, the script would silently ignore any failure when copying public binary files, which could hide real problems. Now it only skips the copy when the file genuinely d…

Build script silently ignored copy failures before this fixFix removes unconditional `|| true` error suppressionKnown-benign missing files are now explicitly skipped with a file existence check
d829eda8by Andrew Kozlik+4−11 file
No security note in commit
Low 27 AI analysisMessage 93 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(core): digest EIP-1559/EIP-7702 magic without RLP encoding

This commit is a small internal cleanup in Trezor's Ethereum signing code. It changes how two special 'magic' bytes (the transaction type markers for newer Ethereum transaction formats) are fed into the cryptographic hash. Previously the c…

Refactor of cryptographic hashing path for Ethereum transaction signingRemoval of implicit assumption that RLP encodes small integers as single bytesChange affects EIP-1559 and EIP-7702 transaction type markers
2362bc6fby Roman Zeyde+6−32 files
No security note in commit
Informational 15 AI analysisMessage 98 · Strong
TZ TrezorTrezor firmware BitcoinHardware wallets

test(core): test RLP self-encoding bytestrings

This commit only adds a new unit test to the Trezor firmware codebase. It verifies that very short Ethereum RLP-encoded byte strings and small positive integers encode to themselves, which is a known property of the RLP specification. No p…

41538733by Roman Zeyde+16−01 file
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

docs: fix links outside book root

This commit only fixes broken or awkward documentation links inside the project's user guide. It replaces relative links that point outside the documentation folder with internal placeholder files or direct GitHub URLs. There is no change …

0d8d4b1bby Martin Milata+14−810 files
No security note in commit
Informational 18 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core): remove sha1 from regular FW

This commit removes the SHA-1 hashing function from the regular Trezor firmware. SHA-1 is an old, weak hash algorithm that is no longer considered secure for sensitive uses. The change deletes the code that exposes SHA-1 to apps running on…

Removal of a deprecated cryptographic primitive (SHA-1) from the firmware API surfaceReduction of attack surface and prevention of future misuse of a collision-vulnerable hashNo direct vulnerability patch or memory-safety bug is present in the diff
16d15774by M1nd3r+0−2006 files
No security note in commit
Low 27 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): pass static public key to `noise_xxpsk3_*_init()`

This commit changes how a cryptographic library sets up secure connections. Previously, the code automatically calculated the public key from the private key. Now, the caller must provide the public key directly. This is a code-quality ref…

Cryptographic key handling changed: public key is now supplied rather than derivedPotential reduction of key-mismatch risk if caller provides correct public keyNew null-pointer check added for static_public_key
1b3128a4by Ondřej Vejpustek+20−92 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): change order of parameters

This commit simply reorders the arguments of an internal function called dh() and updates every place that calls it. The actual math and security behavior are unchanged; it is a code cleanup with no security effect.

33a119eeby Ondřej Vejpustek+15−151 file
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): prefix enums

This commit simply renames two groups of internal status labels (called enums) in the Trezor firmware's cryptographic code. The old names like WAITING_FOR_REQUEST1 were shared between two different parts of the code, so the developer gave …

f1c74046by Ondřej Vejpustek+26−222 files
No security note in commit
Low 37 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

fix(crypto): prevent calling `memzero(NULL, ...)`

This commit fixes three places in the Trezor firmware's cryptographic code where a memory-clearing function could be called with a NULL pointer. In practice, passing NULL to memzero is harmless on Trezor's platform (it does nothing), but i…

NULL pointer passed to memory-zeroing helper in cryptographic codeUndefined behavior in C standard library contractDefensive hardening in Noise protocol implementation
0394e934by Ondřej Vejpustek+11−51 file
No security note in commit
Informational 18 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(crypto): return remote static key from `noise_xxpsk3_*_handle_*()`

This commit is a code cleanup (refactor) for the cryptographic handshake code used in Trezor devices. It changes how the other party's long-term public key is returned to the caller: instead of storing it inside an internal state structure…

Removal of long-term public key storage from internal handshake stateCaller-supplied output buffer for remote static public key reduces internal secret retentionError-path memzero of returned key material on failure
3ead1aa6by Ondřej Vejpustek+79−423 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

refactor(xtask): rename ProjectProfile to ProjectConfig

This commit is a simple rename from 'ProjectProfile' to 'ProjectConfig' in two Rust source files. It only changes variable names, struct names, and error messages. There is no change to program logic, security behavior, or how data is hand…

581b37bcby cepetr+18−182 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityrefactor(core): simplify THP session exception handlingby Roman Zeyde · b0e4b234 · Aug 26, 2025 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Roman Zeyde

refactor(core): simplify THP session exception handling

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This is a small internal code cleanup in Trezor firmware's message handling loop. It removes an optional 'no message' path and restructures exception handling so the loop continues cleanly after unexpected messages. There is no indication this fixes or introduces a security vulnerability.

Lower-priorityfeat(core): allow preempting stale THP channelsby Roman Zeyde · 0c3fa672 · Aug 26, 2025 · 6 filesMessage 80 · StrongLow 45Details
Commit message · Roman Zeyde

feat(core): allow preempting stale THP channels

In case an existing channel becomes unresponsive, we allow another channel on
the same interface to preempt the active workflow (by restarting the event loop).

[no changelog]

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Low 45/100

This commit changes how the Trezor device handles multiple encrypted USB-like communication channels. It lets a new channel on the same connection take over if an existing channel appears stuck for more than one second. The change is described as a feature, not a security fix, and there is no disclosed vulnerability or incident tied to it.

Lower-prioritychore: update releases.jsonby obrusvit · acd56d01 · Aug 26, 2025 · 1 fileMessage 47 · ThinInformational 15Details
Commit message · obrusvit

chore: update releases.json

[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply adds a new firmware version number (2.9.1) to a list of released versions for several Trezor hardware wallet models. It is a routine metadata update with no code changes and no security relevance visible in the diff.

Lower-prioritychore: update definitions timestampby obrusvit · 304ed84f · Aug 26, 2025 · 2 filesMessage 47 · ThinInformational 15Details
Commit message · obrusvit

chore: update definitions timestamp

[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply updates a timestamp that tells the Trezor device how new its built-in Ethereum network/token list must be. It is a routine data-version bump with no code logic changes and no security relevance visible in the commit.

AI review queueddocs(core): changelog for 2.9.1by obrusvit · aff66082 · Aug 26, 2025 · 26 filesMessage 57 · ThinInformational 15Details
Commit message · obrusvit

docs(core): changelog for 2.9.1

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit is purely a documentation update: it compiles the changelog for Trezor firmware version 2.9.1 by deleting individual changelog fragments and adding the final release notes to several CHANGELOG files. No source code, firmware logic, or security behavior is changed.

Lower-priorityfix(core/eckhart): remove menu from WordQuiz introby obrusvit · 6e9885a8 · Aug 26, 2025 · 2 filesMessage 77 · AdequateLow 31Details
Commit message · obrusvit

fix(core/eckhart): remove menu from WordQuiz intro

- there shouldn't be an option to skip backup

[no changelog]

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Low 31/100

This commit removes a 'Skip backup' menu option that had accidentally been left on a screen shown during the wallet backup process on the Trezor Safe 5 (Eckhart layout). The change prevents a user from bypassing the backup verification quiz, but it is a UI-only fix and does not by itself create or fix a security vulnerability in the cryptographic backup process.

Security candidatefix(core): check pairing start in wireless setupby obrusvit · c1640f55 · Aug 26, 2025 · 1 fileMessage 57 · ThinLow 49Details
Commit message · obrusvit

fix(core): check pairing start in wireless setup

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Low 49/100

This commit fixes a bootloader wireless setup workflow so it checks whether Bluetooth pairing actually started before continuing. Previously, the code ignored the return value of the pairing-start function, so if pairing failed to initiate, the setup would proceed anyway. The fix makes the workflow return a pairing-failed status instead. This is a defensive hardening change in the bootloader's BLE pairing path.

AI review queuedrefactor(python): simplify THP pairing state handlingby Roman Zeyde · 60cf3d88 · Aug 25, 2025 · 3 filesMessage 77 · AdequateInformational 15Details
Commit message · Roman Zeyde

refactor(python): simplify THP pairing state handling

Also, add more logging statements for THP pairing process.

[no changelog]

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a straightforward internal code cleanup in Trezor's Python library. It replaces two separate flags that tracked whether a device was paired with a single simpler flag, and adds extra debug logging. There is no indication this fixes or introduces a security vulnerability.

Lower-prioritychore(core): remove `print` statements from `_handle_code_entry_cpace()`by Roman Zeyde · 37ac98f0 · Aug 25, 2025 · 1 fileMessage 62 · AdequateInformational 21Details
Commit message · Roman Zeyde

chore(core): remove `print` statements from `_handle_code_entry_cpace()`

[no changelog]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 21/100

This commit removes leftover debug print statements from a Trezor hardware wallet pairing function. The prints could have exposed sensitive cryptographic material (a shared secret and authentication tag) during development or testing, but they were clearly marked as temporary test code and are now removed. There is no evidence this code ever shipped to production firmware.

Lower-priorityfix(python): improve `trezorctl` error handlingby Roman Zeyde · b5b6a74d · Aug 25, 2025 · 3 filesMessage 80 · StrongInformational 20Details
Commit message · Roman Zeyde

fix(python): improve `trezorctl` error handling

Following https://github.com/trezor/trezor-firmware/pull/5613.

[no changelog]

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 20/100

This commit refactors error handling in the Trezor Python client library and command-line tool. It removes some custom exception types and moves error printing into a shared helper. The changes appear to be a cleanup following an earlier pull request, not a fix for an active security vulnerability. There is no indication in the commit that this addresses a security issue.

Lower-priorityfix(core): unblock THP loop after 5s write timeoutby Roman Zeyde · f26829e0 · Aug 25, 2025 · 1 fileMessage 97 · StrongLow 47Details
Commit message · Roman Zeyde

fix(core): unblock THP loop after 5s write timeout

Stop retransmission if writes are blocked - e.g. due to USB flow control.
It allows restarting the event loop to handle other THP channels.

`loop.race()` is used, since it schedules a single timeout task per message - instead of `loop.wait.timeout_ms`, which schedules a timeout task once per packet.

[no changelog]

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 47/100

This change fixes a bug in the Trezor hardware wallet's THP (Trezor Host Protocol) communication layer. Previously, if the device was trying to resend a message but the USB host stopped accepting data (for example due to USB flow control), the retransmission loop could get stuck forever, blocking other THP channels. The patch adds a 5-second timeout so the loop can break out and let other communication channels proceed. It is a reliability/availability fix rather than a clear-cut vulnerability patch, though the stuck-loop condition could be abused to deny service to other channels.

AI review queuedfix(cardano): Return pubkeyby Peter Jaško · 389e1eba · Aug 25, 2025 · 7 filesMessage 62 · AdequateInformational 20Details
Commit message · Peter Jaško

fix(cardano): Return pubkey

This ends up being useful for software wallets.

62/100 · AdequateMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit adds the public key to the Cardano message-signing response. It is a feature enhancement for software wallets, not a fix for a vulnerability. There is no security defect in the change itself.

Lower-priorityfix: changelog formattingby Peter Jaško · 91f8c85a · Aug 25, 2025 · 2 filesMessage 47 · ThinInformational 15Details
Commit message · Peter Jaško

fix: changelog formatting

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a missing period to two changelog entries describing a new Cardano feature. There are no code changes and no security relevance.

Lower-prioritychore(tests): update fixturesby Ioan Bizău · 2168449c · Aug 25, 2025 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · Ioan Bizău

chore(tests): update fixtures

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates the expected test result hashes (called 'fixtures') for the user-interface test suite. It does not change any firmware, application, or cryptographic code. The changes are test-only data, so they do not create or fix any security vulnerability on their own.

AI review queuedchore(cardano): add missing translationsby David Misiak · 7fcd3ec8 · Aug 25, 2025 · 8 filesMessage 57 · ThinInformational 15Details
Commit message · David Misiak

chore(cardano): add missing translations

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds or updates translated text strings for the Cardano cryptocurrency feature. It replaces hard-coded English labels like 'Confirm message' and 'Message text' with references to the device's translation system, and updates the translation files, generated code, and a test marker. There is no change to security logic, cryptography, or how user approvals work.

AI review queuedchore(cardano): changes after rebaseby Peter Jaško · 2427d232 · Aug 25, 2025 · 5 filesMessage 57 · ThinInformational 16Details
Commit message · Peter Jaško

chore(cardano): changes after rebase

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 16/100

This commit is a routine cleanup after merging (rebasing) other Cardano code changes. It updates the Cardano message-signing flow to use newer internal APIs (sessions instead of raw clients, and a separate SLIP-21 keychain argument) and refreshes automated test snapshots. There is no indication it fixes or introduces a security vulnerability.

AI review queuedchore(cardano): rename payloadby Ioan Bizău · bfd66dbb · Aug 25, 2025 · 2 filesMessage 47 · ThinInformational 15Details
Commit message · Ioan Bizău

chore(cardano): rename payload

[no changelog]

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple internal code cleanup in the Cardano app of Trezor firmware. It renames a function parameter from 'payload_first_chunk' to 'payload' and switches from keyword arguments to positional arguments in one call. There is no change to user-visible behavior, security logic, or data handling.

AI review queuedfix(cardano): stop trimming long messagesby Ioan Bizău · 88af9542 · Aug 25, 2025 · 2 filesMessage 57 · ThinLow 34Details
Commit message · Ioan Bizău

fix(cardano): stop trimming long messages

[no changelog]

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit fixes a display issue in Trezor's Cardano message signing feature. Previously, very long messages were visually trimmed on the device screen, so the user could not see the full content before approving a signature. The patch removes the trimming limit and adds a test case for a long payload. The risk is that a user might unknowingly sign a message whose full content they did not review, but the signature itself is still produced over the complete message (not a truncated one).

AI review queuedchore(cardano): update UI fixturesby David Misiak · aff9f150 · Aug 25, 2025 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · David Misiak

chore(cardano): update UI fixtures

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit changes a single test marker so that a Cardano message-signing test runs on Trezor Model T/Core devices instead of being skipped on the older T1B1 model. It is a test-suite maintenance change with no effect on the actual firmware code that users rely on.

AI review queuedfeat(cardano): reject probable hashesby Peter Jaško · dde4ec8a · Aug 25, 2025 · 3 filesMessage 57 · ThinLow 36Details
Commit message · Peter Jaško

feat(cardano): reject probable hashes

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 36/100

This update makes Trezor's Cardano message-signing feature refuse to sign 28-byte payloads that look like cryptographic hashes. The goal is to prevent users from accidentally signing a hash of an unknown message, which could let an attacker trick them into authorizing something they did not read. The change is a simple heuristic: if the payload is exactly 28 bytes and is not made of ordinary printable text, the device now rejects it with an error.

AI review queuedfeat(cardano): replace chunking with length+offsetby Peter Jaško · adb9d194 · Aug 25, 2025 · 15 filesMessage 62 · AdequateLow 29Details
Commit message · Peter Jaško

feat(cardano): replace chunking with length+offset

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100

This commit rewrites how the Trezor device fetches the message payload during Cardano message signing. Instead of the host pushing fixed-size chunks to the device, the device now asks for a specific slice of data by sending a length and offset, and the host replies with exactly that slice. The change also removes the previous 1024-byte maximum payload size limit, so larger messages can now be signed. The code adds bounds checks on both sides, but because the device now requests the entire payload in one go, this could stress limited device RAM. There is no direct evidence in the commit that this fixes a reported security bug; it reads as a feature/refactoring change.

Security candidatefeat(cardano): stop hashing in message signingby Peter Jaško · 0e71c8da · Aug 25, 2025 · 12 filesMessage 57 · ThinLow 32Details
Commit message · Peter Jaško

feat(cardano): stop hashing in message signing

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 32/100

This commit removes the option to sign a hash of a Cardano message instead of the message itself. The device now always signs the actual message payload directly, up to a size limit. This is a feature/API change rather than a fix for an active security flaw, but it does eliminate a mode where users might have signed data they could not fully inspect.

Security candidatefeat(cardano): Show path, address params and longer payload chunkby Peter Jaško · dd20dc5e · Aug 25, 2025 · 4 filesMessage 85 · StrongLow 28Details
Commit message · Peter Jaško

feat(cardano): Show path, address params and longer payload chunk

Show signing path, validate with keychain, show address parameters and increase max displayed bytes of first payload chunk unless signing hash.

Also add issue number to changelog.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Low 28/100

This commit improves the Cardano message-signing feature on Trezor hardware wallets by showing users more details on the device screen before signing. It displays the signing path, the address parameters (if provided), and a larger chunk of the message payload when appropriate. It also tightens path validation by checking the path against the keychain and allowing minting paths in addition to public-key paths. These are defensive UI and validation hardening changes rather than fixes for an active vulnerability.

Security candidatefeat(cardano): Message signingby Peter Jaško · 4dcfaf18 · Aug 25, 2025 · 25 filesMessage 47 · ThinLow 28Details
Commit message · Peter Jaško

feat(cardano): Message signing

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundaryseed or entropy pathsigning or wallet path
AI analysis · Low 28/100

This commit adds a new feature to Trezor hardware wallets: the ability to sign arbitrary Cardano messages. It introduces new protocol messages, device firmware code to handle signing, and client libraries to use the feature. The signing process requires user confirmation on the device screen and includes safety checks, such as limiting unhashed payload length and validating ASCII display options. There is no direct evidence in the commit of a security vulnerability, but any new signing feature carries inherent risks if not fully reviewed.

Security candidatefix(cardano): Change display_ascii flag to prefer_hex_displayby Peter Jaško · 13f216af · Aug 25, 2025 · 11 filesMessage 77 · AdequateLow 29Details
Commit message · Peter Jaško

fix(cardano): Change display_ascii flag to prefer_hex_display

This makes the behavior more consistent with Ethereum message signing.

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 29/100

This commit renames and slightly changes a Cardano message-signing display option. Previously, the host had to explicitly request ASCII display, and the device would reject payloads that were not clean, readable ASCII. Now the host can ask the device to prefer hex display, and if ASCII display is preferred but the payload is not clean ASCII, the device falls back to showing hex instead of rejecting the request. This is a user-experience and consistency change, not a fix for a clear security vulnerability.