fix(core): use paragraph for `show_wait_text()`
What the developer wrote
Authored by Roman Zeyde
fix(core): use paragraph for `show_wait_text()`
[no changelog]
What changed, and why it matters
This commit is a routine user-interface cleanup. It changes the on-screen 'please wait' message in three Trezor firmware layouts to use a standard text paragraph component instead of a dedicated 'Connect' component. There is no indication this fixes a security bug or changes security behavior.
No security action required; treat as normal UI refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes the Connect component import and usage from show_wait_text() in the Bolt, Caesar, and Delizia UI layouts, replacing it with Paragraph::new(...).into_paragraphs(). The function still returns a RootComponent wrapping the wait text. No security boundary, input handling, or cryptographic code is touched.
Changed components
core/embed/rust/src/ui/layout_bolt/ui_firmware.rscore/embed/rust/src/ui/layout_caesar/ui_firmware.rscore/embed/rust/src/ui/layout_delizia/ui_firmware.rsInspect captured patch +9 / −16
diff --git a/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs b/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs
index 34c22bb0..ddd38b32 100644
--- a/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_bolt/ui_firmware.rs
@@ -9,7 +9,6 @@ use crate::{
translations::TR,
ui::{
component::{
- connect::Connect,
image::BlendedImage,
text::{
op::OpTextLayout,
@@ -1270,9 +1269,9 @@ impl FirmwareUI for UIBolt {
}
fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- let layout =
- RootComponent::new(Connect::new(text, fonts::FONT_NORMAL, theme::FG, theme::BG));
- Ok(layout)
+ Ok(RootComponent::new(
+ Paragraph::new(&theme::TEXT_NORMAL, text).into_paragraphs(),
+ ))
}
fn show_warning(
diff --git a/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs b/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
index 85953296..ca57d16d 100644
--- a/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_caesar/ui_firmware.rs
@@ -9,7 +9,6 @@ use crate::{
translations::TR,
ui::{
component::{
- connect::Connect,
text::{
op::OpTextLayout,
paragraphs::{
@@ -1383,9 +1382,9 @@ impl FirmwareUI for UICaesar {
}
fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- let layout =
- RootComponent::new(Connect::new(text, fonts::FONT_NORMAL, theme::FG, theme::BG));
- Ok(layout)
+ Ok(RootComponent::new(
+ Paragraph::new(&theme::TEXT_NORMAL, text).into_paragraphs(),
+ ))
}
fn show_warning(
diff --git a/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs b/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
index 83f52a89..ae7f4dd6 100644
--- a/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
+++ b/core/embed/rust/src/ui/layout_delizia/ui_firmware.rs
@@ -9,7 +9,6 @@ use crate::{
translations::TR,
ui::{
component::{
- connect::Connect,
swipe_detect::SwipeSettings,
text::{
op::OpTextLayout,
@@ -1301,13 +1300,9 @@ impl FirmwareUI for UIDelizia {
}
fn show_wait_text(text: TString<'static>) -> Result<impl LayoutMaybeTrace, Error> {
- let layout = RootComponent::new(Connect::new(
- text,
- fonts::FONT_DEMIBOLD,
- theme::FG,
- theme::BG,
- ));
- Ok(layout)
+ Ok(RootComponent::new(
+ Paragraph::new(&theme::TEXT_DEMIBOLD, text).into_paragraphs(),
+ ))
}
fn show_warning(
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.