rust-bitcoin

This commit fixes example code and a test helper that builds Bitcoin Taproot script-path witness data. The old code placed digital signatures in the wrong order on the transaction witness stack, following the order of an internal sorted map instead of the reverse order required by the Bitcoin Taproot specification (BIP-0342). A transaction finalized with the old ordering would be rejected by the Bitcoin network, so no funds could be stolen, but users copying the example could produce invalid transactions. The fix reads public keys from the script in their actual script order, then pushes the matching signatures in reverse.

This commit only changes test code. It replaces the use of an external random number generator (from the `rand` crate) with a small, deterministic pseudo-random number generator inside the `MerkleBlock` unit tests. The goal is to make the tests reproducible and remove a test-only dependency on the `rand` feature. There is no change to production code and no security vulnerability is introduced or fixed.

This commit is a documentation and test fix, not a security patch. It adds a comment explaining that an 'empty coinbase' helper produces a 0-byte scriptSig that is technically invalid under Bitcoin consensus rules (which require 2-100 bytes), but is kept for backward compatibility in PSBT workflows where the scriptSig is filled in later. It also re-enables and updates a previously ignored unit test to use a valid 2-byte coinbase scriptSig.

This commit is a routine version bump for a small Rust library called bitcoin-io, from version 0.3.0 to 0.4.0-rc.0. It updates lockfiles, a changelog, and dependency references in other crates so they all use the new version. There is no code change and no security issue visible in the commit.

This commit is purely a code-formatting cleanup. It runs the project's formatter across 58 files, adjusting whitespace, line breaks, import order, and adding two missing semicolons the formatter exposed. There are no functional code changes, no bug fixes, and no security-relevant alterations.

This is a routine Rust API improvement that lets two small data types be copied implicitly instead of requiring an explicit clone. It does not fix a security bug and does not introduce an obvious vulnerability.

This commit simply renames a local variable from 'rinsed' to 'roundtrip' in several test files. It is a cosmetic code cleanup with no functional changes and no security relevance.

This commit only removes documentation sections from README files in multiple Rust packages. It deletes redundant mentions of the minimum Rust version and licensing information, which are already present in the package manifest files. There are no code changes, no functional changes, and no security implications.

This commit changes version constraints for several in-development (release candidate) internal dependencies so Cargo will use an exact version rather than automatically picking a newer release candidate. It is a build/maintenance change to prevent unexpected dependency resolution, not a fix for a security vulnerability.

This commit changes a single version requirement in a Rust package file so that a pre-release dependency is pinned to an exact version rather than allowing newer release-candidate versions. It is a build-stability fix, not a security patch. There is no code change that fixes a vulnerability or changes runtime behavior.

This commit is a code-quality cleanup, not a security fix. It adds a `let _ = w[15];` line in two SHA hashing implementation files solely to silence a new Rust clippy lint about an unused assignment inside a macro on the final round of SHA-256 and SHA-512. The generated machine code and behavior are unchanged.

This commit is a routine code reorganization. It moves a helper macro that generates standard methods for array-like types from the main `bitcoin` crate into the shared `internals` crate. The goal is to let other crates (specifically `p2p`) use the macro without depending directly on `bitcoin`. The generated behavior is essentially unchanged, though a couple of deprecated `to_bytes` methods are moved from the macro into individual type definitions.

This commit fixes two typos in documentation comments. One incorrectly called a private key type an 'extended public key,' and another incorrectly referenced a different struct name in a conversion function's doc comment. These are purely cosmetic comment corrections and do not change any executable code.

This commit only reformats source code using the Rust formatter (cargo fmt). It changes whitespace, line breaks, and import grouping but does not alter program logic, behavior, or any security checks. There is no security issue.

This commit is a large but purely cosmetic code cleanup in the Rust Bitcoin library. It removes wildcard imports of error types (like `use Error::*`) and replaces them with explicit `Self::Variant` or fully-qualified names. The behavior of the code does not change; it only makes the source code easier to read and maintain.

This commit is a routine API cleanup for the rust-bitcoin library. It adds a few helper methods (to_signature, from_signature, len, iter) to the ECDSA serialized-signature type and reorders existing methods in the Taproot serialized-signature type so both types look the same. There is no security fix or behavior change that would affect users' funds or data.

This commit is a minor code cleanup. It imports two common Rust traits (`Borrow` and `Deref`) directly at the top of two source files, instead of referring to them with their full `core::...` module path inside the code. There is no functional change, no bug fix, and no security relevance.

This commit fixes a bug in how serialized Bitcoin signatures expose their byte content. Previously, code asking for the signature bytes could receive the entire internal buffer, including leftover or uninitialized bytes beyond the actual signature length. Now only the valid, used portion is returned. This prevents accidental misuse where someone might hash, encode, or transmit extra garbage bytes as if they were part of the signature.

This commit is a small internal code reorganization. It moves an existing conversion helper (so a serialized ECDSA signature can be viewed as a script 'push bytes' object) to a more central location, and adds an equivalent helper for Taproot signatures. There is no security fix or behavior change visible to users.

This commit removes the ability for outside code to directly modify the raw bytes of an ECDSA serialized signature object in the rust-bitcoin library. Previously, callers could obtain a mutable reference to the internal byte buffer and change it, which the developers consider meaningless because a signature is supposed to be a fixed cryptographic result. The change makes the type consistent with the taproot signature type, which already did not allow mutation. It is a hardening/correctness change rather than a fix for a known exploitable vulnerability.

This commit simply reorders existing code in a Rust source file. It moves two blocks of code (implementations of Deref and DerefMut for SerializedSignature) to a different location within the same file so the order matches another module. No code behavior is changed, no bugs are fixed, and no security issue is introduced.

This commit adds standard Rust comparison traits (equality and ordering) to a type that wraps a raw ECDSA signature byte array. It simply lets programmers compare these signature objects more conveniently; it does not change signature validation or introduce a security vulnerability.

This commit adds two new ways to display a taproot serialized signature as hexadecimal text (lowercase and uppercase). It is a pure API-consistency change to make taproot signatures match the existing ecdsa signature API. There is no security issue visible in the diff.

This commit is a straightforward internal code reorganization. It moves the SerializedSignature type from one module to another within the same crate, without changing its behavior or public API. There is no security fix or vulnerability here.

This commit is purely a code cleanup: it moves some trait implementation blocks for the ECDSA SerializedSignature type to a different location in the same file and reorders the Taproot Eq impl to sit next to PartialEq. No logic, behavior, or signatures changed.