Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
68/100 average clarity
702Strong · 80–100
1135Adequate · 60–79
582Thin · 40–59
151Opaque · 0–39
20security candidates with opaque commit messaging
This is a routine code cleanup in a Bitcoin library. It renames a simple data container from KeySource to KeyOrigin and gives it named fields (fingerprint and path) instead of numbered tuple slots (.0 and .1). The serialized format is inte…
This change is a routine internal cleanup: the key_expression crate stops depending directly on the secp256k1 cryptography library and instead uses a re-export provided by another internal crate called crypto. No user-facing behavior, type…
This is a small Cargo.toml fix in a Rust Bitcoin subcrate. When the optional 'serde' feature was enabled on the key_expression crate alone, it did not also enable serde on the network crate. That meant a type called NetworkKind could not b…
This is a routine update to a GitHub Actions helper used in automated testing workflows. It bumps the version of taiki-e/install-action, which downloads and installs Rust developer tools during CI runs. There is no change to the actual Bit…
This is a routine update to a GitHub Actions helper used only in automated security-scanning workflows. The new version adds minor improvements, including respecting proxy settings and verifying downloaded files with checksums. It does not…
Dependency bump of a third-party GitHub Action used in CI onlyUpstream release notes mention generic security improvements (checksum verification, npm install defaults, NO_PROXY)No CVE, advisory, or vendor security disclosure is present in the commit or supplied references
This commit removes automatic serde (serialization/deserialization) code generation from several Rust Bitcoin library crates and replaces it with hand-written implementations. The stated goal is to reduce dependencies and make the code eas…
Manual serde implementations replace derived ones, increasing the surface area for serialization-format bugsNo validation logic changes are visible in the diffNo mention of security fixes, CVEs, or vulnerability reports in commit message or PR description
This commit updates the project's automated Rust compiler version from 1.99.1 to 1.100.0 and adjusts a CI cache cleanup script to match a new directory layout used by Cargo 1.100. It is purely an infrastructure/maintenance change to keep a…
This is a build-system improvement, not a code change. It updates a CI helper tool and makes the automated API-checking job fail if a private internal crate accidentally becomes part of the public API. That prevents future leaks of interna…
CI guardrail added to prevent private dependency leaks into stable crate public APIsTool bump enables detection of re-exported private dependenciesNo source-code vulnerability is patched
This is a minor internal code cleanup in the Rust Bitcoin library. It changes how two functions (Xpriv::decode and Xpub::decode) build their error messages when an input is the wrong length. The behavior is the same before and after; only …
This is a routine API cleanup, not a security fix. The change removes one way of naming a Bitcoin unit ('MicroBitcoin' / 'uBTC') and keeps the equivalent 'bits' form. Any code that previously used the old name will fail to compile or fail …
No security signal: public API deprecation and enum variant removalNo memory safety, cryptographic, or consensus code modifiedError message change is informational only
This commit is a code cleanup and feature-gating refactor for the rust-bitcoin library's key_expression crate. It makes more BIP32 (Bitcoin wallet key derivation) types available when the 'alloc' memory allocator feature is disabled, and s…
Refactor of error types and parsing paths for Xpriv/Xpub base58 decodingSwitch from unbounded base58 decode to fixed-size array decode (78 bytes)Removal of explicit length-check error path in favor of decoder-reported length error
This change only adds `#[cfg_attr(miri, ignore)]` annotations to a handful of slow unit tests so they are skipped when run under Miri, a Rust interpreter used for detecting undefined behavior. It does not change any production code, consen…
This commit only updates version numbers in package configuration files (Cargo.toml) for internal dependencies so that all crates in the project require the same minimum versions of shared libraries. There are no code changes, no bug fixes…
This is a routine update to a GitHub Actions helper used in automated testing workflows. It changes which version of a third-party tool-installer action is used, but only for installing the cargo-mutants testing tool. There is no indicatio…
This commit updates the version of a helper tool called cargo-binstall used in two automated GitHub workflows. The change only affects internal build/CI tooling and does not alter the rust-bitcoin library code that users install or run. Th…
This is a routine update by Dependabot to the GitHub CodeQL upload-sarif action used in a scheduled security scanning workflow. It changes one pinned commit hash to a newer version of the same action. There is no indication this introduces…
This commit is a minor code cleanup in the Rust Bitcoin library. It changes how an error message is built when decoding BIP32 extended keys, switching from one nested construction style to two chained calls. The actual behavior and returne…
This commit fixes a bug in how optional Bitcoin amount and fee-rate values are read from JSON when those fields are inside a flattened struct and the value is null. Previously, the code would error out because it did not handle a special s…
Deserialization failure in optional numeric types under serde flattenMissing serde visitor method (visit_unit) causing runtime errorsRegression test added for null handling in flattened structs
This is a routine dependency update by Dependabot, bumping the version of a GitHub-provided action used to upload security scan results. There is no indication of a security vulnerability in the project itself or in this change.
This is a routine automated update by Dependabot that changes the version of a GitHub Action used to install Rust tools in two CI workflows. There is no indication of a security issue in the commit itself, and no verified security referenc…
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI review queuedMerge rust-bitcoin/rust-bitcoin#6992: primitives: Correct and clarify docsby Andrew Poelstra · 73db3a0a · Oct 14, 2026 · 16 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6992: primitives: Correct and clarify docs
8097bdaa1e9b92714f85d7f4f15b4e255021c242 primitives: Remove stale unstable note from README (Jamil Lambert, PhD) e9041b039c220fc64113b37a8788cf78537dae84 primitives: Document crate features and MSRV (Jamil Lambert, PhD) fa84c3fc7221ae97eb0b78e1eec02081108656b4 primitives: Capitalize Merkle in docs (Jamil Lambert, PhD) c9430965f58a6cb4f284e8ca1f3bdb519f89d9c7 primitives: Use BIP-XXXX notation (Jamil Lambert, PhD) bb760210458976ef9c3a8293a62720c7536c6afa primitives: Use standard CVE notation (Jamil Lambert, PhD) b7bcfac4d704e75c68906e537e5475168f78a1f9 primitives: Use third person in rustdoc summaries (Jamil Lambert, PhD) 04956357bbaeb025c8fc099b020f7a5998a57b9e primitives: Format witness docs consistently (Jamil Lambert, PhD) ccbf616a2e74efd2e348c270b791ca15df59d9fa primitives: Tidy script docs (Jamil Lambert, PhD) 7a2f58bef437f603042de081d59d011d0ac7fce8 primitives: Document decoder validity checks (Jamil Lambert, PhD) df7cc438ab6fbf012bcb9ab03b693f96aa3f79a7 primitives: Fix incorrect witness docs (Jamil Lambert, PhD) 5eb34b691c7b61a233c7e104902b1bf5d5a60910 primitives: Fix outdated transaction docs (Jamil Lambert, PhD) 548eb1381ded056531881e4da56d49776c11a684 primitives: Fix incorrect block validation docs (Jamil Lambert, PhD) 6a7a5a396783e20706bc34ad36740132bdb2dcf3 primitives: Fix incorrect script docs (Jamil Lambert, PhD) 8d2dae13cdb99a156a6d2348a9523e3ac215124e primitives: Fix incorrect opcode docs (Jamil Lambert, PhD)
Pull request description:
The primitives docs misdescribe some opcodes and witness behavior, overstate what block validation checks, and omit decoder rejection rules.
Correct the opcode descriptions against Bitcoin Core and the remaining claims against the implementation. Document crate features and MSRV, and align wording with project conventions.
Docs only changes.
ACKs for top commit: apoelstra: ACK 8097bdaa1e9b92714f85d7f4f15b4e255021c242; successfully ran local tests tcharding: ACK 8097bdaa1e9b92714f85d7f4f15b4e255021c242
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a documentation-only pull request for the rust-bitcoin primitives crate. It corrects and clarifies comments, README text, and rustdoc descriptions. No executable code, logic, or behavior was changed. The changes improve accuracy of descriptions about block validation, transaction decoding rules, opcodes, and witness behavior, but they do not alter how the software runs or fix any vulnerability.
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7042: Remove `IS_SIGNED` from public interfaceby Andrew Poelstra · b503517a · Oct 14, 2026 · 1 fileMessage 100 · StrongTriage 0Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7042: Remove `IS_SIGNED` from public interface
5ef8bc4c87c237c6c2f0b1f472a92e7c2465c5fc Remove `IS_SIGNED` from public interface (Martin Habovstiak)
Pull request description:
Unfortunately, I missed the PR that sealed the amount types, so didn't flag that there but here's a fixup PR.
Originally, the `serde` implementations for amounts were using `TryFrom` and `From` traits to avoid exposing ad-hoc APIs. This worked but it might have allowed downstream users to rely on this for their custom types which would prevent us changing the implementation.
cbb253072ce6ab159961c74446f22d87d1430101 attempted to address this but introduced a different problem: downstream users could now rely on `IS_SIGNED` being present despite the trait being sealed. We could just revert to `try_from(-1)` but arguably, once we do have a sealed trait, an explicit method is more principled, so instead this changes associated const to a function that requires a ZST token that is unnameable by downstream which prevents calling the function. Unfortunately, this now cannot be `const` but the function is so painfully trivial it's practically certain it will get inlined.
ACKs for top commit: apoelstra: ACK 5ef8bc4c87c237c6c2f0b1f472a92e7c2465c5fc; successfully ran local tests tcharding: ACK 5ef8bc4c87c237c6c2f0b1f472a92e7c2465c5fc
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
e4db9c5aea015ea7606b6036dbe6dd0afff114eb Use backticks for code in Returns docs (Jamil Lambert, PhD) 5cc0fd2f447c2cf97c884910ffa3cd31bf7258f4 Fix network_hash return docs (Jamil Lambert, PhD) 1db36aeb3c5a02df33730d5d15665ee6a83624e5 Improve U256 overflowing operation docs (Jamil Lambert, PhD)
Pull request description:
`U256` overflowing operation docs call the result "the addition" and say an overflow "would have occurred" when the boolean means it did. Return docs also mix bare and backticked code values such as `true`, `None` and `Err`.
Reword the `U256` docs, fix the `network_hash` docs, and format code values in return docs as code.
ACKs for top commit: apoelstra: ACK e4db9c5aea015ea7606b6036dbe6dd0afff114eb; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetycryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit is purely a documentation cleanup. It puts code words like true, false, None, and Err inside backticks in Rust doc comments, fixes a grammar mistake (who's -> whose), and rewords descriptions of U256 arithmetic overflow so they correctly say an overflow did occur rather than would occur. No program logic, function behavior, or security properties were changed.
6ec25a0e4548b16c2eb8c09a0bf2843565456533 internals: Bump version to 0.8.1 (Tobin C. Harding) 0b83d84c08bb92a453a7b0ecdfab07c440ad781d internals: Fix the changelog header links (Tobin C. Harding)
Pull request description:
In preparation for release add a changelog entry, bump the version, and update the lock files.
Also upgrade the dep for all users in this workspace.
`internals 0.8.0` is to be yanked because of #7002
ACKs for top commit: apoelstra: ACK 6ec25a0e4548b16c2eb8c09a0bf2843565456533; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This is a routine patch release (bitcoin-internals 0.8.1) that bumps a dependency version across the rust-bitcoin workspace. The changelog says it fixes a bug introduced in 0.8.0 (#7002) and that 0.8.0 will be yanked, but the actual code fix is not included in this commit. The commit only changes version numbers and lock files, so it is a release-tracking merge rather than a security patch itself.
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7018: bitcoin: Add TapScriptExt::is_immediately_validby Andrew Poelstra · 778025e9 · Oct 13, 2026 · 2 filesMessage 91 · StrongTriage 0Details
I add `TapScriptExt::is_immediately_valid`, which scans a tapscript for `OP_SUCCESSx` as Bitcoin Core does before executing it. Under leaf version `0xc0` the first `OP_SUCCESSx` makes the script valid, even after a failing `OP_VERIFY` or `OP_RETURN`. rust-bitcoin classifies single opcodes but has no such scan, so whoever builds a leaf around a counterparty's script, as in #1325, has to write it.
It walks `instructions()` as Core walks `GetOp`. It returns `Err(EarlyEndOfScript)` for a truncated push met before any `OP_SUCCESSx`, where Core's scan stops with `SCRIPT_ERR_BAD_OPCODE`, so the script is invalid; a plain `bool` would merge that with `Ok(false)`.
The second commit tests every `OP_SUCCESSx` value on the script cases of the `opsuccess` spenders in Core's `feature_taproot.py`, and every other opcode on its `notsuccessx` case.
Closes #1325.
*Assisted-by: my usual tools (Claude Opus 5.5, Internet, computer). Mistakes are mine.*
ACKs for top commit: apoelstra: ACK 72462c96b68135384225d9ddf642f414b1bb3480; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#6986: docs: move OP_CODESEPARATOR docs to ScriptCodeby Andrew Poelstra · 78534172 · Oct 13, 2026 · 2 filesMessage 91 · StrongInformational 19Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6986: docs: move OP_CODESEPARATOR docs to ScriptCode
dc7982737271eda761b004f750811508e4a68eb9 docs: move OP_CODESEPARATOR docs to ScriptCode (jrakibi)
Pull request description:
Document `OP_CODESEPARATOR` logic and move the docs from the `WitnessScript` `AsRef` impl to the `ScriptCode` definition. They also apply to script code derived from `RedeemScript` and `ScriptPubKey`, so document them once instead of repeating them on each `AsRef` impl.
ACKs for top commit: tcharding: ACK dc7982737271eda761b004f750811508e4a68eb9 apoelstra: ACK dc7982737271eda761b004f750811508e4a68eb9; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change is purely documentation. It moves existing explanations about a special Bitcoin script opcode, OP_CODESEPARATOR, from one place in the code comments to a more central location. No program logic, code behavior, or security checks were changed.
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7040: bitcoin: Add Arbitrary impl for P2wpkhScriptCodeby Andrew Poelstra · c6de5912 · Oct 13, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7040: bitcoin: Add Arbitrary impl for P2wpkhScriptCode
1b45ab1ca08b0f6c9b10795bf322a884450800f9 bitcoin: Add Arbitrary impl for P2wpkhScriptCode (jrakibi)
Pull request description:
As per policy, public types should implement Arbitrary. Add the missing implementation for the new P2wpkhScriptCode.
ACKs for top commit: apoelstra: ACK 1b45ab1ca08b0f6c9b10795bf322a884450800f9; successfully ran local tests tcharding: ACK 1b45ab1ca08b0f6c9b10795bf322a884450800f9
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#7038: feat(units): add saturating arithmetic methods to Weightby Andrew Poelstra · 89c8eb3d · Oct 13, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7038: feat(units): add saturating arithmetic methods to Weight
6bda64fb9cbb76c46803e9e5f4baaf7fc35f6ecf feat(units): add saturating arithmetic methods to Weight (luhrhenz)
Pull request description:
Adds `saturating_add`, `saturating_sub` and `saturating_mul` to `Weight`, following `FeeRate` and the existing `checked_*` methods.
All three are `const fn`, `#[inline]`, `#[must_use]`, and delegate to the underlying `u64` saturating operations. Tests cover normal operation, boundary values, and overflow/underflow saturation.
No `saturating_div`: unsigned division cannot overflow, so there is nothing to saturate, and `checked_div` already returns `None` for `rhs == 0`.
Staging branch held in this fork. Relates to upstream rust-bitcoin closes #7031
ACKs for top commit: apoelstra: ACK 6bda64fb9cbb76c46803e9e5f4baaf7fc35f6ecf; successfully ran local tests tcharding: ACK 6bda64fb9cbb76c46803e9e5f4baaf7fc35f6ecf
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 15/100
This commit adds safe math helpers to a Bitcoin library's Weight type. It lets developers add, subtract, and multiply weight values without worrying about overflow or underflow, because the result will clamp to the largest or smallest allowed value instead of wrapping around. There is no security flaw here; it is a routine feature addition with tests.
AI review queuedMerge rust-bitcoin/rust-bitcoin#6980: chacha20: Add 8 block processing on x86 with AVX2by Andrew Poelstra · 9df7fdea · Oct 13, 2026 · 2 filesMessage 100 · StrongInformational 17Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6980: chacha20: Add 8 block processing on x86 with AVX2
3440ac87a2e171e51f792f76918a9803fa8f4c48 chacha20: Add 8 block processing on x86 with AVX2 (rustaceanrob)
Pull request description:
This adds 8 block processing via the 256 bit registers supported by AVX2. Unlike SSE2 or Neon, AVX2 is detected during runtime. The steps are identical to the other SIMD files, except over 8 blocks rather than 4. Because of the `target_feature` flag, the unsafe annotation had to move to the function definition. I opted out of `cpu-features` because `no-std` users can compile with the AVX2 flag if SSE2 isn't enough. That seems like a very niche usecase to add an additional dependency considering this is primarily used in P2P contexts.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit adds a faster way to run the ChaCha20 encryption routine on modern Intel/AMD processors that support AVX2 instructions. It does not fix a bug and is not described as a security patch. The change is a performance optimization that processes 8 blocks at once instead of 4, with a runtime CPU-feature check so it only runs on compatible hardware. There is no indication in the commit or supplied references that this resolves a known vulnerability.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7034: build(deps): bump taiki-e/install-action from 2.85.8 to 2.85.12by Andrew Poelstra · 7641b3d1 · Oct 13, 2026 · 2 filesMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7034: build(deps): bump taiki-e/install-action from 2.85.8 to 2.85.12
9f7802e98dfd18a4d35307fa231963d6632e2e51 build(deps): bump taiki-e/install-action from 2.85.8 to 2.85.12 (dependabot[bot])
Pull request description:
Bumps [taiki-e/install-action](https://github.com/taiki-e/install-action) from 2.85.8 to 2.85.12. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/releases">taiki-e/install-action's releases</a>.</em></p> <blockquote> <h2>2.85.12</h2> <ul> <li> <p>Update <code>zola@latest</code> to 0.23.3.</p> </li> <li> <p>Update <code>wasm-tools@latest</code> to 1.256.0.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.2.10.</p> </li> <li> <p>Update <code>syft@latest</code> to 1.51.0.</p> </li> <li> <p>Update <code>prek@latest</code> to 0.4.13.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.8.4.</p> </li> <li> <p>Update <code>editorconfig-checker@latest</code> to 3.11.1.</p> </li> <li> <p>Update <code>cargo-tarpaulin@latest</code> to 0.37.1.</p> </li> <li> <p>Update <code>cargo-rdme@latest</code> to 2.2.1.</p> </li> <li> <p>Update <code>biome@latest</code> to 2.5.8.</p> </li> </ul> <h2>2.85.11</h2> <ul> <li> <p>Update <code>zola@latest</code> to 0.23.2.</p> </li> <li> <p>Update <code>wasm-bindgen@latest</code> to 0.2.127.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.3.</p> </li> <li> <p>Update <code>osv-scanner@latest</code> to 2.5.0.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.8.3.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 1.112.0.</p> </li> <li> <p>Update <code>editorconfig-checker@latest</code> to 3.10.0.</p> </li> </ul> <h2>2.85.10</h2> <ul> <li> <p>Update <code>uv@latest</code> to 0.12.2.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.2.7.</p> </li> <li> <p>Update <code>cosign@latest</code> to 3.1.3.</p> </li> <li> <p>Update <code>coreutils@latest</code> to 0.10.0.</p> </li> <li> <p>Update <code>cargo-rdme@latest</code> to 2.2.0.</p> </li> <li> <p>Update <code>cargo-crap@latest</code> to 0.4.3.</p> </li> </ul> <h2>2.85.9</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md">taiki-e/install-action's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file.</p> <p>This project adheres to <a href="https://semver.org">Semantic Versioning</a>.</p> <!-- raw HTML omitted --> <h2>[Unreleased]</h2> <h2>[2.87.27] - 2026-10-09</h2> <ul> <li> <p>Update <code>vacuum@latest</code> to 0.32.0.</p> </li> <li> <p>Update <code>uv@latest</code> to 0.12.24.</p> </li> <li> <p>Update <code>typos@latest</code> to 1.51.1.</p> </li> <li> <p>Update <code>tombi@latest</code> to 1.7.3.</p> </li> <li> <p>Update <code>syft@latest</code> to 1.54.1.</p> </li> <li> <p>Update <code>release-plz@latest</code> to 0.3.170.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.10.4.</p> </li> <li> <p>Update <code>kingfisher@latest</code> to 2.11.1.</p> </li> <li> <p>Update <code>hyperfine@latest</code> to 2.0.0.</p> </li> <li> <p>Update <code>dprint@latest</code> to 0.61.1.</p> </li> <li> <p>Update <code>cargo-nextest@latest</code> to 0.9.148.</p> </li> <li> <p>Update <code>cargo-neat@latest</code> to 0.6.0.</p> </li> <li> <p>Update <code>cargo-binstall@latest</code> to 1.25.2.</p> </li> </ul> <h2>[2.87.26] - 2026-10-06</h2> <ul> <li> <p>Update <code>tombi@latest</code> to 1.7.2.</p> </li> <li> <p>Update <code>prek@latest</code> to 0.5.5.</p> </li> <li> <p>Update <code>mise@latest</code> to 2026.10.3.</p> </li> <li> <p>Update <code>kache@latest</code> to 1.0.0.</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/taiki-e/install-action/commit/b20dedce73af6905cdc30d6611090c9b67557c8d"><code>b20dedc</code></a> Release 2.85.12</li> <li><a href="https://github.com/taiki-e/install-action/commit/952d13c8bb10d7e37f96fa2c8131338550a62663"><code>952d13c</code></a> ci: Skip cargo-rdme on x86_64 macOS</li> <li><a href="https://github.com/taiki-e/install-action/commit/c8724e7258d0b8f8188a94aec0c00ae9da81edd7"><code>c8724e7</code></a> Update <code>zola@latest</code> to 0.23.3</li> <li><a href="https://github.com/taiki-e/install-action/commit/1e2851961856b8e59aa67309dcdeb9fd45a60d51"><code>1e28519</code></a> Update <code>wasm-tools@latest</code> to 1.256.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/16f665d1bb4999982189aa73d32553092c80f123"><code>16f665d</code></a> Update <code>tombi@latest</code> to 1.2.10</li> <li><a href="https://github.com/taiki-e/install-action/commit/25e38b2b350c9e2addea1001edc5b1f1b78063ed"><code>25e38b2</code></a> Update <code>syft@latest</code> to 1.51.0</li> <li><a href="https://github.com/taiki-e/install-action/commit/0f7e9596044f5db8a5ae0c0b7496f88f904d3685"><code>0f7e959</code></a> Update <code>prek@latest</code> to 0.4.13</li> <li><a href="https://github.com/taiki-e/install-action/commit/e6f5eae5835582e8aba218eae90439a2635f4db5"><code>e6f5eae</code></a> Update <code>mise@latest</code> to 2026.8.4</li> <li><a href="https://github.com/taiki-e/install-action/commit/d2b89fd558f00d5f5ee0f1809698cd002c9bd096"><code>d2b89fd</code></a> Update kingfisher manifest</li> <li><a href="https://github.com/taiki-e/install-action/commit/ac9692ffa4e50d3b54c0d5a10733aa529f6228d6"><code>ac9692f</code></a> Update <code>editorconfig-checker@latest</code> to 3.11.1</li> <li>Additional commits viewable in <a href="https://github.com/taiki-e/install-action/compare/cb33e69fad06166ca28a42b2575e4dadabf62ee8...b20dedce73af6905cdc30d6611090c9b67557c8d">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: apoelstra: ACK 9f7802e98dfd18a4d35307fa231963d6632e2e51; successfully ran local tests satsfy: ACK 9f7802e98dfd18a4d35307fa231963d6632e2e51
This is a routine Dependabot update that changes the version of a third-party GitHub Action used only in automated testing workflows. The action installs developer tools like cargo-mutants. There is no change to the actual Bitcoin library code, no user-facing behavior change, and no security issue described in the commit or its references.
Security candidateMerge rust-bitcoin/rust-bitcoin#7035: build(deps): bump astral-sh/setup-uv from 9.0.0 to 10.0.0by Andrew Poelstra · 9427fff4 · Oct 13, 2026 · 2 filesMessage 96 · StrongInformational 18Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7035: build(deps): bump astral-sh/setup-uv from 9.0.0 to 10.0.0
7d4530345e92fa25fe8349a4c354b7db8d6bc41e build(deps): bump astral-sh/setup-uv from 9.0.0 to 10.0.0 (dependabot[bot])
Pull request description:
Bumps [astral-sh/setup-uv](https://github.com/astral-sh/setup-uv) from 9.0.0 to 10.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/setup-uv/releases">astral-sh/setup-uv's releases</a>.</em></p> <blockquote> <h2>v10.0.0 🌈 Disable automatic caching for sensitive events and new QOL features</h2> <h2>Changes</h2> <p>Another breaking release, directly after v9.0.0 but we think the added security justifies that.</p> <h3>Extra security by default</h3> <p>If you use the default <code>enable-cache: auto</code> this will now <strong>DISABLE THE CACHE</strong> to protect against cache poisoning for the following events:</p> <ul> <li><code>pull_request_target</code></li> <li><code>workflow_run</code></li> <li><code>release</code></li> </ul> <p>You can read the full reasoning in <a href="https://redirect.github.com/astral-sh/setup-uv/issues/984">astral-sh/setup-uv#984</a></p> <h3><code>version: latest-known</code></h3> <pre lang="yaml"><code>- name: Install the latest version of uv known to setup-uv uses: astral-sh/setup-uv@v10.0.0 with: version: "latest-known" </code></pre> <p>This will now install the latest version with a checksum that is known by this action. The <a href="https://github.com/astral-sh/setup-uv/blob/4f6036f71cec78afb113b323f220c9185d983c12/src/download/checksum/known-checksums.ts">known <code>uv</code> checksums</a> are automatically updated but will take a release of this action to take effect. You won't be always using the latest & greatest but you will have an extra level of security.</p> <h3>Read python version from <code>.tool-versions</code></h3> <pre lang="yaml"><code>- name: Install uv based on the version defined in .tool-versions and also set python uses: astral-sh/setup-uv@v10.0.0 with: version-file: "pyproject.toml" </code></pre> <p>Will now also set the python version if it is defined in <code>.tool-versions</code>. You can read the details <a href="https://github.com/astral-sh/setup-uv/blob/main/docs/advanced-version-configuration.md#install-a-version-defined-in-a-requirements-or-config-file">in the docs</a></p> <h2>🚨 Breaking changes</h2> <ul> <li>Disable automatic caching for sensitive events <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/992">#992</a>)</li> </ul> <h2>🐛 Bug fixes</h2> <ul> <li>Reject paths in .tool-versions <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/1007">#1007</a>)</li> </ul> <h2>🚀 Enhancements</h2> <ul> <li>Read Python version from .tool-versions <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/996">#996</a>)</li> <li>Add latest-known version selector <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/993">#993</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/astral-sh/setup-uv/commit/ae62891fec2bb8e7d6c99fc78c9fec3a63790f8d"><code>ae62891</code></a> chore(deps): roll up Dependabot updates (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/1013">#1013</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/f9cdb47d487aee2be8925d1e57290177ad9e1ac2"><code>f9cdb47</code></a> Reject paths in .tool-versions (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/1007">#1007</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/4f6036f71cec78afb113b323f220c9185d983c12"><code>4f6036f</code></a> Require pull requests for Dependabot rollups (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/1005">#1005</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/8d6402c9b71205b2d8d0b82de531d8fed8430182"><code>8d6402c</code></a> chore(deps): roll up Dependabot updates (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/1004">#1004</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/46f427bd47c794e99536b75ffaa9f27602425027"><code>46f427b</code></a> Read Python version from .tool-versions (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/996">#996</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/8ed89c51143f65ea13eaba62db51dbb8ea52d0a3"><code>8ed89c5</code></a> ci: pin Alpine container image (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/995">#995</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/8473c7fea42cdfd540f4b01317a17ac5f54126ae"><code>8473c7f</code></a> chore(deps): roll up Dependabot updates (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/994">#994</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/18d451d679e1650bc59f25f17116168d04f30748"><code>18d451d</code></a> Add latest-known version selector (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/993">#993</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/f45168497b927d08c229345a5ab9ad5c85418d0b"><code>f451684</code></a> Disable automatic caching for sensitive events (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/992">#992</a>)</li> <li><a href="https://github.com/astral-sh/setup-uv/commit/b68407c192114b6e47cc45b98289832c3df00d5e"><code>b68407c</code></a> chore: update known checksums for 0.12.3 (<a href="https://redirect.github.com/astral-sh/setup-uv/issues/991">#991</a>)</li> <li>Additional commits viewable in <a href="https://github.com/astral-sh/setup-uv/compare/c771a70e6277c0a99b617c7a806ffedaca235ff9...ae62891fec2bb8e7d6c99fc78c9fec3a63790f8d">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: satsfy: ACK 7d4530345e92fa25fe8349a4c354b7db8d6bc41e apoelstra: ACK 7d4530345e92fa25fe8349a4c354b7db8d6bc41e; successfully ran local tests
This is a routine update to a GitHub Actions helper used to install a Python tool called uv. The new version of the helper disables its built-in cache during sensitive workflow events to reduce the risk of cache poisoning. The change only affects two internal security-scanning workflows and does not alter the rust-bitcoin library code that users install.
Security candidateMerge rust-bitcoin/rust-bitcoin#7036: build(deps): bump dtolnay/rust-toolchain from 7e38f4b43b4db5c8dd498af069a4f6196df1d067 to e2a55d2ffb04f378e9626c28d38b36d230d1e12fby Andrew Poelstra · a44bee6a · Oct 13, 2026 · 4 filesMessage 91 · StrongInformational 16Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7036: build(deps): bump dtolnay/rust-toolchain from 7e38f4b43b4db5c8dd498af069a4f6196df1d067 to e2a55d2ffb04f378e9626c28d38b36d230d1e12f
Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from 7e38f4b43b4db5c8dd498af069a4f6196df1d067 to e2a55d2ffb04f378e9626c28d38b36d230d1e12f. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/rust-toolchain/commit/e2a55d2ffb04f378e9626c28d38b36d230d1e12f"><code>e2a55d2</code></a> Merge pull request <a href="https://redirect.github.com/dtolnay/rust-toolchain/issues/187">#187</a> from dtolnay/pwn</li> <li><a href="https://github.com/dtolnay/rust-toolchain/commit/6af9a09a9f985be78d729e2c9b2440bdb0314675"><code>6af9a09</code></a> Unify flags[@] and downgrade[@]</li> <li><a href="https://github.com/dtolnay/rust-toolchain/commit/83d06109b7912fe94032e68e59feb6b9e3070e34"><code>83d0610</code></a> Safely handle action inputs</li> <li>See full diff in <a href="https://github.com/dtolnay/rust-toolchain/compare/7e38f4b43b4db5c8dd498af069a4f6196df1d067...e2a55d2ffb04f378e9626c28d38b36d230d1e12f">compare view</a></li> </ul> </details> <br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ACKs for top commit: satsfy: ACK ceb67fdbc796e5f8e63fc02f9076f90beb48613b apoelstra: ACK ceb67fdbc796e5f8e63fc02f9076f90beb48613b; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit updates the version of a third-party GitHub Action used to install Rust in the project's automated workflows. The new version of the action fixes a security issue in how it handled workflow inputs, which could potentially be exploited in supply-chain attacks. The change only affects the project's own CI/build automation, not the Rust Bitcoin library code that end users run.
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7026: Automated weekly update to rustc (to nightly-2026-10-10) on masterby Andrew Poelstra · c443777b · Oct 13, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7026: Automated weekly update to rustc (to nightly-2026-10-10) on master
7afdfe45cdbb2f2db1d1184901b6d1f84ab08f7c Automated update to rustc nightly-2026-10-10 (Update Nightly Rustc Bot)
Pull request description:
Automated update to Cargo.toml workspace metadata by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
ACKs for top commit: tcharding: ACK 7afdfe45cdbb2f2db1d1184901b6d1f84ab08f7c satsfy: ACK 7afdfe45cdbb2f2db1d1184901b6d1f84ab08f7c
Security candidateMerge rust-bitcoin/rust-bitcoin#7017: key_expression: Add BIP-0032 test vector 4by Andrew Poelstra · 1a62a03d · Oct 13, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7017: key_expression: Add BIP-0032 test vector 4
475e7a2232d3ef6788a20d837c65f106858912c4 key_expression: Add BIP-0032 test vector 4 (Ferdinando Ametrano)
Pull request description:
The tests in `key_expression/src/bip32.rs` cover BIP-0032 test vectors 1, 2, 3 and 5. This adds vector 4, which derives a hardened child from a private key with a leading zero byte (see btcsuite/btcutil#172).
The data is copied from BIP-0032 and checked with the existing `test_path` helper. The test passes on master with no code change.
*Assisted-by: my usual tools (Claude Sonnet 5.5, Internet, computer). Mistakes are mine.*
ACKs for top commit: apoelstra: ACK 475e7a2232d3ef6788a20d837c65f106858912c4; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialdefensive validationfuzzing or regression evidencecryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only adds a new test case to the project's test suite. It does not change any production code. The new test verifies that the library correctly handles a specific Bitcoin key derivation scenario (BIP-32 test vector 4, involving a private key with a leading zero byte). The test already passes before this commit, so no bug is being fixed here.
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7024: units: use sealed AmountOps trait for amount serde boundsby Andrew Poelstra · cbb25307 · Oct 12, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7024: units: use sealed AmountOps trait for amount serde bounds
Close https://github.com/rust-bitcoin/rust-bitcoin/issues/6961
The serde helpers distinguished `Amount` from `SignedAmount` by attempting a shameful -1 sat conversion. This PR introduces a sealed `AmountOps` marker trait in the amount `serde` module that replaces it and the repeated `Into`/`TryFrom` bounds.
Note that `serialize()` receives a reference and dereferences it, so a `Copy` trait is globally applicable to all situations `AmountOps` gets used. I included it in `AmountOps` but it was not raised in issue.
ACKs for top commit: tcharding: ACK 3dee423fa11df209542c6c7a46c7bb91dea56864 apoelstra: ACK 3dee423fa11df209542c6c7a46c7bb91dea56864; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge rust-bitcoin/rust-bitcoin#6956: bitcoin: introduce ScriptCode for sighash computationby Andrew Poelstra · 4dcd466b · Oct 12, 2026 · 12 filesMessage 100 · StrongInformational 19Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#6956: bitcoin: introduce ScriptCode for sighash computation
dc64b80c64a062badef7f070c60be329862e13fe bitcoin: accept ScriptCode in P2WSH sighash (jrakibi) b7dab15c0912524f19e9234f2923613c7dda3ec8 bitcoin: test legacy and Segwit script code (jrakibi) 00462c353ae26e8a6c39e2500a6e36724975ae45 bitcoin: accept ScriptCode in legacy sighash (jrakibi) b0eb34c9a7a9c066883bceb03990232cbf513e04 bitcoin: return P2wpkhScriptCode from p2wpkh_script_code (jrakibi) 0ece781f091b113616756f79a4a1100db20b8ea7 bitcoin: change SegWit v0 encoding to accept ScriptCode (jrakibi) ab63f7a73db5ccdeb5a7d4178c157542510815dd bitcoin: add P2wpkhScriptCode (jrakibi) 8940e6697c2c77ab938c5c206e8d02d0d73f8df0 primitives: add AsRef<ScriptCode> for RedeemScript and ScriptPubKey (jrakibi) 1cfb377923fb746ab4fe30f0a61e2d2e6b5db07c primitives: add AsRef<ScriptCode> for witness scripts (jrakibi) ee4e9f0be5560c950c93ad057e28649339a71028 primitives: add new ScriptCode type (jrakibi)
Pull request description:
Introduce `ScriptCode` for sighash computation and `P2wpkhScriptCode` to hold the fixed 25 byte P2WPKH script code without allocating.
I tried to make the commits as atomic as possible and explain the reason behind each change in the commit message.
For witness scripts, I only added `AsRef<ScriptCode>` since the witness script is not always the script code. For the new `P2wpkhScriptCode`, it makes sense to implement `Deref` because it already holds the complete P2WPKH script code.
For OP_CODESEPARATOR handling in Segwit, we don’t need to introduce any removal logic as we did for legacy, since the remaining separators must be kept. tho it's still up to the caller to remove everything up to and including the last executed OP_CODESEPARATOR before the signature check, as clarified in the doc comment.
In #6079, Kix proposed `ScriptCodeBuf([u8; SCRIPT_CODE_LEN])`. I used `P2wpkhScriptCode` instead because ScriptCodeBuf might suggest a type that covers other output types too. I’m happy to rename it to ScriptCodeBuf if preferred.
Closes https://github.com/rust-bitcoin/rust-bitcoin/issues/6079, https://github.com/rust-bitcoin/rust-bitcoin/issues/6808 and #4135
ACKs for top commit: apoelstra: ACK dc64b80c64a062badef7f070c60be329862e13fe; successfully ran local tests
This is a code-quality and type-safety refactor for the rust-bitcoin library. It introduces a dedicated ScriptCode type for computing Bitcoin transaction signatures (sighashes), replacing the previous practice of reusing the WitnessScriptBuf type. The change makes the API clearer and reduces the chance that developers accidentally pass the wrong kind of script when signing transactions. There is no direct security vulnerability being patched here; it is a preventive correctness improvement.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100
This is a purely cosmetic code-formatting commit. A bot ran the nightly rustfmt tool and re-indented or rewrapped lines in four source files. No program logic, security checks, or behavior were changed.
Security candidateMerge rust-bitcoin/rust-bitcoin#7023: Evaluate macro arguments once in load_int_le and impl_hexby Andrew Poelstra · 497d877c · Oct 12, 2026 · 2 filesMessage 91 · StrongLow 32Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7023: Evaluate macro arguments once in load_int_le and impl_hex
f5ba7ffcc43a031b9c0a8b36ad78d90dc4902c2a internals: Test impl_hex evaluates the lookup once (PeterXMR) 13da54c82b8f468d3f8a3bb1e86095168e2b6bc6 internals: Evaluate impl_hex lookup table once (PeterXMR) a792c1a96a05d6948a1ef962ad932e461f449314 hashes: Test load_int_le evaluates its arguments once (PeterXMR) 05721fc5aaf4c13a478e04cf7e43b7dcccc7ffbc hashes: Evaluate load_int_le arguments once (PeterXMR)
Pull request description:
Follow-up to the discussion on rust-bitcoin/hex-conservative#264, where apoelstra asked for an audit of rust-bitcoin for `macro_rules!` arguments that get evaluated more than once, and for a "hit count" unit test that locks the property in.
I checked every `macro_rules!` definition in the workspace for `expr`, `tt` and `block` captures that appear more than once in an expansion. Only two library macros re-evaluate a runtime argument:
* `load_int_le!` in `hashes/src/siphash24/mod.rs` expanded `$buf` twice and `$i` three times. * `impl_hex!` in `internals/src/u256.rs` expanded `$lookup` twice inside the per-byte loop, so the lookup table expression was evaluated 64 times per formatted `U256`.
Everything else is either a compile-time position (array lengths, const generics), a place expression that cannot be bound (`round!` in sha256, `compress!` in siphash24), mutually exclusive branches (`write_err!`, `read_push_data_len!`), or a test-only macro, so those are left alone.
Both fixes bind the argument with `match $x { x => ... }` as discussed in the hex-conservative PR. Each fix commit is followed by a test commit that passes a counting block expression as the argument and asserts it is hit exactly once; without the fix commit the tests observe 2/3 and 64 evaluations respectively.
The audit and patches were produced with the help of an LLM (Claude Fable 5.1, see the `Assisted-by` trailers) and reviewed by me.
ACKs for top commit: Kixunil: ACK f5ba7ffcc43a031b9c0a8b36ad78d90dc4902c2a apoelstra: ACK f5ba7ffcc43a031b9c0a8b36ad78d90dc4902c2a; successfully ran local tests; these are easy fixes so might as well merge them even if we decide to fix the macros later
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Low 32/100
This merge commit fixes two internal Rust macros that accidentally evaluated their arguments multiple times instead of once. In one case, a buffer and index used in a hashing function were evaluated 2-3 times per call; in the other, a hex-character lookup table was rebuilt 64 times every time a large number was formatted as hex. The patch binds each argument to a single variable using a match expression, and adds tests that prove the arguments are now evaluated exactly once. These are correctness/performance hygiene fixes rather than an obvious remote exploit, but repeated evaluation of user-supplied expressions in macros can hide subtle bugs or side effects.
Security candidateMerge rust-bitcoin/rust-bitcoin#7014: Make source destructure official policy and apply it everywhereby Andrew Poelstra · db3686c3 · Oct 12, 2026 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7014: Make source destructure official policy and apply it everywhere
A follow up of https://github.com/rust-bitcoin/rust-bitcoin/pull/6872#discussion_r4203301150
Add a new policy rule `P-ERROR-SOURCE`. An error with no inner error implements `source` by destructuring `self` and returning `None`. Adding a field later fails to compile at `source` instead of returning `None`.
The whole workspace already does this since the [sweep that introduced it](https://github.com/rust-bitcoin/rust-bitcoin/pull/6293), but nothing in the policy documents or enforces it. The consequence is that 3 posteriorly created types missed it. Fixed the two bip32 derivation errors in key_expression and `FeatureDataError` in p2p.
The last commit adds an internal link to `From<Infallible>` rule, which is not necessary but makes the document better IMO.
ACKs for top commit: apoelstra: ACK ad1906b2cd4c97e0108deb7d78b4d26d0a2e25cf; successfully ran local tests tcharding: ACK ad1906b2cd4c97e0108deb7d78b4d26d0a2e25cf
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialcryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This is a code-quality and documentation patch. It adds a project policy saying that when a Rust error type has no underlying cause, the `source` method should explicitly destructure the error's fields before returning `None`. This makes future additions to the error type fail to compile unless `source` is updated, preventing accidental omissions. The patch also applies this style to three recently-added error types. There is no runtime behavior change and no security vulnerability is fixed or introduced.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7011: Use Returns headings only for complex return docsby Andrew Poelstra · ebc7dda3 · Oct 12, 2026 · 15 filesMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7011: Use Returns headings only for complex return docs
Docs use `# Returns` headings inconsistently. Some return values that need several sentences or paragraphs and have no heading, while others that fit in a few words do.
Add `# Returns` headings where the return value needs a longer description, and replace headings on simple return docs with a single "Returns …" sentence.
Closes #7006
ACKs for top commit: satsfy: ACK 4959bf7e69eeb5ac7488402d0a95c8484517736c apoelstra: ACK 4959bf7e69eeb5ac7488402d0a95c8484517736c; successfully ran local tests tcharding: ACK 4959bf7e69eeb5ac7488402d0a95c8484517736c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes documentation comments in Rust source files. It standardizes when to use '# Returns' headings versus simple 'Returns ...' sentences. No code behavior was altered, so there is no security impact.
AI review queuedMerge rust-bitcoin/rust-bitcoin#7009: primitives: Fix hash serde invalid length error messageby Andrew Poelstra · 7e142bdb · Oct 11, 2026 · 1 fileMessage 91 · StrongInformational 20Details
Deserializing a hash from bytes of the wrong length gives "expected N", instead of the value of N in the error message.
Pass the visitor itself so the error uses `expecting()`, and includes the expected number of bytes.
Add a test that checks the error message contains the expected length.
ACKs for top commit: Kixunil: ACK b7b29a82ae0f2e51249174107c7fbc6cb150e0e2 apoelstra: ACK b7b29a82ae0f2e51249174107c7fbc6cb150e0e2; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit fixes only the wording of an error message shown when someone tries to deserialize a Bitcoin hash from the wrong number of bytes. It does not change any security behavior, validation, or data handling; it only makes the error message include the expected length (e.g., '32') instead of the placeholder text 'N'.
Security candidateMerge rust-bitcoin/rust-bitcoin#7022: taproot-primitives: Add consensus validation tests for LeafVersionby Andrew Poelstra · 7723efad · Oct 11, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7022: taproot-primitives: Add consensus validation tests for LeafVersion
a4eca1edbff5aabff13284a442fb5e81330e631a taproot-primitives: Add consensus validation tests for LeafVersion (Jaydbrown)
Pull request description:
This PR adds specific unit tests for `taproot_primitives` covering valid and invalid leaf versions:
- `leaf_version_future_valid`: Locks the rule that even, non-tapscript bytes (`0x00`, `0x02`, `0xc2`, `0xc4`, `0xfe`) round-trip through `from_consensus` and `to_consensus`. (The BIP tests in `bitcoin/tests/taproot.rs` only unwrap versions that already appear in vectors). - `leaf_version_invalid_rejected`: Makes sure `0x50` (annex prefix) returns an error as it is not a valid leaf. Verifies odd bytes (`0x01`, `0x03`, `0x51`, `0xc1`, `0xc3`, `0xff`) are invalid bytes and fail as per BIP-341/BIP-342. This test verifies invalid leaf versions are rejected. - `serde_leaf_version`: Exercises deserialization round-trip for `0xc2` and rejection of invalid values (`80`, `193`, and `256`) using `IntoDeserializer` behind the existing `serde` feature, requiring no extra dependencies or lockfile changes.
ACKs for top commit: apoelstra: ACK a4eca1edbff5aabff13284a442fb5e81330e631a; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only adds new unit tests for an existing Bitcoin Taproot leaf-version validation function. It does not change any production code, fix a bug, or alter behavior. There is no security issue in the commit itself.
Lower-priorityMerge rust-bitcoin/rust-bitcoin#7010: primitives: Name script and witness decoder errorsby Andrew Poelstra · 34e6bcf8 · Oct 11, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Andrew Poelstra
Merge rust-bitcoin/rust-bitcoin#7010: primitives: Name script and witness decoder errors
fb7d3e59e6c104dc572309f9971656b6ea61b50e primitives: Clarify script and witness errors (Jamil Lambert, PhD)
Pull request description:
The `ScriptBufDecoderError` and `WitnessDecoderError` messages are just "decoder error" and "vec decoder error", so when they are shown on their own it is not clear what failed to decode. The two witness variants also do not say which part of decoding went wrong.
Say "failed to decode script" for scripts, and describe the lengthprefix and unexpected end of data cases separately for witnesses.
ACKs for top commit: Kixunil: ACK fb7d3e59e6c104dc572309f9971656b6ea61b50e apoelstra: ACK fb7d3e59e6c104dc572309f9971656b6ea61b50e; successfully ran local tests
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference