rust-bitcoin

units, consensus_encoding: fix up lints

Simplify `Decodable` trait

The `Decodable` trait already required that a decoder can be created
without providing any extra arguments and it required that the output of
the decoder is `Self`, implying that no decoder can be reused for
different types.

We observe that simply requiring that `Decoder` impls `Default` is
practically the same thing - requires constructibility without
arguments. By bounding `Decoder` on `Default` in addition to `Decoder`
and providing a default implementation of the method we simplify the
implementations: they now only need to impl `Default` which often can be
derived and specify the associated decoder type.

Remove now-useless overrides of `decoder`

The previous commit added a default impl for the `decoder` method which
renders the existing ones uselsess overrides. This commit simply removes
all of them.

Extend CI action to enforce encodable fuzzing

Since the round-trip fuzz targets function similarly to the encodable
comparison fuzz target, it's possible to extend the CI action to check
both fuzz targets to ensure that all Encodable types are represented.
In doing so, we can be sure that all new Encodable types roundtrip,
and match their previous implementations.

Extend encodable coverage action to check the encoding_roundtrip
targets for inclusion of all Encodable types on branch.

Assisted-by: Claude Opus 4.6

Update manifest and github yaml

In order to reduce the diff in the previous patch, the actual changes
generated by the generate-files.sh script should be split into a new
patch.

Run fuzz/generate-files.sh.

Introduce fuzz targets to test roundtrip for all encodable types

Since bitcoin 0.32, consensus encoding has been rebuilt from the ground
up with the consensus_encoding crate. To improve confidence in the new
encoder and decoder implementations, they should be fuzzed to ensure
consistent roundtrip behaviour.
To improve efficiency, each type should be fuzzed in it's own target
file, generated programmatically by a script when calling
generate-files.sh.

Add a script to generate type encoding roundtrip targets that verify
type -> encoding -> type roundtrips.

Assisted by: Claude Opus 4.6

p2p: Wrap NetworkMessageDecoder to check payload len

In the old implementation of the NetworkMessage decoding, the true
payload length was checked against the claimed value specified in the
message header. The new version does not do so.

Add PayloadLengthMismatch error variation for
V1NetworkMessageDecoderError.
Rename NetworkMessageDecoder to NetworkMessageDecoderInner and add a
wrapper that checks the payload length against the provided value in
the constructor.

crypto: Make trivial types no-alloc

Having just moved from bitcoin, the code in crypto is all written
assuming the presence of alloc. In the new crate, it is better if the
alloc feature can be used correctly, and have most of the functionality
enabled even in a no-alloc environment.

Remove alloc feature from the modules and only alloc gate things which
can't trivially be used no-alloc.

Make unrecognized field of SighashTypeParseError an InputString

At present, the entire SighashTypeParseError type relies on alloc due
to the presence of the String field "unrecognized". The InputString
in internals is designed to replace such fields and conditionally
enables or disables typical string functionality depending on alloc.

Replace the unrecognized field of SighashTypeParseError with
InputString. Adjust Display impl of SighashTypeParseError accordingly.

Move sighashtype FromStr tests to crypto

The EcdsaSighashType and TapSighashType FromStr tests are currently
located in bitcoin. This means testing regressions to the FromStr impl
requires running a significantly larger test set for no reason. These
should be located alongside the impls themselves in crypto.

Move sighashtype_fromstr_display tests to crypto::sighash.

Implement Serde traits for ArrayVec

This implementation is a prerequisite for the serde traits
impl for `WitnessVersion` and `WitnessProgram`.

Add tests covering round-trip serialization, capacity overflow errors,
and wire-format compatibilitywith slices using both JSON and Bincode.

Update API files

fuzz: remove psbt fuzz targets and document explicit local bitcoin dependency

p2p: add V1MessageHeader constructor

Adds a constructor to `V1MessageHeader` which also computes the 4 byte
checksum as defined by protocol docs. This constructor is used to
compose a network header that can be transmitted over the network stream.

Any network message (payload) must be directly preceded in the network
stream by a header. In that way, the receiving client knows how many
bytes to read, and what message to interpret.

A working code example might be a Pong response:
```
let message = bitcoin_p2p_messages::message::Pong(nonce);
let msg_header = V1MessageHeader::new(magic, &message, "pong");

// write the header to stream
encoding::encode_to_writer(&msg_header, &stream);

// write message to stream
encoding::encode_to_writer(&message, &stream);
```

Note that Currently, CommandString wraps a Cow<'static, str>, so the
lifetime of `cmd` must match the static lifetime. However, the protocol
documents define this as a 12 byte field, so this can and should be
changed at some point.

The fields defined in `V1MessageHeader` is the first four fields of a
message structure. An example given in the docs of message header is
given as:

```
Message Header:
F9 BE B4 D9 - Main network magic bytes
76 65 72 73 69 6F 6E 00 00 00 00 00 - "version" command
64 00 00 00 - Payload is 100 bytes long
35 8d 49 32 - payload checksum (byte order)
```

Remove confusing byte literals in tests

Use hex instead of bytes to maintain consistency across all other
tests which uses hex.

The hex string upholds the properties of the byte string (length,
validity) and is parsed via the `hex!` macro.

p2p: Remove legacy encoding from `lib`

p2p: Remove legacy encoding from `merkle_tree`

p2p: Remove legacy encoding from `address`

p2p: Remove legacy encoding from `message_filter`

p2p: Remove legacy encoding from `message_blockdata`

p2p: Remove legacy encoding from `message_network`

p2p: Remove legacy encoding from `message_bloom`

p2p: Remove legacy encoding from BIP-152

p2p: Remove legacy encoding in `message`

crypto: Change to_public_key to return FullPublicKey

In general, modern bitcoin code should be using either the compressed
FullPublicKey or the XOnlyPublicKey. Users should try to avoid the
legacy optionally-compressed public key. To this end, the types were
renamed. To further consolidate this, the to_public_key methods
throughout the key module should also return FullPublicKey, with the
existing behaviour relegated to new to_legacy_public_key.

Change all to_public_key functions to return FullPublicKey and
introduce corresponding to_legacy_public_key functions to return
LegacyPublicKey where necessary.