LL
← All projectsLightning Labs

LND

Go implementation of a complete Lightning Network node.

BitcoinLightning NetworkNormal
Repository coverage

1407 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

142security candidates195second-pass queue1287AI analyses
88commits · 30 days
194commits · 60 days
617commits · 180 days
1245commits · 365 days
Backfill bands
Aug 5 → Feb 6405 seen5 candidatesComplete
Feb 6 → Jun 6665 seen28 candidatesComplete
Jun 6 → Jul 689 seen4 candidatesComplete
Jul 6 → Aug 569 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

67/100 average clarity
324Strong · 80–100
661Adequate · 60–79
391Thin · 40–59
31Opaque · 0–39
1security candidate with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Olaoluwa Osuntokun20942204474
Elle Mouton26832268167
ziggie45016413165
Yong28513171
LNBiG111173
Jared Tobin909171
bitromortac661153071
yyforyongyu83861068
Erick Cestari26726070
Andras Banki-Horvath11311072
Gijs van Dam33230073
ziggieXXX2226070
Analysis record

Published AI watches

Last scanned 55 minutes ago

Moderate 62 AI analysisMessage 58 · Thin
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11212 from ziggie1984/disable-legacy-channels

This change stops LND from opening new Lightning channels using the old 'legacy' commitment format. The legacy format makes it harder to recover funds if something goes wrong, because the money owed to you is tied to a secret key that chan…

Prevents opening new channels with the legacy commitment type, whose tweaked to_remote output complicates data-loss recoveryCloses a negotiation path where an empty channel_type TLV bypassed feature checks and forced a legacy channelAdds explicit RPC and wire rejection with a dedicated error code
112cb5f3by ziggieXXX+265−4716 files
Vendor flagged security relevance
Moderate 56 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11223 from gijswijs/legacy-dust-retribution-fix

This update fixes a bug in how LND handles old-style punishment transactions when a channel partner tries to cheat. Previously, tiny (dust) HTLCs were left as blank placeholder entries in the punishment data, which could cause the node to …

nil-pointer dereference risk in breach retribution pathlegacy revocation log handling inconsistency with modern formatdefensive hardening added for trimmed/dust HTLCs
500ca51fby ziggieXXX+168−146 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11190 from Roasbeef/zpay32-reject-duplicate-payment-hashes

This change tightens how LND reads Lightning invoices (BOLT 11). Previously, if an invoice contained more than one payment hash field, LND would silently keep the first one and ignore the rest. Now it rejects the invoice entirely. The rele…

Behavior change from 'use first duplicate field' to 'reject duplicate fields'New error type ErrDuplicatePaymentHash returned on duplicate payment hash fieldsMalformed/unsupported-length duplicate payment hash now treated as duplicate and rejected
86306f89by Yong+147−106 files
No security note in commit
Moderate 62 AI analysisMessage 98 · Strong
LL Lightning LabsLND BitcoinLightning Network

zpay32: reject duplicate payment hash fields

This change tightens how LND reads Lightning invoices. Previously, if an invoice contained more than one payment hash field, LND would silently keep the first valid one and ignore the rest. Now it rejects such invoices outright. This preve…

Behavioral change from silent first-field acceptance to explicit rejection of duplicate payment hash fieldsPrevents invoice parsing from depending on field ordering when multiple payment hashes are presentCovers malformed first field + valid second field, closing a potential bypass
e2f27063by Olaoluwa Osuntokun+147−106 files
Vendor flagged security relevance
Moderate 53 AI analysisMessage 58 · Thin
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11132 from yyforyongyu/task-11129-pong

This change fixes how LND answers network 'ping' messages from other Lightning nodes. Previously, LND would sometimes silently ignore valid pings to limit reply traffic, which violates the Lightning protocol (BOLT 1) and could make a peer …

Protocol compliance fix: BOLT 1 requires a Pong for every valid PingRemoved silent suppression of Pong replies that could cause peer timeout/misbehaviorUnified rate limiting now accounts for amplification bandwidth, not just ping count
d3d1f1d0by Olaoluwa Osuntokun+274−1715 files
Vendor flagged security relevance
Low 33 AI analysisMessage 90 · Strong
LL Lightning LabsLND BitcoinLightning Network

itest: stop creating legacy channels

This commit updates LND's integration tests to stop using an obsolete 'legacy' channel type and adds a test confirming that LND now rejects that legacy type. The commit message says the real fix is elsewhere in the same pull request: previ…

Deprecated commitment format (legacy) is now rejected by RPCTest added to verify legacy channel type is refusedUnused legacy node configuration flag removed
03d8b09dby ziggie+24−85 files
No security note in commit
Moderate 60 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11198 from gijswijs/amp-setlocal-reconstruction-fix

This change fixes a bug in LND's handling of AMP (Atomic Multi-Path) payments. Previously, if one partial payment set failed to reconstruct its secret preimage, the entire invoice was canceled, including unrelated partial payment sets from…

Denial-of-service against reusable static AMP invoices by causing unrelated accepted HTLC sets to be canceledIncorrect invoice state transition from set-local failure to global invoice cancellationAvailability impact on multi-payer AMP invoice scenarios
88959aecby Olaoluwa Osuntokun+155−44 files
Vendor flagged security relevance
Low 29 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11200 from ziggie1984/build-go-1.27.1

This commit updates the Go programming language version used to build LND from 1.25.13/1.26.6 to 1.26.8 (language version) and 1.27.1 (toolchain). It also regenerates many automatically generated RPC files and adjusts linter settings. The …

Go version bump may indirectly address unlisted runtime/standard-library security fixesLarge regenerated protobuf files suggest dependency/toolchain refresh rather than logic changeLinter configuration expanded to suppress new checks, consistent with a toolchain upgrade
ef4820e5by Olaoluwa Osuntokun+4932−412670 files
No security note in commit
Informational 15 AI analysisMessage 92 · Strong
LL Lightning LabsLND BitcoinLightning Network

build: adopt focused golangci-lint v2.13 checks

This commit is a routine build-maintenance change. It updates the project's Go linter configuration to a newer version and fixes the resulting style warnings: a WebSocket header spelling and several documentation comments that didn't start…

bada7ea3by ziggie+27−1911 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
LL Lightning LabsLND BitcoinLightning Network

lnrpc: regenerate protos with Go 1.27

This commit is a housekeeping change that regenerates automatically generated RPC binding files using a newer Go compiler version. The only differences are in code comments (doc-comment formatting), not in actual program logic or API behav…

dd523108by ziggie+4501−369826 files
No security note in commit
Informational 20 AI analysisMessage 100 · Strong
LL Lightning LabsLND BitcoinLightning Network

build: fix Go 1.27 compatibility

This commit is a routine build-and-test maintenance patch to make the LND codebase compile and pass tests with the upcoming Go 1.27 release. It upgrades the project's custom linter tool, refreshes many indirect tool dependencies, adjusts o…

No production code changesNo vulnerability fix or CVE reference presentDependency-only refresh in tools module (development tooling)
6b54a387by ziggie+365−3706 files
No security note in commit
Informational 15 AI analysisMessage 80 · Strong
LL Lightning LabsLND BitcoinLightning Network

build: bump Go language and toolchain versions

This commit is a routine maintenance update that changes which version of the Go programming language is used to build the lnd project. It does not change any application logic, fix a bug, or address a security vulnerability. The project i…

b1f9ca66by ziggie+39−3930 files
No security note in commit
Moderate 60 AI analysisMessage 83 · Strong
LL Lightning LabsLND BitcoinLightning Network

invoices: cancel only the failing AMP set on reconstruction failure

This commit fixes a bug in LND's invoice handling for reusable AMP (Atomic Multi-Path) invoices. Previously, if one payment set failed to reconstruct its preimage, the entire invoice was canceled, even though other valid payment sets on th…

Denial-of-service-like availability impact: a malicious or buggy payer could cause a whole reusable AMP invoice to be canceled, blocking legitimate concurrent payersSet-local failure incorrectly escalated to invoice-global cancellationRegression test added for concurrent-set survival after reconstruction failure
d74ab6faby Gijs van Dam+141−42 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
LL Lightning LabsLND BitcoinLightning Network

bolt12: describe the lnwire dependency

This is a documentation-only change. A package comment was updated to accurately describe that the bolt12 codec library does depend on LND's lnwire package for low-level message types, while clarifying it still does not interact with the r…

5f53171dby bitromortac+3−21 file
No security note in commit
Moderate 60 AI analysisMessage 91 · Strong
LL Lightning LabsLND BitcoinLightning Network

bolt12: cover the amount overflow guard

This commit adds a test to ensure that when a BOLT 12 invoice is validated against a request, the multiplication of the offer amount by the requested quantity cannot overflow and wrap around to zero. Without this guard, a malicious or malf…

Integer overflow / wraparound in amount calculationMissing test coverage for security-critical branchBOLT 12 invoice amount validation
3c8e2bcbby bitromortac+47−01 file
Vendor flagged security relevance
Low 34 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11061 from bitromortac/2604-bolt12-1f

This commit adds the missing cryptographic signature layer for BOLT 12 offers in LND. It builds a Merkle tree from the message fields, signs that tree with a BIP-340 Schnorr signature, and now rejects invoice requests and invoices whose si…

Adds BIP-340 Schnorr signature verification for BOLT 12 invoice_request and invoice messagesMerkle tree commits to canonical re-encoded TLV records; non-minimal feature/amount encodings now rejected to preserve byte-exactnessSignature TLV type 240 and reserved range 240-1000 excluded from the signed Merkle root
1049d301by Yong+2076−7815 files
Vendor flagged security relevance
Low 35 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #11125 from bhandras/codex/reorg-aware-output-lock-20260825

This commit adds a new optional wallet feature to LND that lets users lock UTXOs until the transaction spending them reaches a chosen confirmation depth, instead of relying on a wall-clock timeout. It is a feature addition with safety chec…

New RPC fields release_after_spend_confs and confirmed_spend_height added to LeaseOutput and FundPsbtCustom lock ID enforced as required for confirmation-controlled FundPsbt leases; all-zero and reserved internal IDs rejectedCapability check (ResolveOutputLeaser) prevents silent downgrade to time-only lease when confirmation control is requested
80dde144by Yong+1293−10021 files
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #10812 from ziggie1984/chanstate-kv-store-move

This commit is a large internal code reorganization for the LND Lightning node. It moves channel state storage logic from the `channeldb` package into a new `chanstate` package, while keeping the same database keys, serialization formats, …

Large refactoring with no change to cryptographic or consensus-critical logicCodec serialization moved verbatim to new package; wire format unchangedDatabase bucket keys and TLV record types preserved
62b0a073by Olaoluwa Osuntokun+3923−310924 files
No security note in commit
Low 25 AI analysisMessage 73 · Adequate
LL Lightning LabsLND BitcoinLightning Network

Merge pull request #10804 from GeorgeTsagk/close-immediately-itest-lnd-7c38

This change fixes a data-handling bug in LND's channel-opening code. When opening a Lightning channel using an optional 'auxiliary funding controller' (used for custom channel types such as Taproot Assets), the funding manager was previous…

Data-correctness fix in funding handshake: negotiated channel configs now exposed to auxiliary funding controllerAuxiliary funding controller receives incomplete channel state before patch, complete state after patchNo explicit security claim, CVE, or advisory referenced in commit or supplied materials
1e127653by Olaoluwa Osuntokun+291−254 files
No security note in commit
Moderate 60 AI analysisMessage 88 · Strong
LL Lightning LabsLND BitcoinLightning Network

bolt12: verify invoice_request and invoice signatures on read

This change makes LND's BOLT 12 invoice and invoice-request reader actually check that the digital signature is valid, instead of only checking that a signature field exists. Before, an attacker could craft or modify a BOLT 12 message and …

Missing cryptographic verification on parsed BOLT 12 messages replaced with BIP-340 Schnorr signature verificationReader accepted any 64-byte placeholder signature before the patchNew negative tests verify rejection of wrong-signer and tampered Merkle-root fields
aa8bd19fby bitromortac+272−723 files
Vendor flagged security relevance
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedscripts: remove expired keyby ziggie · dccb669a · Aug 14, 2025 · 2 filesMessage 35 · OpaqueInformational 21Details
Commit message · ziggie

scripts: remove expired key

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 21/100

This commit removes an expired PGP public key belonging to a former release signer from the project's install verification script. It is a routine key hygiene change: keeping an expired key in the trusted key list could cause signature verification to fail or accept stale signatures, but the commit itself does not introduce any code vulnerability.

Lower-prioritysqldb: add missing index for settled invoicesby ziggie · 506d226e · Aug 14, 2025 · 2 filesMessage 45 · ThinInformational 19Details
Commit message · ziggie

sqldb: add missing index for settled invoices

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 19/100

This commit adds a database index on the 'settle_index' column of the 'invoices' table. An index is like a lookup table that makes certain database queries much faster. The commit title says it is a 'missing' index, suggesting it should have existed already. Without it, operations that look up settled invoices by their settle index could be slow, especially as the database grows. This is a performance fix, not a code change that directly prevents or enables an attack.

Lower-prioritysqldb: delete wrong index names and add missing oneby ziggie · 22fbbee8 · Aug 14, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ziggie

sqldb: delete wrong index names and add missing one

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit fixes a database migration rollback script. When undoing the invoices-related database schema, the script previously tried to drop indexes that either had wrong names or did not exist, and it forgot to drop one index that actually exists. This is a cleanup/maintenance fix for a 'down' migration; it does not change normal runtime behavior or fix an active security vulnerability.

Lower-prioritychanneldb: move helper function to codec.goby ziggie · 77a6b577 · Aug 14, 2025 · 2 filesMessage 80 · StrongInformational 15Details
Commit message · ziggie

channeldb: move helper function to codec.go

This method is not only used by the payment logic so we need to
move it to a generalized place because in the following commits
we move payment related code into its own package.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit simply moves two helper functions that convert time values to and from a binary format from one file to another within the same package. There is no change to what the code does, no bug fix, and no security-relevant behavior.

Lower-prioritychanneldb: export pagination methodby ziggie · 4bb21a72 · Aug 14, 2025 · 3 filesMessage 58 · ThinInformational 15Details
Commit message · ziggie

channeldb: export pagination method

We export some methods related to the pagination logic be the
kv store implemenation of the payment data will live in another
package.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit simply renames two internal helper functions so they can be used by other parts of the codebase. It does not change what the functions do, how they work, or any user-facing behavior. There is no security issue here.

Lower-prioritysqldb: use uint32 for config valuesby Elle Mouton · f560c4d9 · Aug 14, 2025 · 4 filesMessage 45 · ThinInformational 18Details
Commit message · Elle Mouton

sqldb: use uint32 for config values

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100

This commit changes internal database configuration values from signed integers (int/int32) to unsigned integers (uint32). It is a code-quality and type-safety cleanup, not a fix for an active security vulnerability. The change removes the theoretical possibility that a negative page or batch size could be supplied, which could cause loops or errors, but there is no evidence this was exploitable by an attacker.

AI review queuedgraph/db: remove outdated TODOby Elle Mouton · d5729845 · Aug 14, 2025 · 1 fileMessage 25 · OpaqueInformational 15Details
Commit message · Elle Mouton

graph/db: remove outdated TODO

25/100 · OpaqueMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply deletes a two-line TODO comment from a benchmark test file. A TODO is a developer note, not code. There is no functional change, no bug fix, and no security relevance in the diff itself.

Lower-prioritygraph/db+sqldb: batch validation for zombie index migrationby Elle Mouton · 5b064747 · Aug 14, 2025 · 5 filesMessage 73 · AdequateLow 25Details
Commit message · Elle Mouton

graph/db+sqldb: batch validation for zombie index migration

Finally, we update the migrateZombieIndex function to use batch
validation just like was done in the previous commits. Here, we
additionally make sure to validate the entire zombie index entry and not
just the SCID.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validation
AI analysis · Low 25/100

This commit improves a database migration that moves old 'zombie' Lightning channel records into a new SQL database. It switches from checking each record one-by-one to checking them in batches, and now also verifies the two node public keys associated with each channel, not just the channel ID. This is a correctness/reliability improvement for a one-time migration, not a fix for an active security vulnerability.

AI review queuedgraph/db: add migration timing logsby Elle Mouton · b1c643f4 · Aug 14, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Elle Mouton

graph/db: add migration timing logs

Time the full duration of each graph migration step for the purposes of
logging.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit only adds stopwatch-style timing to log messages that already existed. It records how long database migration steps take and prints the duration in the log. There are no changes to security logic, access controls, cryptography, or data handling.

Lower-prioritygraph/db+sqldb: use batch fetching during channel&policy migrationby Elle Mouton · 81c54611 · Aug 14, 2025 · 5 filesMessage 85 · StrongInformational 16Details
Commit message · Elle Mouton

graph/db+sqldb: use batch fetching during channel&policy migration

Restructue the `migrateChannelsAndPolicies` function so that it does the
validation of migrated channels and policies in batches. So instead of
fetching channel and its policies individually after migrating it, we
wait for a minimum batch size to be reached and then validate a batch of
them together. This lets us make way fewer DB round trips.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
defensive validation
AI analysis · Informational 16/100

This commit is a performance optimization for LND's database migration from the older key-value store to the new SQL store. It changes how channel and routing-policy records are verified after being copied: instead of reading back each channel one at a time, the code now collects a batch and reads them together. There is no security fix here and no indication it closes a vulnerability; it is purely about reducing database round trips during an upgrade.

Lower-prioritygraph/db+sqldb: use batch validation for closed SCID migrationby Elle Mouton · a490e034 · Aug 14, 2025 · 5 filesMessage 85 · StrongInformational 18Details
Commit message · Elle Mouton

graph/db+sqldb: use batch validation for closed SCID migration

As was done in the previous commits for nodes & channels, we update the
migrateClosedSCIDIndex function here so that it validates migrated
entries in batches rather than one-by-one.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
defensive validation
AI analysis · Informational 18/100

This commit is a performance optimization for a database migration in the Lightning Network Daemon (LND). It changes how the software verifies that closed channel identifiers were copied correctly from an older key-value database to a newer SQL database. Instead of checking each identifier one at a time, it now checks them in groups (batches). This should make the migration faster but does not change what data is stored or fix a security vulnerability.

Lower-prioritygraph/db+sqldb: use batch validation for node migrationby Elle Mouton · 03ef2740 · Aug 14, 2025 · 5 filesMessage 85 · StrongInformational 19Details
Commit message · Elle Mouton

graph/db+sqldb: use batch validation for node migration

Restructue the `migrateNodes` function so that it does the validation of
migrated nodes in batches. So instead of fetching each node individually
after migrating it, we wait for a minimum batch size to be reached and
then validate a batch of nodes together. This lets us make way fewer DB
round trips.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
defensive validation
AI analysis · Informational 19/100

This commit rewrites a database migration routine so it validates groups of records at once instead of one by one. The goal is to speed up the migration by reducing database round trips. There is no direct security fix here; it is a performance and reliability improvement to an internal data-migration path.

Lower-prioritygraph/db+sqldb: validate prune log migration using batchingby Elle Mouton · 8554f17b · Aug 14, 2025 · 5 filesMessage 85 · StrongInformational 19Details
Commit message · Elle Mouton

graph/db+sqldb: validate prune log migration using batching

As was done in the previous commits for nodes & channels, we update the
migratePruneLog function here so that it validates migrated entries in
batches rather than one-by-one.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
defensive validation
AI analysis · Informational 19/100

This commit changes how LND validates data copied from an older key-value database into a newer SQL database during a one-time migration. Instead of reading back each prune-log entry one at a time, it reads them back in batches. The goal is to make the migration faster, not to fix a security bug. The change still checks that every copied entry matches the original, and it still reports an error if anything does not match.

AI review queuedgraph/db: move sanity check out of insertChannelby Elle Mouton · 218aa9ea · Aug 14, 2025 · 1 fileMessage 80 · StrongInformational 16Details
Commit message · Elle Mouton

graph/db: move sanity check out of insertChannel

We do this so that this lookup is only done in the situation it is
actually needed. During a migration, we dont need to special case this
AlreadyExists error since we will terminate the transaction either way.
So there is no need for the extra lookup during the migration.

A timing analysis showed that this query was significantly impacting the
performance of the migration when run with a postgres backend.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 16/100

This change is a performance optimization for LND's database code. It moves a 'does this channel already exist?' check from inside a helper function to the caller, so the check is skipped during database migrations where it isn't needed. The commit message says this significantly speeds up migrations on PostgreSQL. There is no direct evidence this fixes a security vulnerability.

Lower-prioritysqldb+config: validate maximum batch size config valueby Elle Mouton · 185166b8 · Aug 13, 2025 · 4 filesMessage 83 · StrongLow 36Details
Commit message · Elle Mouton

sqldb+config: validate maximum batch size config value

Now that the SQL query config values are configurable, we add some
validation to make sure that the user doesnt set a max batch size that
is larger than the limits for sqlite/postgres that have been determined
by the TestSQLSliceQueries test.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validation
AI analysis · Low 36/100

This commit adds input validation to LND's database configuration settings. Previously, users could set SQL batch sizes larger than the database can actually handle, which could cause database queries to fail. The change enforces safe maximums for SQLite and Postgres, preventing misconfiguration rather than fixing an active vulnerability.

Lower-prioritymulti: remove DefaultQueryConfigby Elle Mouton · b1deddec · Aug 13, 2025 · 10 filesMessage 50 · ThinInformational 22Details
Commit message · Elle Mouton

multi: remove DefaultQueryConfig

And always make use of either the new DefaultSQLiteConfig or
DefaultPostgresConfig.

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
AI analysis · Informational 22/100

This commit removes a one-size-fits-all database query configuration and replaces it with separate SQLite and PostgreSQL defaults. It also threads the correct configuration through graph migration and lookup code instead of silently using a hard-coded default. The change is primarily a correctness and maintainability improvement; it does not appear to fix an active vulnerability, but it prevents potential bugs where the wrong database backend settings could be used during graph data migration or node lookups.

Lower-priorityconfig+sqldb: make native SQL query config options configurableby Elle Mouton · ee292786 · Aug 13, 2025 · 5 filesMessage 73 · AdequateInformational 15Details
Commit message · Elle Mouton

config+sqldb: make native SQL query config options configurable

Here, we make the sql query option params (batch size and pagination
size) configurable. The defaults for SQLite vs Postgres are still the
same but will be changed in an upcoming commit.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit simply exposes two internal database tuning knobs—batch size and pagination size—for SQLite and Postgres as user-configurable options. It does not change any security behavior, fix a bug, or alter access controls. It is a routine configuration enhancement.

Lower-prioritygraph/db+sqldb: find best default query cfg values for sqlite & postgresby Elle Mouton · 6a31e068 · Aug 13, 2025 · 5 filesMessage 83 · StrongInformational 18Details
Commit message · Elle Mouton

graph/db+sqldb: find best default query cfg values for sqlite & postgres

This commit adds a BenchmarkFindOptimalSQLQueryConfig test in the
graph/db package which runs ForEachNode and ForEachChannel queries
against a local backend using various different values for the sql
QueryConfig struct. This is done to determine good default values to
use for the config options for sqlite vs postgres.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 18/100

This commit is a performance tuning change, not a security fix. It adds a benchmark to find the best default query batch/page sizes for SQLite versus Postgres in LND's graph database code, then splits the previous single default config into separate SQLite and Postgres defaults. There is no indication it fixes a vulnerability or changes any security behavior.

Lower-prioritygraph/db: fix progress logsby Elle Mouton · 1082eaae · Aug 13, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Elle Mouton

graph/db: fix progress logs

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit fixes progress logging counters in database migration code. Three migration functions were incrementing a 'count' variable but not a separate 'chunk' variable, which is likely used to decide when to print progress updates. The fix adds the missing 'chunk++' increments so progress logs are emitted at the intended intervals. There is no security relevance visible in the code change.

AI review queuedgraph: remove outdated TODOby Elle Mouton · 75691163 · Aug 13, 2025 · 1 fileMessage 15 · OpaqueInformational 15Details
Commit message · Elle Mouton

graph: remove outdated TODO

This todo has been addressed.

15/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply removes a three-line comment (a TODO note) from a Go source file. No code behavior changed, no bug was fixed, and no security issue is present in the diff.

AI review queuedchanneldb: rename currPaymentSeqby ziggie · a4b15696 · Aug 11, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · ziggie

channeldb: rename currPaymentSeq

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a simple internal rename of a variable from currPaymentSeq to currSeq. It does not change any behavior, logic, or security properties of the code. There is no security issue present.

AI review queuedchanneldb: rename storedPaymentSeqby ziggie · 4e0af2f4 · Aug 11, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · ziggie

channeldb: rename storedPaymentSeq

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a simple internal variable rename from 'storedPaymentSeq' to 'storedSeq' in the payments database code. It does not change any logic, behavior, or security properties of the software.

AI review queuedchanneldb: rename paymentSeqMxby ziggie · 6bae3c98 · Aug 11, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · ziggie

channeldb: rename paymentSeqMx

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply renames an internal mutex variable from paymentSeqMx to seqMu. It is a non-functional code cleanup with no behavior change and no security relevance.

Lower-prioritymulit: use kvdb.Backend for the kv payment dbby ziggie · 88da5825 · Aug 11, 2025 · 8 filesMessage 60 · AdequateInformational 19Details
Commit message · ziggie

mulit: use kvdb.Backend for the kv payment db

Instead of the ChannelState struct we now use the kv backend
interface for the payment kv database.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 19/100

This commit is a code cleanup and refactoring change in LND's payment database. It moves the 'keep failed payment attempts' setting from the main channel database struct into the dedicated payments key-value store, and makes the payments store accept any compatible key-value backend rather than only the full ChannelState database. There is no direct security vulnerability visible in the diff; it is primarily an architectural change to prepare for future database backends.

Lower-prioritypaymentsdb: add subsystem logging for payments packageby ziggie · 3aec4029 · Aug 11, 2025 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · ziggie

paymentsdb: add subsystem logging for payments package

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a new logging subsystem for the payments database package in LND. It only introduces logging infrastructure (a logger variable, subsystem name, and registration with the main logger setup) and does not change any payment-handling logic, database queries, or security behavior. There is no security issue visible in this change.