AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

Merge pull request #11125 from bhandras/codex/reorg-aware-output-lock-20260825

Public commit record

What the developer wrote

Authored by Yong

73/100 · Adequate
Merge pull request #11125 from bhandras/codex/reorg-aware-output-lock-20260825

walletrpc: retain input leases through spend confirmation
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds a new optional wallet feature to LND that lets users lock UTXOs until the transaction spending them reaches a chosen confirmation depth, instead of relying on a wall-clock timeout. It is a feature addition with safety checks (required custom lock ID, capability checks, rollback on partial failure) and is not a fix for a known exploit. The main risk is that a bug in the new reorg-aware lease logic could keep coins locked longer than intended or, in a worst case, allow double-spending of locked UTXOs, but the diff itself does not show such a vulnerability.

Recommended action

Treat as a normal feature review. Verify the bumped btcwallet/wtxmgr pre-release commits do not introduce unrelated changes. Monitor for any follow-up fixes regarding reorg handling or lease release edge cases. No immediate security patch is indicated by this commit alone.

Security signals we found

01

New RPC fields release_after_spend_confs and confirmed_spend_height added to LeaseOutput and FundPsbt

02

Custom lock ID enforced as required for confirmation-controlled FundPsbt leases; all-zero and reserved internal IDs rejected

03

Capability check (ResolveOutputLeaser) prevents silent downgrade to time-only lease when confirmation control is requested

04

Partial-failure rollback path added in lockInputs with error attribution by outpoint and lock ID

05

btcwallet/wtxmgr dependency bumped to pre-release versions supporting reorg-aware lease expiry

06

Integration test exercises wall-clock expiry gap, shallow reorg, node restart, and spend-depth release

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.