Commit message · merge-scriptMerge bitcoin-core/secp256k1#1961: ci: run exhaustive_tests for group orders 7 and 199
a3fcbeafe3cb1414ea337d506381836595d88a87 ci: run exhaustive_tests for group orders 7 and 199 (Ferdinando Ametrano)
32099110d63a1dec1a7d27067450fd97d20ea30f tests: don't define the ellswift exhaustive test for even-order curves (Ferdinando Ametrano)
Pull request description:
CI builds `exhaustive_tests` only for its default group order, 13. The other two orders in `src/group_impl.h`, 7 and 199, are never compiled. Order 7 is the even-order curve, where the ellswift tests are skipped.
`ci/ci.sh` now rebuilds `exhaustive_tests` for `EXHAUSTIVE_TEST_ORDER` and runs it with `EXHAUSTIVE_TEST_ARGS`. A new job, `exhaustive_debian`, has two rows: order 7, and order 199.
A full run at order 199 would take about 7 weeks on my machine: one part in 100000 takes 51 s, of which about 10 s is fixed cost. So the order 199 row runs one part in 20000, using the existing `numcores` and `thiscore` arguments. These come after the seed argument, so the seed is fixed. Every run still builds the order 199 tables and checks the whole group against `ecmult_gen`.
The first commit removes an unused-function warning that order 7 would otherwise add to the CI log.
I ran `ci/ci.sh` as the new rows do, with clang on an Apple M5 (macOS, no Docker): order 7 takes 15 s and order 199 takes 230 s, both including the build. I did not run the job on GitHub Actions or on Linux.
*Assisted-by: my usual tools (LLM, Internet, computer). Mistakes are mine.*
ACKs for top commit:
real-or-random:
ACK a3fcbeafe3cb1414ea337d506381836595d88a87
theStack:
ACK a3fcbeafe3cb1414ea337d506381836595d88a87
Tree-SHA512: 9a090f50f116311ba90f8abad8efb301972badab0b4faddf99a9591d1b17a5ecf19ef80d6641b521f46a2ec2c7a8c5672869f4232b27dc9723d3230b06ad958e
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queuedmerge-commit duplicate discount