btcd

This commit adds a new internal bookkeeping structure called bestHeader to btcd's blockchain tracking. It mirrors the existing bestChain view but is intended to track headers separately from full blocks. There is no visible security fix or vulnerability being patched; it appears to be preparatory refactoring for a later change in how new blocks are announced.

This commit simply adds a new bookkeeping flag and a helper method to track whether a block header has been stored on disk. It does not change any security-sensitive behavior, fix a bug, or alter how data is validated. There is no indication this is a security patch.

This commit adds a new internal function to btcd that accepts block headers into a separate 'header chain' before downloading full blocks. It is a feature/refactoring change for a 'headers-first' download mode. There is no indication in the commit that it fixes a security bug or introduces a vulnerability; it appears to be normal protocol implementation work.

This commit only adds a new error code constant and its string mapping in the blockchain package. It does not change any validation logic, network behavior, or how blocks are accepted or rejected. By itself, it cannot introduce or fix a security issue.

This commit fixes two internal timing bugs in how btcd manages peer connections during the Bitcoin handshake. It prevents a peer-registration step from being accidentally skipped when handshake messages arrive at the same time as a disconnect, and it stops the server from crashing if a peer somehow sends its final handshake acknowledgment twice. These are robustness fixes rather than obvious remote-attack paths, but they remove conditions that could destabilize a node.

This commit is a follow-up fix for a race condition in how btcd adds and removes peers. The previous fix tried to ensure that when a peer connects and quickly disconnects, the 'peer added' and 'peer done' notifications are always seen in the right order by the sync manager. This commit makes that guarantee stronger by having a single goroutine handle both events, instead of two separate code paths. It also adds tests that demonstrate the bug could corrupt sync manager state and prevent the node from syncing.

This commit fixes a race condition in btcd, a Bitcoin node implementation. When a peer connected and disconnected very quickly, the node could tell its block-syncing component that the peer left before it ever told it the peer arrived. That left the syncer believing a dead peer was still its active sync partner, so the node could stop syncing new blocks from real peers. The fix funnels all peer add/remove events through one ordered channel so the syncer always sees arrival before departure. A new integration test demonstrates the bug by bombarding a node with handshake-then-disconnect connections and then checking whether it still syncs blocks.

This commit only fixes documentation comments in the code. It corrects a description about which nonce-generation method is used when a custom nonce option is provided. No actual signing logic or behavior was changed, so there is no security risk from this patch itself.

This commit simply updates the version of the Go programming language used to build release binaries inside a Docker container, from Go 1.22.11 to Go 1.23. There is no code change, no bug fix, and no security patch visible in the diff. It is a routine build-maintenance change.

This commit fixes a typo in a log message only: 'alloacting' is corrected to 'allocating'. There is no functional code change, no security fix, and no behavior change.

This commit changes btcd's regression test network (regtest) rules so they match Bitcoin Core's behavior. It makes several Bitcoin protocol upgrades active from block 1 instead of being delayed or inactive. The change is primarily about test-network compatibility and does not appear to be a security fix for main Bitcoin production networks. It adds tests to confirm regtest now rejects old-style blocks and accepts modern ones, just like Core does.

This commit is a pure code cleanup and test-addition change. It moves an existing decision about when to run an expensive Bitcoin rule check into a new helper function, without changing when the check runs. It also adds unit tests for that helper. There is no security fix or behavior change.

This update fixes a rule in btcd (a Bitcoin implementation) that was skipping an expensive duplicate-check too early. The change re-enables that duplicate check once the blockchain reaches height 1,983,702, matching a safeguard already added to Bitcoin Core. Without the fix, a carefully crafted block could potentially reuse an old coinbase transaction ID after BIP34 is active, which could cause nodes to disagree on the state of coins. The patch includes a regression test.

This commit fixes a subtle consensus bug in btcd, a Bitcoin implementation. BIP30 prevents two blocks from having the same special 'coinbase' transaction ID, and BIP34 makes duplicate coinbase IDs practically impossible once it activates. btcd was skipping the BIP30 check based only on block height, but on an alternate chain that has not actually activated BIP34 at that height, a duplicate coinbase could slip through. The fix mirrors Bitcoin Core by also checking that the known BIP34 activation block hash is present on the current chain before disabling BIP30.

This commit fixes a subtle off-by-one bug in btcd's blockchain validation. BIP30 is a rule that prevents duplicate coinbase transactions, which could otherwise allow an attacker to overwrite existing Bitcoin funds. BIP34 later made duplicate coinbases impossible by requiring unique block heights in coinbase data. btcd was skipping the BIP30 duplicate check starting exactly at the BIP34 activation block, but Bitcoin Core still runs the BIP30 check for that one activation block. The change aligns btcd with Core by moving the skip point one block later, so the duplicate-coinbase check is still enforced at the BIP34 activation height.

This commit is a performance optimization, not a security fix. It changes the database cache's treap (a type of search tree) so that it can insert many key-value pairs in one batch instead of one at a time. The goal is to reduce memory allocation and garbage collection overhead when flushing the UTXO cache. There is no indication in the commit message or diff that this fixes a security vulnerability.

This commit adds a small helper method that clears a data structure node and returns it to an internal memory pool for reuse. It is a routine performance/memory-management change with no visible security implications.

This commit is a performance optimization for an internal data structure (a treap, a type of tree used in btcd's database). It changes the private put() function to return pointers to newly created nodes so that future callers can recycle them through a sync.Pool, reducing memory allocations. The public Put() method ignores these returned nodes, so behavior is unchanged. There is no security fix or vulnerability patch here.

This commit fixes a bug in btcd's RPC client where network connection attempts ignored the configured timeout and could hang for a very long time (relying on the operating system's default limits). The fix makes the dial operation respect the context and timeout that the HTTP client already carries. It is a reliability and availability improvement rather than a direct theft-of-funds bug, but long-hanging connections can be abused to exhaust client resources or stall dependent services.

This commit simply changes a version label from 'beta.rc1' to 'beta' in a single source file. It is a routine release-version bump with no security relevance.

This commit adds a new public getter method called CombinedNonce to the MuSig2 signing session in btcd. It simply lets callers read the already-computed combined public nonce, returning an error if it isn't ready yet. There is no change to cryptographic logic, no bug fix, and no security-relevant behavior.

This commit adds a new public method called RegisterCombinedNonce to the MuSig2 multi-signature code in btcd. It lets a signing session accept an already-aggregated public nonce from an external coordinator, instead of requiring each signer to collect every individual nonce itself. The change is a feature addition with explicit safety checks: it rejects registering a combined nonce twice, rejects mixing combined-nonce and individual-nonce registration on the same session, validates the nonce parses as two valid public keys, and preserves the existing one-sign-per-session nonce-reuse guard. Nothing in the commit message or diff suggests a security bug is being fixed; it appears to be a normal API enhancement for coordinator-based signing workflows.

This commit only changes the software version number from v0.24.2-beta to v0.25.0-beta.rc1. It does not modify any program logic, fix bugs, or change security behavior. There is no security relevance in this change.

This commit is a routine performance optimization for an internal data structure used in the btcd Bitcoin node. It introduces a memory pool (sync.Pool) to reuse small treapNode objects instead of repeatedly allocating new ones from the garbage collector. There is no security-relevant change here; it only reduces memory pressure and allocation overhead during database operations.

This commit is a simple internal code cleanup. It splits the existing Put() function into a public wrapper and a private helper, with no change to behavior. There is no security issue here.