BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

557 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

120security candidates80second-pass queue462AI analyses
0commits · 30 days
47commits · 60 days
209commits · 180 days
423commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
37Strong · 80–100
204Adequate · 60–79
275Thin · 40–59
41Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths32663289157
Mike Tolkachev541744153
Daniel Newton902078055
Mihailo Milenkovic878057
roderico633074
Valerio Vaccaro2226056
Jamie C. Driver525053
Gustavo Cateim917078
Austin-Fulbright414060
kkdao211068
quantpoet111072
cmiguelrn111045
Analysis record

Published AI watches

Last scanned 1 minute ago

Moderate 57 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: whitelist reply message function calls

This commit adds a whitelist of approved functions that can be used when sending reply messages from the Jade hardware wallet to a connected computer or phone. Previously, any function could be passed in, which could allow a bug or malicio…

Function-pointer whitelist added to reply pathMultiple static reply helpers made global to enable whitelist comparisonAssertion tightened to validate callback before use
a59d14c2by Jon Griffiths+53−1513 files
No security note in commit
Low 42 AI analysisMessage 30 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

temporary_stack: whitelist temporary task function calls

This commit adds a whitelist to a special helper that lets certain functions run with extra memory stack space. Previously, any function could be passed to this helper. Now only a small list of approved functions is allowed, except during …

Addition of function-pointer whitelistRemoval of static linkage on internal functions to enable whitelist comparisonConditional bypass of whitelist only for debug/selfcheck builds
6a0fea51by Jon Griffiths+26−54 files
No security note in commit
Informational 15 AI analysisMessage 43 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

consistency: fix typos

This commit is a large typo-fixing cleanup across 40 files. Almost every change corrects spelling mistakes in code comments, variable names, or user-facing text strings. There is no change to program logic, security behavior, or cryptograp…

251f7713by Jon Griffiths+96−9640 files
No security note in commit
Informational 15 AI analysisMessage 47 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: document get_bip85_bip39_entropy

This commit only updates documentation and removes a single comment line. It documents an existing feature that lets a user request encrypted BIP85-based BIP39 entropy from the Jade hardware wallet after on-device confirmation. There is no…

05a578adby Jon Griffiths+52−12 files
No security note in commit
Low 28 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

bip85: expose get_bip85_bip39_entropy over rpc in addition to qr

This commit moves a feature that derives BIP85 BIP39 entropy from being available only in debug builds to being available over the normal RPC interface. BIP85 lets a hardware wallet derive child seed phrases from a master seed. Making this…

Feature moved from debug-only to production RPC surfaceNo accompanying access-control or input-sanitization changes visible in diffBIP85 entropy derivation is a sensitive cryptographic operation
c6c5e860by Jon Griffiths+3−41 file
No security note in commit
Informational 19 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

versioninfo: add JADE_INTERFACE field to show which connection source holds the unlocked wallet

This commit adds a new read-only field, JADE_INTERFACE, to the device's version information reply. It simply tells a connected computer which communication path (USB, Bluetooth, QR mode, etc.) currently has control of the unlocked wallet. …

No authentication or authorization logic changedNo cryptographic or key-management code changedNo input parsing or memory-unsafe code added
2fe9df0bby Daniel Newton+66−56 files
No security note in commit
Low 44 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx/sign_psbt: extra check for BTC inputs

This commit adds overflow protection when adding up the total value of Bitcoin transaction inputs in Blockstream Jade's signing code. Previously, the firmware used a plain addition that could silently wrap around if a specially crafted tra…

Integer overflow hardening in financial-amount accumulationDefensive checked_add_uint64() introduced where plain addition existedTransaction signing path now rejects overflowed input totals
41d7e8b4by Daniel Newton+15−32 files
No security note in commit
Informational 19 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: move NVS cache objects that can pin the DRAM heap to SPIRAM if available

This commit changes how the Jade hardware wallet's firmware uses memory. It moves some internal storage cache objects from the main RAM (DRAM) to external RAM (PSRAM/SPIRAM) when available. This is a memory-optimization change, not a direc…

Memory layout change: moves NVS cache from DRAM to SPIRAMNo direct security fix or vulnerability patch present in diffNo mention of CVE, security researcher, or security advisory in commit
329f73c5by Daniel Newton+7−17 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: migrate pin action tests from test_jade to rpc tests

This commit simply moves existing test cases from one test file to another. It does not change any production code, security behavior, or fix any vulnerability. The tests check that the Jade device correctly rejects invalid parameters for …

be0e6b3dby Mike Tolkachev+42−402 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: add tests for pin actions via debug_set_pin

This commit only adds a new test file that exercises PIN-related features of the Jade hardware wallet using a debug-only RPC command. It does not change any production code, introduce new functionality, or alter security behavior. The test…

dd3d5b22by Mike Tolkachev+334−01 file
No security note in commit
Moderate 62 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: require user to permit get_identity_shared_key RPC

This commit adds a user confirmation step before a hardware wallet will share an identity-derived shared secret. Previously, the get_identity_shared_key RPC could compute and return the shared key without the user pressing approve on the d…

RPC that derives/releases a cryptographic shared secret now requires explicit on-device user approvalInput validation added: identity string must be printable before being shown in a security promptNew dedicated accept/reject button event IDs separate this flow from sign_identity
7ca0d26cby Daniel Newton+70−116 files
No security note in commit
Informational 20 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

auth: add unattended pin selection for rpc tests

This commit adds a debug-only feature that lets automated tests set or change the device's PIN over an internal RPC message. It only compiles when special debug flags are enabled and is not present in normal production firmware. The change…

New RPC endpoint debug_set_pin can set/change the unlock PINPIN-handling code path modified to read from a mutable debug context instead of a fixed constantCode is wrapped in CONFIG_DEBUG_UNATTENDED_CI and CONFIG_DEBUG_MODE preprocessor guards
309ee8bbby Mike Tolkachev+100−205 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

pin: disallow pin update on initialized units in debug mode

This commit removes a special debug-only exception that previously allowed the PIN server's public key to be changed on a Jade hardware wallet that already had a wallet set up. In normal operation, changing this public key on an initialize…

Removal of debug-mode bypass for a security-critical authorization checkProtection against pinserver public key substitution on initialized devicesDefense-in-depth for wallet PIN/server trust binding
a5667efdby Jon Griffiths+1−31 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: fix mnemonic handling following seed changes

This commit only changes test code for the Blockstream Jade hardware wallet. It fixes how tests set and reset the device mnemonic/seed so tests run correctly after earlier seed-handling changes. There is no change to the actual wallet firm…

85e87d4eby Jon Griffiths+32−377 files
No security note in commit
Low 32 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

malloc_ext: fix JADE_CALLOC_DRAM

This commit fixes a macro definition for a memory-allocation helper. The macro was accidentally written to take only one argument ('size') even though the underlying function it calls needs two arguments ('number of items' and 'size of eac…

Memory-allocation wrapper macro arity mismatch fixedPotential for undefined behavior if mismatched macro were usedNo explicit security claim or CVE referenced in commit
828835ccby Daniel Newton+1−11 file
No security note in commit
Low 43 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: fix reply count for exact chunk sizes

This commit fixes a bug in how Blockstream Jade counts the number of message chunks needed to send back a signed Bitcoin transaction (PSBT). When the transaction size was an exact multiple of the chunk size, the device told the host there …

Integer division off-by-one in chunk/message countDevice abort on assertion when host requests non-existent chunkDenial-of-service-like symptom: valid signing flow can crash the device
4f1a1565by kkdao+38−22 files
No security note in commit
Low 37 AI analysisMessage 73 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: allow tapping directly on touchscreen elements

This commit adds a new touchscreen mode for some Jade hardware wallets where users can tap on-screen buttons directly instead of only using the three virtual buttons below the screen. To reduce the risk of accidental or malicious confirmat…

New direct-touch input path added to GUI event handlingCritical-action buttons require long-press to mitigate stray or coerced tap confirmationsDestructive operations (reset, delete wallet, delete OTP) converted to critical yes/no prompts
a46aa30aby Bota+206−1111 files
Vendor flagged security relevance
Informational 13 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

urldecode: use plain strlen in self-tests of libjade

This commit only changes the internal test file for a URL-decoding helper. It swaps a custom string-length macro for the standard C strlen() function inside test data. The actual product code that users rely on is not changed, and there is…

b39a7a20by Mike Tolkachev+27−291 file
No security note in commit
Moderate 50 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: support tickers up to 24 characters

This commit updates the Blockstream Jade hardware wallet to support longer asset tickers (up to 24 characters) and adds validation to reject malformed tickers. It also fixes a potential display bug where a ticker longer than 8 characters c…

Buffer size increased from 8 to 25 bytes to match new ticker maximumNew input validation added for asset ticker length and character setsnprintf precision argument cast from size_t to int to avoid undefined behavior on some platforms
cc5859a6by Mike Tolkachev+36−53 files
No security note in commit
Low 29 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

assets: improve empty ticker support

This commit hardens how the Blockstream Jade hardware wallet handles assets that have no ticker symbol. Previously, if an asset's ticker was missing (NULL), the code could pass a NULL pointer to string-length functions, which can cause cra…

NULL-pointer dereference risk in asset ticker handlingDefensive null-check added before strlen()New test fixture for NULL ticker asset path
9d0d74d0by Mike Tolkachev+30−23 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidatepsbt: remove branching for getting public/private key function callby Mihailo Milenkovic · 3be9c485 · Feb 2, 2026 · 1 fileMessage 55 · ThinInformational 12Details
Commit message · Mihailo Milenkovic

psbt: remove branching for getting public/private key function call

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
secret or key materialsigning boundarysigning or wallet path
AI analysis · Informational 12/100

This commit is a small internal code cleanup in a Bitcoin hardware wallet library. It replaces an if/else branch that chose between two similar key-lookup functions with a single function pointer. There is no change to what data is read, what keys are used, or what is returned to the caller. It is a stylistic refactor, not a security fix.

Security candidatepsbt: allow signing green 2of3 txs with Jade as the recovery signerby Mihailo Milenkovic · 6cf2694a · Feb 2, 2026 · 2 filesMessage 50 · ThinLow 32Details
Commit message · Mihailo Milenkovic

psbt: allow signing green 2of3 txs with Jade as the recovery signer

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 32/100

This commit changes how Blockstream Jade hardware wallets sign Bitcoin transactions in a specific multi-signature setup called Green 2of3. It lets Jade act as the 'recovery signer' by deriving a special recovery key from the user's key when the first key in the transaction looks like a Blockstream Green server key. The change is a feature addition to support a previously unsupported signing scenario, not a fix for a known exploit. There is no evidence in the commit or supplied references that this is a security patch or that it addresses a disclosed vulnerability.

Security candidatepin: erase the pin privatekey when changing/erasing pin settingsby Jon Griffiths · ee6ea9a5 · Feb 2, 2026 · 2 filesMessage 70 · AdequateLow 42Details
Commit message · Jon Griffiths

pin: erase the pin privatekey when changing/erasing pin settings

Ensures we use a new private key whenever the pinserver is changed,
created on demand at first-use.

70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialaccess control
AI analysis · Low 42/100

This commit changes how Blockstream Jade handles a private key used for PIN server authentication. Previously, the device kept the same private key even when the user changed or removed their PIN server settings. Now it deletes that key whenever the PIN server settings change, so a fresh key is generated the next time it is needed. This reduces the risk that an old or compromised key could be reused across different PIN server configurations.

Security candidatesign_psbt: update is_green_multisig_signers to handle green 2of3 recovery signingby Mihailo Milenkovic · 39f02f88 · Feb 2, 2026 · 1 fileMessage 50 · ThinLow 42Details
Commit message · Mihailo Milenkovic

sign_psbt: update is_green_multisig_signers to handle green 2of3 recovery signing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 42/100

This commit updates the code that signs Bitcoin transactions for Blockstream Jade's Green multisig wallets. It specifically adds support for '2-of-3 recovery signing,' where the Jade device acts as the recovery key rather than the regular user key. The change lets Jade recognize and sign recovery transactions it previously would have rejected. There is no clear security bug being fixed; it appears to be a feature addition to support a missing signing scenario.

Security candidatedocs: update FWUPDATE.mdby tokyovyse · bf3ce57e · Jan 21, 2026 · 1 fileMessage 63 · AdequateInformational 15Details
Commit message · tokyovyse

docs: update FWUPDATE.md

Added section on manually fetching and verifying the hash, including where to find the published hashes for Jade and Jade Plus firmware and the differences between the cmphash and fwhash. Also corrected the original typo (from "is desired" to "if desired").

63/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
boot or update pathdocumentation-only discount
AI analysis · Informational 15/100

This commit only updates the user documentation file FWUPDATE.md. It adds instructions for manually fetching firmware hashes, fixes grammar and style issues, and clarifies where to find published firmware metadata. No code, firmware, cryptographic, or security logic was changed.

Security candidateconfig: add generic Jade/v1/v2 config itemsby Jon Griffiths · 6ecd20d6 · Dec 17, 2025 · 9 filesMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

config: add generic Jade/v1/v2 config items

Simplify ifdef'd code using the more general defines.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
boot or update path
AI analysis · Informational 15/100

This commit is a straightforward internal cleanup of how the firmware identifies different Jade hardware versions. It introduces broader 'any Jade v1/v2' configuration flags and replaces many scattered checks with simpler ones. There is no user-facing change, no bug fix, and no security alteration visible in the code.

Security candidateFix TTGO PIN entry navigationby cmiguelrn · c5ad31dc · Dec 15, 2025 · 1 fileMessage 45 · ThinInformational 20Details
Commit message · cmiguelrn

Fix TTGO PIN entry navigation

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access controlauthentication path
AI analysis · Informational 20/100

This commit fixes the direction of PIN-entry wheel navigation on TTGO hardware variants of the Blockstream Jade hardware wallet so it matches the rest of the device's user interface. It is a device-specific usability fix, not a cryptographic or network security fix. There is no indication it allows an attacker to steal funds, bypass the PIN, or access private keys.

Security candidatepsbt: fix a (harmless) off-by-one assert checkby Jon Griffiths · 42f6948c · Dec 3, 2025 · 1 fileMessage 45 · ThinInformational 18Details
Commit message · Jon Griffiths

psbt: fix a (harmless) off-by-one assert check

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100

This commit fixes a boundary check in code that walks through parts of a Bitcoin transaction (PSBT). The old check allowed an index equal to the number of items, which is one too high. The commit message calls it 'harmless,' meaning it should not cause a real security problem in practice. It is a defensive correction to an assert that guards internal iteration.

Security candidateotp: clearer message when device does not have current time for TOTP functionby Daniel Newton · e9f544ff · Dec 3, 2025 · 4 filesMessage 50 · ThinInformational 20Details
Commit message · Daniel Newton

otp: clearer message when device does not have current time for TOTP function

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Informational 20/100

This commit improves the on-screen error messages shown when a Blockstream Jade hardware wallet cannot generate a TOTP (time-based one-time password) code because the device does not know the current time. It does not change the security rules or fix a vulnerability; it only makes the failure message clearer to the user, suggesting they unlock the device with the Blockstream app to set the time.

Security candidatelibjade: enable building the Jade firmware as a native libraryby Jon Griffiths · 30aef5c7 · Dec 3, 2025 · 63 filesMessage 83 · StrongInformational 15Details
Commit message · Jon Griffiths

libjade: enable building the Jade firmware as a native library

Implements an in-process instance of the Jade firmware. This can be
thought of as an emulated or virtual Jade device that runs in the address
space of the application that links to it.

Also expose a daemon process which allows using libjade from another
process using the existing jadepy API.

This initial implementation is highly experimental and incomplete, and
should under no circumstances be used beyond development and testing.

Co-authored-by: Lawrence Nahum <lawrence@greenaddress.it>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
cryptography-sensitive pathauthentication path
AI analysis · Informational 15/100

This commit adds a new experimental developer/testing feature called libjade that lets the Jade hardware-wallet firmware be compiled and run as a normal Linux software library or daemon. It is explicitly marked as incomplete, not for real funds, and for development/testing only. There is no indication this is a security fix or that it addresses any vulnerability.

Security candidatebuild: further verify signature digests in signed v2 binariesby Jon Griffiths · 690c8b1c · Oct 14, 2025 · 1 fileMessage 77 · AdequateLow 42Details
Commit message · Jon Griffiths

build: further verify signature digests in signed v2 binaries

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Low 42/100

This change tightens a build-time signing script for Blockstream Jade hardware wallet firmware. It adds checks that the public-key digests recorded inside a signed binary match the digests of the keys that were actually used to sign it, and makes the script stop on any error. The patch is defensive: it reduces the chance that a corrupted or wrongly-signed firmware image is produced during release, but it does not by itself fix a vulnerability in already-shipped devices.

Security candidatebuild: minor error handling tweak for v2 pem signingby Jon Griffiths · 1d797de3 · Oct 12, 2025 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Jon Griffiths

build: minor error handling tweak for v2 pem signing

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This is a tiny build-script change that replaces a silent failure with a clear error message when required signing key files are missing. It does not change what the script does, only what it prints when it fails. There is no security vulnerability here.

Security candidateotp: avoid signed left shiftby Jon Griffiths · 7c8fd718 · Oct 8, 2025 · 1 fileMessage 45 · ThinLow 32Details
Commit message · Jon Griffiths

otp: avoid signed left shift

Found by ubsan.

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 32/100

This commit fixes a subtle programming bug in the code that decodes base32 one-time-password (OTP) secrets. The bug involves shifting a signed integer left, which is undefined behavior in C and was caught by an undefined-behavior sanitizer. The fix changes the variable from a signed integer to an unsigned integer so the shift is well-defined. The practical security impact is likely low, but undefined behavior in cryptographic/OTP handling is generally undesirable because compilers may optimize it unpredictably.

Security candidateUpdate python/pinserver libwally to 1.5.1by Jon Griffiths · 5e5df8c9 · Sep 29, 2025 · 2 filesMessage 45 · ThinLow 25Details
Commit message · Jon Griffiths

Update python/pinserver libwally to 1.5.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 25/100

This commit simply updates a dependency called 'wallycore' used by the Blockstream Jade PIN server from version 1.4.0 to 1.5.1. It changes the version number and the list of cryptographic fingerprints (hashes) that verify the downloaded package. The commit message does not say why the update was made or whether it fixes any security issue. Without knowing what changed between 1.4.0 and 1.5.1, we cannot tell if this is a routine maintenance update or a security fix.

Security candidatepsbt: allow pset signing from usb/qrcodesby Jon Griffiths · 4fc854e9 · Sep 29, 2025 · 3 filesMessage 45 · ThinLow 30Details
Commit message · Jon Griffiths

psbt: allow pset signing from usb/qrcodes

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 30/100

This commit lets a Blockstream Jade hardware wallet automatically detect whether a transaction file is for Bitcoin or the Liquid sidechain (including test networks) when signing via QR codes or USB. Before, the wallet always assumed Bitcoin, which could cause it to fail or behave incorrectly when signing a Liquid transaction through those offline methods. The change itself is a feature fix and does not appear to introduce a security vulnerability.

Security candidatebuild: fail if any step of signing v2 firmwares failsby Jon Griffiths · edc17778 · Sep 29, 2025 · 1 fileMessage 62 · AdequateLow 34Details
Commit message · Jon Griffiths

build: fail if any step of signing v2 firmwares fails

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 34/100

This commit hardens the firmware signing script used when releasing Blockstream Jade hardware wallet firmware. It adds `set -e` so the script stops immediately if any command fails, and explicitly checks that the public and private key files exist before proceeding. Without these changes, the script could silently continue past errors (for example, if a key file was missing or a signing command failed), potentially producing or releasing firmware that was not properly signed. Proper signing is important because users rely on firmware signatures to verify that the software running on their device is authentic and has not been tampered with.

Security candidatebuild: add a script for testing v1 firmware signingby Jon Griffiths · 76a30841 · Sep 29, 2025 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Jon Griffiths

build: add a script for testing v1 firmware signing

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit adds a new build helper script that signs production firmware files with a private key during release testing. It does not change any device code, cryptographic checks, or user-facing behavior. It is purely a release-engineering convenience script.

Security candidatechore: fix some minor issues in the commentsby quantpoet · f96353b1 · Sep 28, 2025 · 6 filesMessage 72 · AdequateInformational 15Details
Commit message · quantpoet

chore: fix some minor issues in the comments

Signed-off-by: quantpoet <quantway@outlook.com>

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
Why it was queued
signing or wallet pathauthentication path
AI analysis · Informational 15/100

This commit only fixes spelling mistakes inside code comments (for example, changing 'sufficent' to 'sufficient' and 'Explcitly' to 'Explicitly'). No actual program instructions were changed, so it cannot affect security or functionality.

Security candidategui: share code to wait for buttons with ci auto-click (2)by Jon Griffiths · 05359dbf · Sep 16, 2025 · 14 filesMessage 65 · AdequateInformational 13Details
Commit message · Jon Griffiths

gui: share code to wait for buttons with ci auto-click (2)

Remove redundant checks for timeout. Note there are no functional
changes, just a fair amount of code churn.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathboot or update pathauthentication path
AI analysis · Informational 13/100

This commit is a code cleanup in the user-interface layer of the Blockstream Jade hardware wallet. It removes repeated 'if timeout' checks around button-waiting loops and lets the shared helper handle the timeout case instead. The commit message explicitly says there are no functional changes, and the diff shows only structural simplification—no security-sensitive logic was altered.

Security candidategui: share code to wait for buttons with ci auto-clickby Jon Griffiths · 2947dcaf · Sep 16, 2025 · 18 filesMessage 50 · ThinInformational 18Details
Commit message · Jon Griffiths

gui: share code to wait for buttons with ci auto-click

Minimal change for easier review.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathboot or update pathauthentication path
AI analysis · Informational 18/100

This commit is a code cleanup: it pulls the logic for waiting on a button press into a single shared helper function so the same code isn't repeated in many places. The behavior is essentially unchanged. The only functional difference is that one screen (the mnemonic setup) now explicitly treats a timeout as an error in normal builds, whereas before it would have hit a generic assertion. This is a minor hardening improvement, not a security vulnerability.

Security candidategui: add fill type and parent params to fill nodesby Jon Griffiths · 0caa7cfe · Sep 15, 2025 · 10 filesMessage 50 · ThinInformational 15Details
Commit message · Jon Griffiths

gui: add fill type and parent params to fill nodes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Informational 15/100

This commit is a straightforward internal cleanup of the user-interface drawing code for the Blockstream Jade hardware wallet. It changes how solid-color background boxes (called 'fill nodes') are created so callers can specify a fill style and parent container in one function call instead of two. There is no indication this fixes or introduces any security issue.

Security candidateRevert "camera: use VGA camera resolution for esp32s3"by Jon Griffiths · 346ceba4 · Sep 4, 2025 · 28 filesMessage 73 · AdequateInformational 15Details
Commit message · Jon Griffiths

Revert "camera: use VGA camera resolution for esp32s3"

QVGA appears to give faster and more accurate results when scanning than
VGA for Jade Plus.

Includes some minor cleanup since the surrounding code has changed
slightly.

This reverts commit 52df98693c8938f3322f8a780cd7451d3a6fa775.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
seed or entropy pathsigning or wallet path
AI analysis · Informational 15/100

This commit reverts a previous change that made the Jade Plus (ESP32-S3) camera use a higher VGA resolution. It returns all hardware variants to the lower QVGA resolution because QVGA was found to scan QR codes faster and more accurately on Jade Plus. It also removes the larger VGA test images and simplifies the output-message buffer size logic. There is no security fix or vulnerability here.

Security candidatetests: remove existing test pin data before running the testby Jon Griffiths · d04bb0e4 · Sep 4, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

tests: remove existing test pin data before running the test

This makes e.g. debugging less painful.

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
access control
AI analysis · Informational 15/100

This change only affects the project's test script. It deletes leftover test PIN files before running tests so developers don't get confused by stale data from earlier runs. There is no security issue in the product itself.

Security candidatesign_psbt: update input amounts when additional_info is presentby Jon Griffiths · 8c93b592 · Sep 4, 2025 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Jon Griffiths

sign_psbt: update input amounts when additional_info is present

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100

This commit fixes a bug in how Blockstream Jade signs Liquid Bitcoin transactions. When extra data ('additional_info') was provided for a transaction input, the hardware wallet was not updating its internal running totals of input amounts per asset. This could cause the device to miscalculate whether a transaction is balanced—potentially allowing a malicious or buggy host to trick the wallet into approving a transaction that silently moves more value than the user expects. The fix makes the wallet explicitly require and record the input's asset and amount in this code path.

Security candidatetests: add green multisig liquid pset test casesby Jon Griffiths · 0e2cfe79 · Sep 4, 2025 · 3 filesMessage 83 · StrongInformational 15Details
Commit message · Jon Griffiths

tests: add green multisig liquid pset test cases

The expected result PSBT is the PSBT signed using the default Green
software signer.

Note that we don't include the transaction hex. The previous commit
ensures we can extract it, but the Green transaction hex returned by gdk
includes dummy signatures/scriptsigs etc for fee estimation purposes.
These won't match the tx extracted from the signed PSBT.

All signed PSBTs have been confirmed to contain the valid user
signature.

83/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only adds new test cases for signing Liquid multisig transactions on the Blockstream Jade hardware wallet. It introduces two JSON test fixtures and a one-line change to include them in the test suite. There is no change to production code, no bug fix, and no security-relevant behavior.