Blockstream Jade

This commit fixes the use of the "%zu" printf format specifier, which is not supported by the ESP32 toolchain used in this project. The unsupported format could cause log messages and user-facing strings to display incorrect or garbage values. The commit also adds a CI check to prevent future use of "%zu". There is no direct evidence in the commit that this caused a security vulnerability such as information disclosure or memory corruption, but it is a code-quality fix that removes undefined/unsupported formatting behavior.

This commit fixes cleanup in the one-time-password (OTP) code. Previously, if setting up the cryptographic hash context failed, the code could return without freeing that context, and temporary buffers holding sensitive counter/HMAC data were not always wiped. The change ensures the context is released on failure and wipes temporary buffers before returning. It is a defensive hardening fix rather than a clear exploitable vulnerability.

This commit changes how Blockstream Jade handles its PIN server settings. Previously, changing the PIN server web address (URL) also wiped the device's private PIN encryption key, forcing the device to create a fresh one. The patch keeps the existing private key when only the URL changes, while still erasing it when the PIN server's public key changes. This avoids unnecessary key rotation and reduces the risk that a legitimate URL-only update silently breaks PIN security by generating a new key.

This commit fixes five spelling mistakes in documentation, code comments, and a script comment. None of the changes alter program behavior or affect security.

This commit adds an official developer-only 'fakeprod' build mode for Blockstream Jade hardware wallets. It deliberately weakens several security settings (single signature, committed private keys, readable flash-encryption key, enabled JTAG and ROM download mode) so developers can easily flash and debug a production-like firmware. The commit and its documentation explicitly warn that this mode is NOT secure and must never be used on a real wallet. It is a development/testing feature, not a vulnerability in production firmware.

This commit tightens how Blockstream Jade reads output amounts from a Partially Signed Bitcoin Transaction (PSBT). Before, the code tried to read the amount directly without first confirming it was actually present. Now it checks whether the amount exists before reading it. This is a defensive hardening change that could prevent incorrect handling of missing or malformed PSBT output data during transaction signing.

This commit tightens how Blockstream Jade verifies a Bitcoin transaction file (PSBT) before signing. It now requires that every byte in the file is part of the transaction, with no leftover or trailing data allowed. Previously, extra bytes at the end could have been ignored, which might let a malicious or malformed PSBT hide unexpected content or influence how the device interprets what it is signing.

This commit only moves and reorganizes existing test code. It adds a new helper to check whether the current transport is a specific type, moves a shared wait() function into a common test package file, and migrates a large set of low-level RPC tests into a new file. There are no changes to the actual Jade firmware, wallet logic, or production code, so this cannot introduce a security vulnerability in the shipped product.

This commit adds a new way to restore a Bitcoin wallet on a Blockstream Jade hardware device: instead of typing each recovery word, users can enter each word's one-based BIP39 number (for example, '1' for 'abandon'). The change also refactors the existing word-entry code and adds cleanup of sensitive on-screen state when the user exits. There is no direct evidence in the commit that this fixes an active security vulnerability, but it touches sensitive seed-recovery code and changes how user input is validated and cleared.

This commit refactors the on-screen digit-entry keypad in Blockstream Jade so callers can ask for shorter number fields (for example 4 digits instead of 6) and optionally cap the entered value. The existing 6-digit PIN and index entry behavior is kept unchanged. There is no direct evidence in the commit that this fixes an active security bug; it reads as a feature/generalization to support new UI flows such as entering BIP39 word numbers.

This commit is purely a testing infrastructure cleanup. It removes leftover command-line options and test files related to an older transaction-signing workflow, and makes sure temporary PIN files created during automated tests are cleaned up. There is no change to the actual Jade wallet firmware or its security behavior.

This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR scanner. The fix releases the touch and panel IO handles before deleting the I2C bus, preventing freezes and a memory leak. There is no evidence this is a security vulnerability or exploitable by an attacker.

This commit adds a new automated test file that checks whether sending a simple 'ping' message to a Jade hardware wallet interrupts an ongoing signing process. It is purely a test addition with no changes to production code, and it does not fix or introduce any security vulnerability.

This commit adds input validation to make sure the text shown in the OTP (one-time password) setup screen is properly URL-encoded and printable. It is likely a hardening fix to prevent malformed or sneaky label/issuer strings from confusing the user or causing unexpected behavior on the hardware wallet's screen, but the commit message does not call it a security fix.

This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test networks (like regtest), but blocks attempts to use the real Liquid mainnet genesis hash on test networks to prevent spoofing. The change also applies the same validation to both PSBT/PSET signing and raw transaction signing. It appears to be a hardening/feature addition rather than a fix for an active exploit, but it does close a spoofing path on test networks.

This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and no security relevance.

This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visible in the diff.

This commit is a large feature/refactor patch for Blockstream Jade's libjade (a desktop emulator of the Jade hardware wallet). It adds RPC endpoints that let a host application read the emulated device's screen, push fake button presses, read/write all emulated flash storage (NVS), and feed camera frames. The README explicitly warns that these RPCs mean 'a libjade instance is NOT SECURE FROM EXTERNAL APPLICATIONS, and that SECRET DATA CAN BE READ FROM THE RUNNING FIRMWARE.' The change is intended for development/testing only, but it removes the option to build without GUI support and makes the GUI code always compiled in. The security relevance is therefore primarily about increased attack surface and accidental misuse of a testing tool, rather than a vulnerability in production hardware wallets.

This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry confusing or inconsistent. There is no security vulnerability here—just a UI consistency bug.

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch future bugs where an error return is silently dropped, but the commit itself does not fix any specific known bug or change runtime behavior.

This commit tightens error handling when decoding the 'issuer' field of an OTP (one-time password) setup URI. Previously, a malformed issuer string could fail to decode silently; now the device shows an error and cancels the operation instead of continuing with potentially bad data. It also makes minor logging message changes and adds an assertion for the label/issuer decode in the display code.

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how the underlying library interprets that value, this could lead to reading truncated paths, rejecting valid transactions, or possibly reading past the intended buffer. It is a defensive fix in security-sensitive parsing code, but the commit itself does not claim a specific exploitable vulnerability.

This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error message but accidentally continued processing instead of stopping. This one-line fix adds the missing 'return' so the device rejects mismatched transactions immediately. Without the fix, a user could potentially be tricked into signing a transaction on the wrong network, which might lead to loss of funds or confusion between mainnet and testnet/signet assets.

This commit fixes a bug in the PIN-change flow on Blockstream Jade hardware wallets. Previously, if re-encrypting the wallet keys with a new PIN failed, or if the user abandoned the PIN change, the code did not jump to cleanup as intended. Instead, it could fall through and continue executing subsequent code paths that were meant to be skipped. This could lead to incorrect state handling, potential use of stale or invalid key material, or confusing behavior after a failed PIN change. The fix adds explicit 'goto cleanup' statements so the function exits the sensitive section safely in both error and abandonment cases.

This commit fixes a small but real bug in the device attestation setup code for Blockstream Jade, a hardware crypto wallet. When a one-time programmable security fuse failed to burn, the code used to exit immediately without releasing memory or undoing earlier setup steps. The fix makes it jump to a cleanup routine instead. The direct risk is mainly a resource leak or partial initialization state on a rare hardware failure, not an obvious remote attack.