BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Repository coverage

502 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

106security candidates69second-pass queue437AI analyses
25commits · 30 days
67commits · 60 days
220commits · 180 days
417commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
32Strong · 80–100
182Adequate · 60–79
250Thin · 40–59
38Opaque · 0–39
5security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths31357282157
Mike Tolkachev431438152
Daniel Newton771668055
Mihailo Milenkovic878057
roderico333060
Valerio Vaccaro1526054
Jamie C. Driver525053
Gustavo Cateim917078
Austin-Fulbright414060
quantpoet111072
cmiguelrn111045
tokyovyse111063
Analysis record

Published AI watches

Last scanned 45 minutes ago

Informational 20 AI analysisMessage 65 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

fmt: fix and prevent future use of unsupported format spec "zu"

This commit fixes the use of the "%zu" printf format specifier, which is not supported by the ESP32 toolchain used in this project. The unsupported format could cause log messages and user-facing strings to display incorrect or garbage val…

Use of unsupported printf format specifier %zu on embedded targetPotential for malformed log/UI output due to undefined format behaviorAddition of CI guard to prevent recurrence
26042182by Jon Griffiths+21−145 files
No security note in commit
Low 33 AI analysisMessage 30 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

otp: release md context on failure and clean temporary buffers

This commit fixes cleanup in the one-time-password (OTP) code. Previously, if setting up the cryptographic hash context failed, the code could return without freeing that context, and temporary buffers holding sensitive counter/HMAC data w…

Resource leak fix: mbedtls_md_free() now called on prepare_md_ctx failure pathSensitive buffer zeroization: wally_bzero() added for rcnt_buf and hmacControl-flow change from macro-based early return to explicit success checks
6e2cb6b6by Mike Tolkachev+26−141 file
No security note in commit
Low 47 AI analysisMessage 25 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

identity: clean temporary hash buffer

This commit fixes a small but real security hygiene issue in Blockstream Jade, a hardware wallet. A temporary buffer that holds a sensitive cryptographic hash (HMAC-SHA512 output used to derive child private keys) was not marked as sensiti…

Sensitive memory not marked for clearing (missing SENSITIVE_PUSH/POP)Buffer holds HMAC-SHA512 output used in BIP32 hardened child key derivationPatch adds explicit sensitive-memory lifecycle management
b5c35779by Mike Tolkachev+2−01 file
No security note in commit
Low 36 AI analysisMessage 15 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

qrmode: clean temporary buffer

This commit adds cleanup of a temporary memory buffer used when turning data into QR codes on the Blockstream Jade hardware wallet. The buffer could previously remain in memory after use, potentially leaving sensitive QR data behind for la…

Sensitive temporary buffer not cleared before fixUse of SENSITIVE_PUSH/SENSITIVE_POP memory-clearing macrosQR payload data may include private or confidential material
34f68c20by Mike Tolkachev+2−01 file
No security note in commit
Low 43 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

pinserver: retain unit private key on url change

This commit changes how Blockstream Jade handles its PIN server settings. Previously, changing the PIN server web address (URL) also wiped the device's private PIN encryption key, forcing the device to create a fresh one. The patch keeps t…

PIN private key lifecycle change: key retained on URL-only pinserver updatePublic-key change still triggers private-key erasure/regenerationDebug-clean and full reset still erase private key
ddcd93a3by Mike Tolkachev+38−324 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

add more boards and descriptions

This commit is a documentation update for the do-it-yourself (DIY) hardware section of the Blockstream Jade project. It adds descriptions and photos for additional supported circuit boards and updates image file references. There are no co…

f4fb150dby Valerio Vaccaro+65−1625 files
No security note in commit
Moderate 63 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

process: limit array sizes in sign_tx, register_multisig and sign_bip85_digests

This commit adds size limits to several message-handling functions in the Blockstream Jade hardware wallet firmware. It caps how many asset records, transaction inputs/outputs, multisig signers, and BIP85 RSA digests a single RPC message c…

Adds explicit upper bounds on attacker-controllable array sizesRejects zero-input/zero-output transactions before further processingMoves BIP85 digest count validation before memory allocation
e87f26bfby Daniel Newton+251−8114 files
No security note in commit
Informational 15 AI analysisMessage 28 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Update CHANGELOG.md

This commit only updates the project's CHANGELOG.md file to add release notes for version 1.0.41. It does not change any source code, build scripts, or configuration. The changelog text itself states that version 1.0.41 contains important …

Changelog describes prior security fixes in release 1.0.41Mentions external security researchers and tools (Loupe, Kvazar)References security-relevant improvements: stack protection, entropy, secure version, memory scrubbing, thread safety
dd45a7dcby Jon Griffiths+49−01 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 35 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

jadepy: update jadepy release

This commit simply bumps the version of a Python dependency called jade-client from 1.0.40 to 1.0.41, along with its matching cryptographic hashes and a fresh PGP signature. There is no code change visible here, and nothing in the commit m…

75eeada4by Jon Griffiths+19−192 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

consistency: fix docs/comment/script typos

This commit fixes five spelling mistakes in documentation, code comments, and a script comment. None of the changes alter program behavior or affect security.

9ea7eed3by Jon Griffiths+5−55 files
No security note in commit
Informational 17 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

esp_lcd: vendor the esp_lcd component (ESP-IDF v5.5.4)

This commit copies the ESP-IDF 'esp_lcd' display-driver component directly into the Blockstream Jade firmware repository (a process called 'vendoring') at version 5.5.4. It adds about 8,700 lines of display-interface code for LCD panels us…

Large vendored third-party driver import (+8,718 lines, 43 files)Driver code runs in interrupt context and uses DMA, which historically carries memory-safety and cache-coherency risksNo explicit security fix or bug-fix narrative in commit title/message
d89207bfby Daniel Newton+8718−043 files
No security note in commit
Informational 21 AI analysisMessage 57 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: "fakeprod" prod-like development mode

This commit adds an official developer-only 'fakeprod' build mode for Blockstream Jade hardware wallets. It deliberately weakens several security settings (single signature, committed private keys, readable flash-encryption key, enabled JT…

In-tree private keys committed to repository (tools/fakeprod_v2.pem, tools/fakeprod_attest.pem)Secure boot minimum signatures reduced from 2 to 1Flash encryption set to DEVELOPMENT mode with key readable
cecedc76by Daniel Newton+350−59 files
Vendor flagged security relevance
Low 45 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

urldecode: add validation for URL encoding

This commit hardens a URL-decoding helper in Blockstream Jade's firmware. It adds validation so malformed percent-encoding, embedded null bytes, control characters, and non-ASCII bytes are rejected instead of being silently decoded. A new …

Input validation added for percent-encoded sequencesRejection of embedded NUL bytes and control characters in decoded outputRejection of non-ASCII decoded bytes (>=0x80 and DEL 0x7f)
dd0d699dby Mike Tolkachev+100−272 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

qr: split datastream data into its own allocation, reorder alloc/free calls

This change rewrites how a small QR-code scanning library allocates memory. Instead of one big 16 KB block, it now uses two separate 8 KB blocks, and it frees them in the reverse order they were allocated. The stated goal is to avoid memor…

Memory allocation pattern changed from single large allocation to two smaller allocationsAllocation/free ordering changed to LIFO-style reverse pairingPointer field added to struct that previously held an inline array
43640f8cby Jon Griffiths+24−153 files
No security note in commit
Low 46 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: check output amount presence before reading

This commit tightens how Blockstream Jade reads output amounts from a Partially Signed Bitcoin Transaction (PSBT). Before, the code tried to read the amount directly without first confirming it was actually present. Now it checks whether t…

Missing-field check added before sensitive value readPSBT output amount parsing hardenedDefensive validation of libwally presence flags
9f2b916dby Jon Griffiths+2−11 file
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: require that all psbt bytes are consumed when parsing

This commit tightens how Blockstream Jade verifies a Bitcoin transaction file (PSBT) before signing. It now requires that every byte in the file is part of the transaction, with no leftover or trailing data allowed. Previously, extra bytes…

Parsing now rejects trailing/unconsumed bytes in PSBT inputChange is in the signing code path, directly affecting what the hardware wallet will signUse of stricter libwally-core parse flag (COMPLETE) indicates parser hardening
605d86acby Jon Griffiths+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

hardware: add Jade Plus design files

This commit reorganizes existing hardware design files for the original Jade device into a new subfolder and adds the open-source hardware design files for a new product, the Jade Plus. It does not change any software, firmware, or device …

5ad85661by bitcoinhelp+2573−122520 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

tests: migrate low level tests

This commit only moves and reorganizes existing test code. It adds a new helper to check whether the current transport is a specific type, moves a shared wait() function into a common test package file, and migrates a large set of low-leve…

767006a0by Valerio Vaccaro+1580−54 files
No security note in commit
Low 27 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

mnemonic: restore recovery phrase by word number

This commit adds a new way to restore a Bitcoin wallet on a Blockstream Jade hardware device: instead of typing each recovery word, users can enter each word's one-based BIP39 number (for example, '1' for 'abandon'). The change also refact…

New user-input path for seed recovery (word numbers instead of words)Refactoring of mnemonic input/validation helpersAddition of SENSITIVE_PUSH/POP for local mnemonic buffers
99927491by roderico+580−3183 files
No security note in commit
Informational 18 AI analysisMessage 68 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: support bounded variable-length digit entry

This commit refactors the on-screen digit-entry keypad in Blockstream Jade so callers can ask for shorter number fields (for example 4 digits instead of 6) and optionally cap the entered value. The existing 6-digit PIN and index entry beha…

New bounded numeric input path may prevent out-of-range values in future callersRefactoring centralizes input validation rather than relying on callersNo buffer-size changes observed; digit array remains DIGIT_ENTRY_SIZE (6) elements
69627745by roderico+128−332 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritytests: expect pset failures on non-psram devicesby Jon Griffiths · 1d9d2c9f · Sep 4, 2025 · 1 fileMessage 90 · StrongInformational 11Details
Commit message · Jon Griffiths

tests: expect pset failures on non-psram devices

Because the message stream desyncs when we send too large a message,
skip tests for unsupported config entirely (until a robust workaround is
available for this issue generally).

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 11/100

This commit only changes test code. It tells the test suite to skip or expect failures for certain large Bitcoin/Liquid transaction tests on devices without extra memory (non-PSRAM). It does not change the actual wallet firmware or fix a security bug in production code.

Lower-prioritytests: add a singlesig swap testby Jon Griffiths · e876dcfe · Sep 4, 2025 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · Jon Griffiths

tests: add a singlesig swap test

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a new test data file for a Liquid asset swap transaction. It contains no code changes, no bug fixes, and no security-related modifications. It is purely a test fixture.

Lower-priorityjadepy: avoid expensive message formatting for lines that won't be loggedby Jon Griffiths · 52fddaa3 · Sep 4, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Jon Griffiths

jadepy: avoid expensive message formatting for lines that won't be logged

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a minor performance optimization in the Python library that talks to the Jade hardware wallet. It prevents the code from building detailed debug log messages when debug logging is turned off. There is no security issue here.

Security candidatetests: pass through additional_info if provided for psbt/pset signingby Jon Griffiths · dfd55895 · Sep 4, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · Jon Griffiths

tests: pass through additional_info if provided for psbt/pset signing

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only changes test code. It makes the test helper pass an optional 'additional_info' field through to the sign_psbt() function when it is present in test cases. There is no change to the actual signing code or wallet behavior, so it does not create or fix a security vulnerability.

Lower-prioritywire: differentiate between invalid cbor and malformed cbor errorsby Jon Griffiths · 89620da2 · Sep 4, 2025 · 2 filesMessage 50 · ThinInformational 12Details
Commit message · Jon Griffiths

wire: differentiate between invalid cbor and malformed cbor errors

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only changes an error message string and loosens the matching in tests. It does not alter any security logic, parsing behavior, or access controls. There is no indication this fixes or introduces a security issue.

Security candidatesign_tx: split out updating output info from validating itby Jon Griffiths · 3f1b2feb · Sep 4, 2025 · 3 filesMessage 73 · AdequateInformational 11Details
Commit message · Jon Griffiths

sign_tx: split out updating output info from validating it

Removes some confusion from having validation change the data, but
primarily this will allow psbt signing to share the output validation
code without using the commitment update code (since pset commitments
are validated already during parsing and not passed separately like the
sign_tx case).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Informational 11/100

This commit is a code cleanup in the transaction signing logic for Blockstream Jade hardware wallets. It splits one function into two: one that gathers output information and another that validates it. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a refactoring to make the code clearer and to allow future reuse in PSBT signing.

Security candidatesign_psbt: check and provide genesis blockhash for psets per ELIP-0101by Jon Griffiths · 63f175af · Sep 4, 2025 · 1 fileMessage 83 · StrongLow 43Details
Commit message · Jon Griffiths

sign_psbt: check and provide genesis blockhash for psets per ELIP-0101

Per the ELIP, we must verify the network if present, and add it if
missing when signing (note that it is required for taproot signing).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 43/100

This commit adds checks for the Liquid network's 'genesis blockhash' in a Bitcoin hardware wallet signing flow. It ensures the PSBT (Partially Signed Bitcoin Transaction) includes the correct network identifier before signing, and fills it in if missing. Without this, a specially crafted transaction could potentially trick the device into signing for the wrong Liquid network or into producing invalid Taproot signatures. The change is defensive and aligns with the ELIP-0101 specification.

Security candidatesign_psbt: add support for additional_info/swap signingby Jon Griffiths · 2ef105cf · Sep 4, 2025 · 4 filesMessage 85 · StrongLow 35Details
Commit message · Jon Griffiths

sign_psbt: add support for additional_info/swap signing

As with the sign_tx case, we require and validate additional info for
swap signing. As this is not available in PSBT QR codes, swap signing is
not currently available by QR.

Also cleans up the error handling to ensure none of the new structures
are leaked on failure.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Low 35/100

This commit adds Liquid swap signing support for PSBTs in the Blockstream Jade hardware wallet firmware. It also restructures cleanup paths so memory is freed correctly when validation fails. The change is a feature addition with defensive cleanup improvements, not a clear-cut security fix, but it touches code that protects user funds during transaction signing.

AI review queuedsign_tx: return the error message when additional_info parsing failsby Jon Griffiths · 3a8f6095 · Sep 4, 2025 · 4 filesMessage 50 · ThinInformational 18Details
Commit message · Jon Griffiths

sign_tx: return the error message when additional_info parsing fails

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit fixes a minor user-experience and diagnostic issue in Blockstream Jade's transaction signing code. Previously, when the optional 'additional_info' block for Liquid transactions could not be parsed or validated, the device rejected the request without telling the caller exactly what went wrong. After the patch, the specific error message is passed back to the caller. There is no direct evidence this change fixes an exploitable security vulnerability.

Security candidatesign_psbt: disallow taproot swapsby Jon Griffiths · a4ea7299 · Sep 4, 2025 · 1 fileMessage 35 · OpaqueHigh 72Details
Commit message · Jon Griffiths

sign_psbt: disallow taproot swaps

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet path
AI analysis · High 72/100

This commit blocks a specific kind of Bitcoin/Liquid transaction signing on the Blockstream Jade hardware wallet. It prevents 'swap' transactions from using 'taproot' inputs because the device's signature-calculation code does not yet safely handle that combination. Without the fix, a user might have been able to build a transaction that the wallet would sign incorrectly or in a way that could be exploited, potentially leading to loss or theft of funds in a swap.

Security candidatesign_psbt: pass elements flag to signature hash generation for liquidby Jon Griffiths · cc2557bb · Sep 4, 2025 · 1 fileMessage 70 · AdequateModerate 57Details
Commit message · Jon Griffiths

sign_psbt: pass elements flag to signature hash generation for liquid

This is required for taproot, as Elements/Liquid use different hashing
and tweaking strategies in this case.

70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 57/100

This commit fixes how Blockstream Jade signs Liquid (Elements) Taproot transactions. Previously, the device used Bitcoin-style signature hashing for all networks, which is incorrect for Liquid Taproot. The fix passes a special 'Elements' flag when signing on Liquid so the signature hash matches Liquid's rules. Without this, signatures produced for Liquid Taproot transactions would be invalid or could potentially be produced using the wrong cryptographic formula, which in hardware wallets can sometimes lead to security issues like key leakage or signature-forgery attacks.

Lower-prioritytests: don't fail tx extraction if not all inputs are finalizedby Jon Griffiths · 4685e54f · Sep 4, 2025 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Jon Griffiths

tests: don't fail tx extraction if not all inputs are finalized

We don't expect multisig or partial swap transactions to be completely
finalized: allow this so we can still reconcile the final tx output
(for example, against core output).

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This change only modifies a test file. It adjusts how a test extracts transaction data from a partially signed Bitcoin transaction (PSBT) so that tests for multisig or partial-swap transactions don't fail when not every input is fully signed. There is no change to production code, wallet logic, or security behavior.

Lower-prioritypset: add liquid singlesig testsby Jon Griffiths · cb0af490 · Sep 4, 2025 · 5 filesMessage 70 · AdequateInformational 15Details
Commit message · Jon Griffiths

pset: add liquid singlesig tests

Covers all supported singlesig input/address types including taproot.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds new test cases for Liquid single-signature transactions (including taproot) to the Blockstream Jade hardware wallet project. It introduces JSON test fixtures and extends a Python test file. There are no code changes to the wallet firmware, signing logic, or any security-sensitive functionality.

AI review queuedsign_tx: Strengthen liquid commitment checks against the tx being signedby Jon Griffiths · a454d1f4 · Sep 4, 2025 · 6 filesMessage 83 · StrongModerate 59Details
Commit message · Jon Griffiths

sign_tx: Strengthen liquid commitment checks against the tx being signed

This change ensures that the transaction and any commitment values
match, if an asset/value commitment pair are given.

Commitments given as part of tx input data must have these fields, while
they are optional (and should be discouraged) for tx outputs.

We move the validation checking which was spread over several unrelated
areas into the function fetching the commitment data. This ensures that
when fetching it, it is either fully validated from that point on or an
error is returned.

Following this we remove the commitment fields from the commitment_t struct
since they are now redundant for the remainder of sign_tx processing.

From experience debugging tests where the commitments mismatched, the
old error messages were not helpful. Update these to include 'trusted
commitment' in all messages to make it clearer when a mismatch is
detected.

Note This commit is deliberately minimal to make the core logic changes
easier to review.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This commit hardens how Blockstream Jade validates confidential (blinded) transaction data on Liquid. It moves and strengthens checks so that any asset/value commitment pair supplied by the caller must match the transaction actually being signed, and it removes redundant commitment fields from an internal data structure. The change is defensive: it reduces the chance that a malicious or buggy host could trick the hardware wallet into signing a transaction with mismatched blinding data.

AI review queuedsign_tx: rename get_commitments_data and document itby Jon Griffiths · 7bd2fba9 · Sep 4, 2025 · 3 filesMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_tx: rename get_commitments_data and document it

Moves the proof validation call so we don't need to forward declare it.

No functional changes.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit renames a function from get_commitment_data to params_commitment_data, moves a helper function earlier in the file to remove a forward declaration, and adds documentation comments. The commit message explicitly states there are no functional changes, and the diff shows only renaming, reordering, and comment additions with no logic changes.

Security candidatesign_psbt: use the signature type of inputs we are signing instead of a boolby Jon Griffiths · fd4c303a · Sep 4, 2025 · 1 fileMessage 55 · ThinLow 31Details
Commit message · Jon Griffiths

sign_psbt: use the signature type of inputs we are signing instead of a bool

Also drive-by fix a log line.

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 31/100

This commit changes how a Bitcoin hardware wallet (Blockstream Jade) tracks which transaction inputs it needs to sign. Previously it stored a simple yes/no flag; now it stores the actual signature type requested by the PSBT (Partially Signed Bitcoin Transaction). The change is mostly a code-quality improvement, but it removes a place where the wrong signature type could silently be assumed. There is no direct evidence in the commit that an actual vulnerability was fixed, and no vendor security disclosure is present.

Security candidatesign_psbt: skip inputs we arent signing explicitlyby Jon Griffiths · 6b161dc4 · Sep 4, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Jon Griffiths

sign_psbt: skip inputs we arent signing explicitly

No functional changes, this just shifts the processing code over instead
of holding open a very large if block.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a pure code-style refactor. It flips a large 'if' block into an early 'continue' so the code inside is no longer deeply indented. The commit message explicitly says there are 'No functional changes'. No security issue is introduced or fixed.

Security candidatesign_psbt: assert script taprootyness matches our deduced signature typeby Jon Griffiths · 086fa5da · Sep 4, 2025 · 1 fileMessage 55 · ThinModerate 57Details
Commit message · Jon Griffiths

sign_psbt: assert script taprootyness matches our deduced signature type

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 57/100

This commit adds a safety check in the code that signs Bitcoin transactions. It ensures that when the wallet decides to produce a Taproot-style signature, the script being spent actually looks like a Taproot script, and vice versa. Without this check, a mismatch between the script type and signature type could potentially lead to incorrect signatures or unexpected behavior when signing transactions.

Lower-prioritydocs: document that commitment data must match the tx outputby Jon Griffiths · 20d62a6c · Sep 4, 2025 · 1 fileMessage 62 · AdequateInformational 3Details
Commit message · Jon Griffiths

docs: document that commitment data must match the tx output

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 3/100

This is a one-line documentation edit in a user manual. It adds a note that two pieces of cryptographic data supplied by the host must match the values in the transaction output being signed. There is no code change, no bug fix, and no disclosed security issue in the commit itself.

AI review queuedsign_tx: remove blind proofs from commitment databy Jon Griffiths · 85de91d5 · Sep 4, 2025 · 2 filesMessage 68 · AdequateLow 25Details
Commit message · Jon Griffiths

sign_tx: remove blind proofs from commitment data

As with the asset and value commitments, these are not required once the
commitment data has been validated.

Re-order the commitment struct members to further lower the memory size
required to hold commitments.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit reorganizes how a hardware wallet stores temporary blinding proofs while validating a confidential transaction. It moves large proof data out of a small 'commitment' structure into a larger extended structure, and only copies the smaller validated data back to the caller. The stated goal is to reduce memory use, not to fix a security bug. There is no direct evidence in the commit that this prevents an exploitable vulnerability, but memory handling changes in security-critical code always warrant careful review.

Security candidatesign_tx/sign_psbt: share code to validate supported sighash flagsby Jon Griffiths · 6e2a10ca · Sep 4, 2025 · 5 filesMessage 50 · ThinLow 45Details
Commit message · Jon Griffiths

sign_tx/sign_psbt: share code to validate supported sighash flags

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Low 45/100

This commit is a code cleanup that moves the rules for which Bitcoin/Liquid 'sighash' flags are allowed into one shared helper function used by both signing paths. Before, the PSBT signing path only rejected non-ALL sighashes for non-Taproot inputs, while the direct sign_tx path had more detailed rules (for example, allowing SINGLE|ANYONECANPAY for partial Liquid swaps). Unifying the logic reduces the chance that one path accidentally allows a dangerous sighash. The change itself does not add new user-facing behavior; it is defensive hardening/refactoring.

Security candidatesign_tx: add sign_utils.h to declare the types and functions used by signingby Jon Griffiths · afb052a6 · Sep 4, 2025 · 8 filesMessage 50 · ThinInformational 15Details
Commit message · Jon Griffiths

sign_tx: add sign_utils.h to declare the types and functions used by signing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a straightforward code cleanup: it moves type and function declarations that were scattered across several files into a single new header file called sign_utils.h. There is no change to what the code actually does, only to how the source files are organized. It does not fix or introduce any security issue.

Security candidatesign_tx: split out signing tx validation, add more checksby Jon Griffiths · 1705ca93 · Sep 4, 2025 · 3 filesMessage 65 · AdequateModerate 57Details
Commit message · Jon Griffiths

sign_tx: split out signing tx validation, add more checks

Also move the explicit fee fetching/validation into the split out
function.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 57/100

This commit reorganizes how Blockstream Jade validates transaction data before signing. It moves several Liquid-network checks earlier in the process and adds new rules: a transaction output with no recipient script (typically a network fee) must now be unblinded, non-zero, use the network's official policy asset, and there can only be one such fee output. The change also prevents a transaction from being silently treated as a different network type (Bitcoin vs. Liquid). These are defensive hardening measures rather than a fix for a confirmed active attack.

Security candidatesign_psbt: use shared signing tx validation codeby Jon Griffiths · 35ad314f · Sep 4, 2025 · 1 fileMessage 68 · AdequateLow 44Details
Commit message · Jon Griffiths

sign_psbt: use shared signing tx validation code

This means we don't have to find the fee ourselves, and ensures that
the checks we perform (e.g. duplicate fees) are consistent whether we
are signing a tx or psbt.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 44/100

This commit refactors how the Blockstream Jade hardware wallet checks transaction fees when signing a PSBT. Previously, the fee was calculated and validated inside the PSBT-specific code. Now it uses a shared validation routine that is also used for regular transaction signing. The goal is consistency: the same duplicate-fee and fee-validation checks apply regardless of whether the user is signing a raw transaction or a PSBT. The commit removes several local fee checks (such as rejecting blinded fee outputs or unexpected fee asset IDs) and relies on the shared function instead. This is a code-quality and consistency improvement, not a clear-cut security fix, but it touches security-critical fee logic.

Security candidatesign_psbt: use the psbt tx directly if possibleby Jon Griffiths · 90f16a56 · Sep 4, 2025 · 1 fileMessage 60 · AdequateInformational 24Details
Commit message · Jon Griffiths

sign_psbt: use the psbt tx directly if possible

Since we aren't finalizing the tx, we can use it directly for v0 PSBTs
and avoid creating a new one.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 24/100

This commit changes how a Bitcoin hardware wallet (Blockstream Jade) obtains the transaction it signs from a Partially Signed Bitcoin Transaction (PSBT). For older v0 PSBTs, it now uses the transaction embedded in the PSBT directly instead of extracting a fresh copy. The main risk is that the code now trusts the PSBT's internal transaction more directly, but the commit also adds a safety check that the transaction exists and matches the PSBT's input/output counts. There is no clear security bug visible in the diff, but the change touches sensitive signing logic and is described only as a simplification, not a security fix.