CommitWatch RSS
BS
← All projectsBlockstream

Blockstream Jade

Firmware for Jade and Jade Plus Bitcoin hardware wallets.

BitcoinHardware walletsElevated watch
Source repository ↗
Repository coverage

414 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

93security candidates58second-pass queue65AI analyses
10commits · 30 days
67commits · 60 days
198commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 6216 seen38 candidatesComplete
Feb 6 → Jun 6131 seen9 candidatesComplete
Jun 6 → Jul 657 seen10 candidatesComplete
Jul 6 → Aug 510 seen0 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
32Strong · 80–100
147Adequate · 60–79
203Thin · 40–59
32Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Jon Griffiths2755235157
Mike Tolkachev311110155
Daniel Newton65158055
Mihailo Milenkovic877057
Jamie C. Driver522053
Gustavo Cateim711079
Austin-Fulbright410060
roderico110045
quantpoet111072
tokyovyse110063
cmiguelrn111045
odudex200071
Analysis record

Published AI watches

Last scanned 43 minutes ago

Low 27 AI analysisMessage 86 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

input: release touch handles before deleting the i2c bus

This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR …

Device freeze/DoS-like symptom on affected hardwareMemory leak fixedNo input validation, authentication, or cryptographic weakness visible
36776fecby Gustavo Cateim+3−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 95 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

Liquid (taproot): add sign_liquid_tx genesis blockhash support

This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test n…

Adds input validation for caller-supplied genesis blockhashPrevents mainnet genesis hash from being used on Liquid test networksRestricts genesis_hash parameter to Liquid networks only
888eff30by Jon Griffiths+82−264 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: rename get_boolean to get_bool

This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and…

f6e946acby Jon Griffiths+24−2518 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: refactor app code to use getters with default values

This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visibl…

b6a07147by Mike Tolkachev+22−348 files
No security note in commit
Open full analysis →Source commit ↗
Low 36 AI analysisMessage 74 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

build: annotate functions returning error codes to ensure they are checked

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch futur…

Compiler annotation added to enforce checking of error-returning functionsNo specific vulnerability fixed in the diffNo functional code changes or call-site fixes included
909a89aaby Mike Tolkachev+215−15225 files
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 28 · Opaque
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: fix path size

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how t…

Buffer-size semantic mismatch in security-critical PSBT parsingUse of sizeof() on uint32_t array where element count is expectedCode path involved in 2of3 multisig recovery key identification
9e0c3747by Mike Tolkachev+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_psbt: add early reject on wrong genesis blockhash

This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error mes…

Missing return in error path allows execution to continue after validation failureCross-network genesis hash mismatch not enforced as a hard failurePSBT signing logic accepts mismatched network parameters
56e130b0by Mike Tolkachev+1−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 42 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

main: fix error handling during PIN change

This commit fixes a bug in the PIN-change flow on Blockstream Jade hardware wallets. Previously, if re-encrypting the wallet keys with a new PIN failed, or if the user abandoned the PIN change, the code did not jump to cleanup as intended.…

Missing error-path control flow in cryptographic key handlingPotential use of stale or partially initialized key material after PIN-change failureCleanup bypass in sensitive authentication code path
64c30823by Mike Tolkachev+2−01 file
No security note in commit
Open full analysis →Source commit ↗
Low 39 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

attestation: fix missing cleanup on failed efuse write

This commit fixes a small but real bug in the device attestation setup code for Blockstream Jade, a hardware crypto wallet. When a one-time programmable security fuse failed to burn, the code used to exit immediately without releasing memo…

Missing cleanup on error path in security-critical initializationResource leak on failed efuse writePotential inconsistent attestation state after partial initialization
d37d88b7by Mike Tolkachev+1−11 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

attestation: harden error handling of challenge signing

This commit fixes a bug in the Blockstream Jade hardware wallet's attestation signing process. Previously, if signing the attestation challenge failed, the device would send an error message but then continue running the rest of the functi…

Missing return after error path allows fall-through to success-path replyUninitialized output.ext_signature_len could leak stack data or cause undefined behaviorAttestation signing failure could result in sending an invalid attestation reply
ecc5871bby Mike Tolkachev+2−01 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 77 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

wallet: fix unhandled wrong asset in wallet summaries

This commit fixes a bug in the Blockstream Jade hardware wallet where a function that tracks assets during transaction signing could fail silently. Previously, if an unexpected or wrong asset was encountered while building a summary of tra…

Unchecked return value from asset_summary_update() in signing pathPotential bypass of asset/balance validation during transaction signingWrong or unknown asset could be silently dropped from wallet summaries
b33cf02bby Mike Tolkachev+18−53 files
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 85 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign: update output logic, rename and document output flags for clarity

This commit reworks how a Blockstream Jade hardware wallet labels transaction outputs. The key change is that the 'change' flag is now only set when the output is also confirmed as belonging to the wallet ('is ours'). Previously, downstrea…

Change output flag now gated by wallet-ownership flagUI hides change outputs based on single bit with runtime assertionGreen 2of3 outputs no longer marked as change because not marked as wallet-owned
cf79a3aaby Mike Tolkachev+32−245 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Moderate 57 AI analysisMessage 58 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

esp-idf: update to v5.5.4, take multisig bootloader component from https://github.com/Blockstream/esp-idf/tree/securebootv2_multisig_v5.5.4

This is a large update that pulls in Espressif's ESP-IDF v5.5.4 bootloader code, plus Blockstream's own multi-signature secure-boot patches. Most of the visible changes are routine: support for newer ESP32 chips, larger flash sizes, and a …

Anti-fault-injection assertion (ESP_FAULT_ASSERT) added around TEE flash address validationTEE flash write/erase now rejects operations targeting the active TEE partition rangeSecure Boot V2 extended to support ECDSA-P384 / SHA-384 digests
d931d543by Daniel Newton+3879−1437104 files
No security note in commit
Open full analysis →Source commit ↗
High 72 AI analysisMessage 85 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

sign_tx: suppress validation/change attribution for green 2of3 outputs

This update fixes a security gap in how Blockstream Jade signs Bitcoin transactions for a specific wallet type called Green 2of3. Previously, the device trusted the connected app to supply a recovery public key and might silently treat an …

Host-supplied recovery_xpub was trusted for change attributionChange output could be misattributed without user confirmationFix suppresses automatic validation for Green 2of3 outputs
0243f239by Mike Tolkachev+17−11 file
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

ui: tidy up message/error activities

This commit is a straightforward code cleanup. It replaces a verbose way of showing on-screen messages and errors with simpler helper functions, and fixes a spelling mistake ('re-encypt' to 're-encrypt'). There is no change to security log…

No security-relevant logic changesRefactoring only: API simplification for UI message displaySpelling correction in user-facing error string
1914ace0by Daniel Newton+162−24625 files
No security note in commit
Open full analysis →Source commit ↗
Low 25 AI analysisMessage 60 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

wire: reduce stack usage sending replies

This commit changes how message context is passed between functions in the Blockstream Jade hardware wallet firmware. Instead of copying the entire message context structure on the stack, functions now receive a pointer to it. The stated g…

Stack usage reduction in embedded firmwarePointer passing instead of structure copyingNo direct vulnerability described in commit message
c41f5fddby Jon Griffiths+65−6429 files
No security note in commit
Open full analysis →Source commit ↗
Informational 24 AI analysisMessage 45 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

rpc: add show_bip85_bip39_entropy RPC command

This commit adds a new device command that lets a connected computer or phone ask a Blockstream Jade hardware wallet to display an encrypted BIP85 seed-entropy backup as a QR code. The change also tightens validation of the BIP32 index in …

New RPC exposes encrypted BIP85 entropy via on-device QR displayBIP32 index bounds checks added in multiple RPC parameter parsersSensitive stack buffers now marked with SENSITIVE_PUSH/POP in QR reply path
3392661cby Daniel Newton+115−277 files
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 62 · Adequate
BS BlockstreamBlockstream Jade BitcoinHardware wallets

docs: add show_bip85_bip39_entropy RPC documentation

This commit only adds documentation for an existing RPC command called show_bip85_bip39_entropy. It does not change any code, so it cannot introduce or fix a security vulnerability by itself.

2e829638by Daniel Newton+37−01 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 57 AI analysisMessage 50 · Thin
BS BlockstreamBlockstream Jade BitcoinHardware wallets

psbt: always confirm green outputs when recovery signing

This commit changes the logic in Blockstream Jade's PSBT signing flow so that, when the hardware wallet is acting as a 'recovery' key for a Green 2-of-3 wallet, it always asks the user to confirm outputs that belong to Green, rather than s…

Logic inversion in authorization/confirmation pathRecovery-key signing path previously trusted Green-classified outputs without user confirmationComment explicitly frames change around inability to verify output ownership in recovery path
a963f628by Jon Griffiths+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Moderate 59 AI analysisMessage 91 · Strong
BS BlockstreamBlockstream Jade BitcoinHardware wallets

mnemonic: gracefully handle invalid bcur-bip39 mnemonics, improve tests

This update fixes how Blockstream Jade handles QR-code-based recovery phrases imported in a specific format (bcur-bip39). Previously, a malformed or invalid recovery phrase could crash the device because the code used internal 'assert' che…

Replaces assertion failures with controlled error returns on malformed mnemonic inputAdds input validation for word count, word length, and empty words in bcur-bip39 parserReduces stack buffer size for mnemonic handling
898b9fb2by Jon Griffiths+94−615 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityjadepy: add builtin file method impls for newer cbor2 versionsby Jon Griffiths · 9857bed9 · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

jadepy: add builtin file method impls for newer cbor2 versions

Thanks to @1-21gigasats for reporting.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityjadepy: support new/old versions of cbor2by Jon Griffiths · 91cc2edb · Jun 23, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Jon Griffiths

jadepy: support new/old versions of cbor2

Based on a change from @1-21gigasats.

cbor2 b0rkage seems assured while it transitions its underlying
implementation. Supply a workaround for library interface changes,
as distateful as requiring it is.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-prioritywire: explicitly set nonblocking default to falseby Jon Griffiths · 3d28dccb · Jun 23, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths

wire: explicitly set nonblocking default to false

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritylibjade: use existing frame buffer rectangle drawingby Jon Griffiths · ff0789f0 · Jun 23, 2026 · 3 filesMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

libjade: use existing frame buffer rectangle drawing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritytools: don't attempt to overwrite kconfig if checking failsby Jon Griffiths · 3dd9c4db · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

tools: don't attempt to overwrite kconfig if checking fails

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritybuild: add build support for enforcing return codes are checkedby Mike Tolkachev · bb2e53d6 · Jun 23, 2026 · 3 filesMessage 62 · AdequateTriage 0Details
Commit message · Mike Tolkachev

build: add build support for enforcing return codes are checked

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-priorityassets: explicitly allow precision field to be optionalby Mike Tolkachev · 36f997b9 · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Mike Tolkachev

assets: explicitly allow precision field to be optional

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatebuild: annotate functions returning error codes to ensure they are checkedby Mike Tolkachev · 909a89aa · Jun 23, 2026 · 25 filesMessage 74 · AdequateLow 36Details
Commit message · Mike Tolkachev

build: annotate functions returning error codes to ensure they are checked

74/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Explains rationale or failure mode! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathboot or update pathauthentication pathparser or protocol path
AI analysis · Low 36/100

This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch future bugs where an error return is silently dropped, but the commit itself does not fix any specific known bug or change runtime behavior.

Security candidateotp: show error on invalid issuer, share logging stringsby Mike Tolkachev · 66c945f2 · Jun 23, 2026 · 2 filesMessage 50 · ThinTriage 10Details
Commit message · Mike Tolkachev

otp: show error on invalid issuer, share logging strings

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI review queuedidentity: add identity string validationby Mike Tolkachev · 53752b98 · Jun 23, 2026 · 2 filesMessage 45 · ThinTriage 12Details
Commit message · Mike Tolkachev

identity: add identity string validation

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
Lower-priorityusb: remove unused return from usb top level actionsby Jon Griffiths · 2ff2b31d · Jun 23, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

usb: remove unused return from usb top level actions

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatepsbt: fix path sizeby Mike Tolkachev · 9e0c3747 · Jun 23, 2026 · 1 fileMessage 28 · OpaqueLow 42Details
Commit message · Mike Tolkachev

psbt: fix path size

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 42/100

This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how the underlying library interprets that value, this could lead to reading truncated paths, rejecting valid transactions, or possibly reading past the intended buffer. It is a defensive fix in security-sensitive parsing code, but the commit itself does not claim a specific exploitable vulnerability.

AI review queuedutils: fix params_additional_info return typeby Jon Griffiths · 3d6cdbcb · Jun 23, 2026 · 2 filesMessage 45 · ThinTriage 12Details
Commit message · Jon Griffiths

utils: fix params_additional_info return type

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedsign: match sign_tx logic for output commitment checkingby Jon Griffiths · be05deac · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 12Details
Commit message · Jon Griffiths

sign: match sign_tx logic for output commitment checking

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedurl: improve bounds checkingby Mike Tolkachev · c045aeac · Jun 23, 2026 · 1 fileMessage 35 · OpaqueTriage 7Details
Commit message · Mike Tolkachev

url: improve bounds checking

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
Lower-priorityqr: fix error handling for qr exportby Jon Griffiths · 5e9b791e · Jun 23, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths

qr: fix error handling for qr export

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritydescriptor: improve validation of child key pathby Mike Tolkachev · 2fad63e7 · Jun 23, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Mike Tolkachev

descriptor: improve validation of child key path

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritykeychain: fix error handling for cached green service keysby Jon Griffiths · 15630d12 · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths

keychain: fix error handling for cached green service keys

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatesign_psbt: add early reject on wrong genesis blockhashby Mike Tolkachev · 56e130b0 · Jun 23, 2026 · 1 fileMessage 50 · ThinModerate 59Details
Commit message · Mike Tolkachev

sign_psbt: add early reject on wrong genesis blockhash

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100

This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error message but accidentally continued processing instead of stopping. This one-line fix adds the missing 'return' so the device rejects mismatched transactions immediately. Without the fix, a user could potentially be tricked into signing a transaction on the wrong network, which might lead to loss of funds or confusion between mainnet and testnet/signet assets.

Lower-prioritymain: ensure seed is present before completing OTP registrationby Mike Tolkachev · 0d6536df · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Mike Tolkachev

main: ensure seed is present before completing OTP registration

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritymain: fix error handling for debug handshakeby Mike Tolkachev · 7fb5e90e · Jun 23, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Mike Tolkachev

main: fix error handling for debug handshake

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatemain: fix error handling during PIN changeby Mike Tolkachev · 64c30823 · Jun 23, 2026 · 1 fileMessage 45 · ThinLow 42Details
Commit message · Mike Tolkachev

main: fix error handling during PIN change

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
access controlauthentication path
AI analysis · Low 42/100

This commit fixes a bug in the PIN-change flow on Blockstream Jade hardware wallets. Previously, if re-encrypting the wallet keys with a new PIN failed, or if the user abandoned the PIN change, the code did not jump to cleanup as intended. Instead, it could fall through and continue executing subsequent code paths that were meant to be skipped. This could lead to incorrect state handling, potential use of stale or invalid key material, or confusing behavior after a failed PIN change. The fix adds explicit 'goto cleanup' statements so the function exits the sensitive section safely in both error and abandonment cases.

Lower-prioritydisplay: add check for screen power on statusby Mike Tolkachev · 1883d343 · Jun 23, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Mike Tolkachev

display: add check for screen power on status

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritylog: gracefully ignore failed log printingby Jon Griffiths · 45897011 · Jun 23, 2026 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths

log: gracefully ignore failed log printing

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritymain: check MAC address obtained successfully from efuseby Mike Tolkachev · 5ffaacc6 · Jun 23, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Mike Tolkachev

main: check MAC address obtained successfully from efuse

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body