sign_tx: reject liquid txs containing inputs missing commitments
What changed, and why it matters
This update fixes a flaw in Blockstream Jade's signing process for Liquid network transactions. Previously, if a transaction input lacked commitment data (the information needed to verify asset amounts and types), the device could still ask the user to approve an incomplete or misleading on-screen summary. The fix now rejects such transactions outright, preventing the user from being shown an unverified summary and potentially signing something they did not fully understand.
Users should upgrade Jade firmware to a version containing this commit. Developers should review whether any other transaction-summary paths allow missing commitment data and ensure all Liquid inputs have complete, validated commitments before user approval.
Security signals we found
Missing input validation branch now explicitly rejected
Prevents presentation of incomplete transaction summary to user
Liquid confidential transaction commitment handling
User-interface / user-approval bypass risk mitigated
Evidence from the diff
In main/process/sign_tx.c, the sign_tx_impl() function handles Liquid transaction signing. The existing code checked whether input commitment data was present and valid, and rejected the request with CBOR_RPC_BAD_PARAMETERS if commitments were ‘invalid’. However, if commitments were simply missing (the else branch), execution continued. This patch adds an explicit else branch that rejects the transaction with CBOR_RPC_BAD_PARAMETERS and the message ‘Failed to validate input/output summary information’, ensuring missing commitment data cannot lead to an incomplete wallet summary being presented to the user for approval.
Changed components
main/process/sign_tx.cLiquid transaction signing flowInput commitment validationInspect captured patch +6 / −0
### main/process/sign_tx.c
@@ -638,6 +638,12 @@ static void sign_tx_impl(jade_process_t* process, const bool for_liquid)
// Invalid input commitments (rather than simply not present)
jade_process_reject_message(process, CBOR_RPC_BAD_PARAMETERS, errmsg);
goto cleanup;
+ } else {
+ // No commitment data. Reject otherwise the user is being asked to approve an incomplete summary
+ JADE_LOGW("Input %" PRIu32 " has no commitment data for the wallet summary", index);
+ jade_process_reject_message(
+ process, CBOR_RPC_BAD_PARAMETERS, "Failed to validate input/output summary information");
+ goto cleanup;
}
}
if (for_liquid && input_data->sig_type != WALLY_SIGTYPE_PRE_SW) {Why this scored 59/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.