Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit reorganizes existing hardware design files for the original Jade device into a new subfolder and adds the open-source hardware design files for a new product, the Jade Plus. It does not change any software, firmware, or device …
This commit fixes a bug where the touchscreen driver failed to clean up internal handles when shutting down. On newer ESP-IDF firmware, this cleanup failure caused the device to panic and freeze during boot and when using the camera or QR …
Device freeze/DoS-like symptom on affected hardwareMemory leak fixedNo input validation, authentication, or cryptographic weakness visible
This commit adds a new command-line command called 'selfcheck' to the Jade CLI tool. It simply calls an existing device function and prints the result. There is no indication of a security fix or vulnerability being patched.
This commit changes how Blockstream Jade handles the 'genesis blockhash' when signing Liquid transactions. Previously, the device only accepted the network's built-in genesis hash. Now it lets users provide a custom genesis hash for test n…
Adds input validation for caller-supplied genesis blockhashPrevents mainnet genesis hash from being used on Liquid test networksRestricts genesis_hash parameter to Liquid networks only
This commit adds compiler annotations (WARN_UNUSED_RESULT) to functions that return success/failure codes, so the compiler will warn if a caller ignores the result. It also fixes a few places where return values were being ignored, replaci…
Functions returning error/success codes annotated with WARN_UNUSED_RESULTCallers now check return values of rpc_get_bip32_path() and rpc_get_boolean()Use of default-value helpers (rpc_get_boolean_or) to ensure predictable behavior on missing fields
This commit simply renames an internal helper function from `rpc_get_uint64_t` to `rpc_get_uint64` and updates every place that calls it. There are no changes to what the function does, how it checks data, or how secure it is. It is a rout…
This commit is a simple rename of two internal helper functions from `rpc_get_boolean`/`rpc_get_boolean_or` to `rpc_get_bool`/`rpc_get_bool_or`, updating all call sites accordingly. There is no change to what the code does, no bug fix, and…
This commit is a straightforward code cleanup that replaces verbose 'read this optional value, or leave the default' patterns with shorter helper functions that do the same thing. There is no change in behavior and no security issue visibl…
This commit tightens how Blockstream Jade handles the 'precision' value in asset contracts for Liquid assets. Previously, a very large precision value could be accepted and later used to read past the end of an internal lookup table (POW_1…
Out-of-bounds read mitigation: bounds-checking of user-controlled precision before indexing fixed-size POW_10 arrayInteger truncation safety: explicit cast of validated precision to uint8_t after range checkCompile-time invariant enforcement: JADE_STATIC_ASSERT ties array size to ASSET_PRECISION_MAX
This commit simply updates the SHA256 digest of the 'blockstream/jade_builder' Docker image used for building and testing Jade in four configuration files. There is no code change, no disclosed security fix, and no evidence in the commit o…
This commit is a large feature/refactor patch for Blockstream Jade's libjade (a desktop emulator of the Jade hardware wallet). It adds RPC endpoints that let a host application read the emulated device's screen, push fake button presses, r…
New RPC endpoints allow external read/write of emulated NVS storageNew RPC endpoints allow external screen capture and synthetic input injectionNew RPC endpoints allow external camera frame injection
This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry con…
This commit is a preventive build-hardening change. It adds compiler annotations (WARN_UNUSED_RESULT) to many functions that return success/failure codes, so the compiler will warn if a caller ignores the result. The goal is to catch futur…
Compiler annotation added to enforce checking of error-returning functionsNo specific vulnerability fixed in the diffNo functional code changes or call-site fixes included
This commit adds a safety check to Blockstream Jade's 'sign identity' feature. Before the change, the device would accept any identity string a connected app sent. Now it rejects identities that contain non-printable or unusual characters.…
Input validation added to a signing/identity processNew length-bounded string helper reduces reliance on null-terminationRejection of non-printable characters in user-presented identity string
This commit tightens error handling when decoding the 'issuer' field of an OTP (one-time password) setup URI. Previously, a malformed issuer string could fail to decode silently; now the device shows an error and cancels the operation inst…
Input validation added for OTP URI issuer fieldSilent failure on malformed URL-decoding replaced with explicit error returnDebug assertion added for label/issuer URL-decoding in UI display path
This commit fixes a small but meaningful bug in how Jade, a hardware wallet, reads key paths from Bitcoin PSBT data. The code was passing the byte size of a buffer when it should have passed the number of 32-bit entries. Depending on how t…
Buffer-size semantic mismatch in security-critical PSBT parsingUse of sizeof() on uint32_t array where element count is expectedCode path involved in 2of3 multisig recovery key identification
This commit fixes a logic gap in how Blockstream Jade checks cryptographic commitments for transaction outputs during signing. Previously, the code treated a missing commitment the same as an invalid one, which could cause the device to re…
Inconsistent commitment validation between signing code pathsPossible transaction signing failure or acceptance of unvalidated output commitmentsLogic alignment with existing sign_tx commitment handling
This commit changes the declared return type of a transaction-signing helper function from a transaction-type code (TxType_t) to a simple success/fail boolean (bool). The function body already appears to return true/false, so the change fi…
Return-type mismatch between function declaration/definition and headerFunction is in transaction-signing utility code (sign_utils.c/h)Function handles CBOR transaction parameters and writes output transaction metadata
This commit tightens bounds checks in URL encoding/decoding functions used in Blockstream Jade, a hardware wallet. The changes fix potential off-by-one/out-of-bounds memory reads and writes when handling percent-encoded characters. Because…
Bounds-check rewrite in URL decoder to prevent out-of-bounds reads before percent-decodingCast to unsigned char moved into isxdigit() to avoid undefined behavior with signed char inputsDestination bounds checks in URL encoder changed from pointer-subtraction form to remaining-space form, mitigating possible underflow/wrap
This commit fixes a bug in the Blockstream Jade hardware wallet's PSBT (Partially Signed Bitcoin Transaction) signing code. Previously, when the transaction's genesis block hash did not match the expected network, the code set an error mes…
Missing return in error path allows execution to continue after validation failureCross-network genesis hash mismatch not enforced as a hard failurePSBT signing logic accepts mismatched network parameters
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-priorityusb: avoid memory allocations for ota chunk databy Jon Griffiths · f0ebdd09 · Oct 23, 2025 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: avoid memory allocations for ota chunk data
Prevents fragmentation.
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: refactor the ota data loopby Jon Griffiths · e260f656 · Oct 23, 2025 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · Jon Griffiths
usb: refactor the ota data loop
- Allow parallelism by waiting on the previous data packet not the current one - Handle scenarios where the ota process stops responding to our messages - Clean up error handling to simplify the loop logic.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedusb: simplify handle_ota_reply logicby Jon Griffiths · 1e51b96c · Oct 23, 2025 · 1 fileMessage 35 · OpaqueTriage 0Details
Commit message · Jon Griffiths
usb: simplify handle_ota_reply logic
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
Lower-priorityusb: set event bits atomicallyby Jon Griffiths · 53bc9c8d · Oct 23, 2025 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: set event bits atomically
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: rename the interface mutex to reflect it is a mutexby Jon Griffiths · 25598dc3 · Oct 23, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: rename the interface mutex to reflect it is a mutex
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: don't hold the callback mutex during the callbackby Jon Griffiths · 21229c99 · Oct 23, 2025 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Jon Griffiths
usb: don't hold the callback mutex during the callback
Note that the callback is called via trigger_event() from a single thread only and so holding the mutex while calling it is pointless. If the callback triggers code which attempts to unset the callback (for example, during error handling), then this will deadlock.
Instead, use the mutex only to protect reading and writing the callback and context variables themselves.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Lower-priorityusb: delete impossible-to-reach codeby Jon Griffiths · d550d332 · Oct 23, 2025 · 1 fileMessage 45 · ThinTriage 0Details
Commit message · Jon Griffiths
usb: delete impossible-to-reach code
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-prioritydescriptor: early-reject descriptors with too many signersby Jon Griffiths · 72cc31db · Oct 23, 2025 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
descriptor: early-reject descriptors with too many signers
Reported-by: DARKNAVY <X@DarkNavyOrg>
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI review queuedtext fixesby Daniel Newton · 1f9b4b86 · Oct 22, 2025 · 2 filesMessage 0 · OpaqueTriage 0Details
Commit message · Daniel Newton
text fixes
0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
Lower-priorityusb: only set the usb connect activity when it is initially createdby Jon Griffiths · dfcb0fb1 · Oct 21, 2025 · 1 fileMessage 65 · AdequateTriage 0Details
Commit message · Jon Griffiths
usb: only set the usb connect activity when it is initially created
its already re-set for us after help is shown.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityUpdate readme to show all dependencies needed to run test_jade.pyby Daniel Newton · 24deb001 · Oct 20, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
Update readme to show all dependencies needed to run test_jade.py
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
Lower-priorityusb: increase timeout to detect slower usb storage devicesby Daniel Newton · 1ff0e587 · Oct 15, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
usb: increase timeout to detect slower usb storage devices
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: remove need to unplug usb storage device to finish unloading usb libsby Daniel Newton · e48b0146 · Oct 15, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
usb: remove need to unplug usb storage device to finish unloading usb libs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: dont create background task for msc_host_installby Daniel Newton · ea5b2fd7 · Oct 15, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
usb: dont create background task for msc_host_install
Eliminates the "Processing..." freeze.
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityusb: add visual logging system to usb storage code for debuggingby Daniel Newton · 9e7f4ba3 · Oct 15, 2025 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
usb: add visual logging system to usb storage code for debugging
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidatebuild: further verify signature digests in signed v2 binariesby Jon Griffiths · 690c8b1c · Oct 14, 2025 · 1 fileMessage 77 · AdequateLow 42Details
Commit message · Jon Griffiths
build: further verify signature digests in signed v2 binaries
77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Low 42/100
This change tightens a build-time signing script for Blockstream Jade hardware wallet firmware. It adds checks that the public-key digests recorded inside a signed binary match the digests of the keys that were actually used to sign it, and makes the script stop on any error. The patch is defensive: it reduces the chance that a corrupted or wrongly-signed firmware image is produced during release, but it does not by itself fix a vulnerability in already-shipped devices.
Security candidatebuild: minor error handling tweak for v2 pem signingby Jon Griffiths · 1d797de3 · Oct 12, 2025 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Jon Griffiths
build: minor error handling tweak for v2 pem signing
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This is a tiny build-script change that replaces a silent failure with a clear error message when required signing key files are missing. It does not change what the script does, only what it prints when it fails. There is no security vulnerability here.
AI review queuedgui: include semphr.hby Jon Griffiths · 6de067ff · Oct 9, 2025 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Jon Griffiths
gui: include semphr.h
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
Lower-prioritycbor: avoid passing null to memcpy with len 0 in tinycborby Jon Griffiths · 22af7035 · Oct 8, 2025 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · Jon Griffiths
cbor: avoid passing null to memcpy with len 0 in tinycbor
Found by asan.
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Security candidateotp: avoid signed left shiftby Jon Griffiths · 7c8fd718 · Oct 8, 2025 · 1 fileMessage 45 · ThinLow 32Details
Commit message · Jon Griffiths
otp: avoid signed left shift
Found by ubsan.
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 32/100
This commit fixes a subtle programming bug in the code that decodes base32 one-time-password (OTP) secrets. The bug involves shifting a signed integer left, which is undefined behavior in C and was caught by an undefined-behavior sanitizer. The fix changes the variable from a signed integer to an unsigned integer so the shift is well-defined. The practical security impact is likely low, but undefined behavior in cryptographic/OTP handling is generally undesirable because compilers may optimize it unpredictably.
Lower-prioritychange QR scan box to use the largest centered square of the camera image (minus a small margin)by Daniel Newton · 719fa40c · Oct 7, 2025 · 3 filesMessage 50 · ThinTriage 0Details
Commit message · Daniel Newton
change QR scan box to use the largest centered square of the camera image (minus a small margin)
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
authentication path
AI analysis · Low 25/100
This commit simply updates a dependency called 'wallycore' used by the Blockstream Jade PIN server from version 1.4.0 to 1.5.1. It changes the version number and the list of cryptographic fingerprints (hashes) that verify the downloaded package. The commit message does not say why the update was made or whether it fixes any security issue. Without knowing what changed between 1.4.0 and 1.5.1, we cannot tell if this is a routine maintenance update or a security fix.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 30/100
This commit lets a Blockstream Jade hardware wallet automatically detect whether a transaction file is for Bitcoin or the Liquid sidechain (including test networks) when signing via QR codes or USB. Before, the wallet always assumed Bitcoin, which could cause it to fail or behave incorrectly when signing a Liquid transaction through those offline methods. The change itself is a feature fix and does not appear to introduce a security vulnerability.
Lower-priorityqr: Show brightness controls when displaying animated qrcodesby Jon Griffiths · b9cc4c24 · Sep 29, 2025 · 4 filesMessage 65 · AdequateTriage 0Details
Commit message · Jon Griffiths
qr: Show brightness controls when displaying animated qrcodes
Simplify the associated code since we no longer display a help button outside of the options section.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Lower-priorityqr: display the parent activity help when showing qr display optionsby Jon Griffiths · 7cb95d4a · Sep 29, 2025 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Jon Griffiths
qr: display the parent activity help when showing qr display options
Previously this would show help for blkstrm.com/scanjade - which is not useful when the user is displaying (and not scanning) a qrcode.
Instead, show the help associated with the parent activity where the options button was selected from.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context