Fix M5StickC Plus 2 PIN navigation
What the developer wrote
Authored by roderico
Fix M5StickC Plus 2 PIN navigation
What changed, and why it matters
This commit fixes a user-interface navigation quirk on the M5StickC Plus 2 hardware for Blockstream Jade. When entering a PIN, the up/down button directions were not inverted to match the rest of the device's menus, making number entry confusing or inconsistent. There is no security vulnerability here—just a UI consistency bug.
No security action needed. Treat as a normal UI/UX fix. If validating the change, test PIN navigation on an M5StickC Plus 2 to confirm up/down direction matches other menus.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change adds the M5StickC Plus 2 board (CONFIG_BOARD_TYPE_M5_STICKC_PLUS_2) to the existing conditional that inverts digit-entry navigation on TTGO boards. This ensures the PIN entry screen behaves consistently with the rest of the UI on this hardware variant. It is a one-line logical addition with no cryptographic, authentication, or memory-safety implications.
Changed components
main/ui/digit_entry.cM5StickC Plus 2 PIN entry UIInspect captured patch +3 / −2
diff --git a/main/ui/digit_entry.c b/main/ui/digit_entry.c
index b152112..c6e2ee8 100644
--- a/main/ui/digit_entry.c
+++ b/main/ui/digit_entry.c
@@ -12,8 +12,9 @@ static const char ENTRY_CHARS[] = { '0', '1', '2', '3', '4', '5', '6', '7', '8',
static inline bool entry_invert_navigation(void)
{
-#if defined(CONFIG_BOARD_TYPE_TTGO_TDISPLAY) || defined(CONFIG_BOARD_TYPE_TTGO_TDISPLAYS3)
- // TTGO boards need to locally invert navigation so number entry matches the rest of the UI.
+#if defined(CONFIG_BOARD_TYPE_TTGO_TDISPLAY) || defined(CONFIG_BOARD_TYPE_TTGO_TDISPLAYS3) \
+ || defined(CONFIG_BOARD_TYPE_M5_STICKC_PLUS_2)
+ // These boards need to locally invert navigation so number entry matches the rest of the UI.
return true;
#else
return false;
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.