What changed, and why it matters
This commit is a routine cleanup with no apparent security relevance. It merges two separate conditions for ARM and RISC-V into one, fixes a punctuation typo in the README, and removes the HAVE_ROTR compiler flag from ARM builds. There is no indication of a vulnerability being fixed.
No security action required. Treat as normal maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies three build/documentation files. CMakeLists.txt now adds CryptoNight_arm.h for both ARM and RISC-V targets via a single OR condition. README.md corrects a comma to a slash in the CPU backend list. cmake/flags.cmake removes add_definitions(-DHAVE_ROTR) for ARMv7/ARMv8 under GCC and Clang (and removes an Apple-specific guard for Clang/ARMv8). No source code logic changes are present, and no security issue is described.
Changed components
CMakeLists.txtREADME.mdcmake/flags.cmakeInspect captured patch +2 / −10
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ff76048..4b36a8d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -95,9 +95,7 @@ set(HEADERS_CRYPTO
src/crypto/common/VirtualMemory.h
)
-if (XMRIG_ARM)
- set(HEADERS_CRYPTO "${HEADERS_CRYPTO}" src/crypto/cn/CryptoNight_arm.h)
-elseif (XMRIG_RISCV)
+if (XMRIG_ARM OR XMRIG_RISCV)
set(HEADERS_CRYPTO "${HEADERS_CRYPTO}" src/crypto/cn/CryptoNight_arm.h)
else()
set(HEADERS_CRYPTO "${HEADERS_CRYPTO}" src/crypto/cn/CryptoNight_x86.h)
diff --git a/README.md b/README.md
index a6f4c35..7b6e66c 100644
--- a/README.md
+++ b/README.md
@@ -10,7 +10,7 @@
XMRig is a high performance, open source, cross platform RandomX, KawPow, CryptoNight and [GhostRider](https://github.com/xmrig/xmrig/tree/master/src/crypto/ghostrider#readme) unified CPU/GPU miner and [RandomX benchmark](https://xmrig.com/benchmark). Official binaries are available for Windows, Linux, macOS and FreeBSD.
## Mining backends
-- **CPU** (x86/x64/ARMv7/ARMv8,RISC-V)
+- **CPU** (x86/x64/ARMv7/ARMv8/RISC-V)
- **OpenCL** for AMD GPUs.
- **CUDA** for NVIDIA GPUs via external [CUDA plugin](https://github.com/xmrig/xmrig-cuda).
diff --git a/cmake/flags.cmake b/cmake/flags.cmake
index c33369c..3b711ac 100644
--- a/cmake/flags.cmake
+++ b/cmake/flags.cmake
@@ -25,11 +25,9 @@ if (CMAKE_CXX_COMPILER_ID MATCHES GNU)
if (ARM_TARGET EQUAL 8)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${ARM8_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARM8_CXX_FLAGS} -flax-vector-conversions")
- add_definitions(-DHAVE_ROTR)
elseif (ARM_TARGET EQUAL 7)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -march=armv7-a -mfpu=neon -flax-vector-conversions")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=armv7-a -mfpu=neon -flax-vector-conversions")
- add_definitions(-DHAVE_ROTR)
elseif (XMRIG_RISCV)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -march=${RVARCH}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=${RVARCH}")
@@ -78,13 +76,9 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES Clang)
if (ARM_TARGET EQUAL 8)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${ARM8_CXX_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARM8_CXX_FLAGS}")
- if (NOT APPLE)
- add_definitions(-DHAVE_ROTR)
- endif()
elseif (ARM_TARGET EQUAL 7)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -mfpu=neon -march=${CMAKE_SYSTEM_PROCESSOR}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mfpu=neon -march=${CMAKE_SYSTEM_PROCESSOR}")
- add_definitions(-DHAVE_ROTR)
elseif (XMRIG_RISCV)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -march=${RVARCH}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -march=${RVARCH}")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.