What the developer wrote
Authored by Ondřej Vejpustek
style(core): make style consistent
[no changelog]
What changed, and why it matters
This commit only removes or rearranges blank lines in two C source files to make the code style consistent. No program logic, function calls, variable handling, or security behavior was changed.
No security action needed; this is a non-functional style change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is purely cosmetic whitespace cleanup in smcall_dispatch.c and syscall_dispatch.c. It deletes extra blank lines inside case blocks for SMCALL_TROPIC_ECC_KEY_GENERATE, SMCALL_TROPIC_ECC_SIGN, SYSCALL_TROPIC_ECC_KEY_GENERATE, and SYSCALL_TROPIC_ECC_SIGN. No tokens, types, arguments, or control flow were modified.
Changed components
core/embed/sys/smcall/stm32/smcall_dispatch.ccore/embed/sys/syscall/stm32/syscall_dispatch.cInspect captured patch +2 / −6
diff --git a/core/embed/sys/smcall/stm32/smcall_dispatch.c b/core/embed/sys/smcall/stm32/smcall_dispatch.c
index 4ad326fa6..8ed9ecd29 100644
--- a/core/embed/sys/smcall/stm32/smcall_dispatch.c
+++ b/core/embed/sys/smcall/stm32/smcall_dispatch.c
@@ -325,18 +325,16 @@ __attribute((no_stack_protector)) void smcall_handler(uint32_t *args,
case SMCALL_TROPIC_ECC_KEY_GENERATE: {
uint16_t slot_index = (uint16_t)args[0];
args[0] = tropic_ecc_key_generate__verified(slot_index);
-
} break;
+
case SMCALL_TROPIC_ECC_SIGN: {
uint16_t key_slot_index = (uint16_t)args[0];
const uint8_t *dig = (const uint8_t *)args[1];
uint16_t dig_len = (uint16_t)args[2];
uint8_t *sig = (uint8_t *)args[3];
uint16_t sig_len = (uint16_t)args[4];
-
args[0] =
tropic_ecc_sign__verified(key_slot_index, dig, dig_len, sig, sig_len);
-
} break;
#endif
diff --git a/core/embed/sys/syscall/stm32/syscall_dispatch.c b/core/embed/sys/syscall/stm32/syscall_dispatch.c
index 8dbe4d499..b4ff882af 100644
--- a/core/embed/sys/syscall/stm32/syscall_dispatch.c
+++ b/core/embed/sys/syscall/stm32/syscall_dispatch.c
@@ -866,18 +866,16 @@ __attribute((no_stack_protector)) void syscall_handler(uint32_t *args,
case SYSCALL_TROPIC_ECC_KEY_GENERATE: {
uint16_t slot_index = (uint16_t)args[0];
args[0] = tropic_ecc_key_generate__verified(slot_index);
-
} break;
+
case SYSCALL_TROPIC_ECC_SIGN: {
uint16_t key_slot_index = (uint16_t)args[0];
const uint8_t *dig = (const uint8_t *)args[1];
uint16_t dig_len = (uint16_t)args[2];
uint8_t *sig = (uint8_t *)args[3];
uint16_t sig_len = (uint16_t)args[4];
-
args[0] =
tropic_ecc_sign__verified(key_slot_index, dig, dig_len, sig, sig_len);
-
} break;
#endif
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.