What the developer wrote
Authored by Martin Milata
ci(rust): propagate unit test failure
[no changelog]
What changed, and why it matters
This commit fixes a CI build script so that Rust test, style-check, and lint failures are properly reported. It does not change any firmware code or fix a security vulnerability in the product itself.
No security action required. Treat as a normal CI hygiene improvement.
Security signals we found
No security-relevant code changes
CI/Makefile script behavior change only
No changelog entry requested by commit author
Evidence from the diff
The change adds set -e to three Makefile targets (style_check, clippy, test) in rust/Makefile. Previously, because each loop iteration ran in a subshell without set -e, a failing command inside the subshell would not propagate its exit status, causing CI to continue and potentially report success even when tests or checks failed. This is a CI reliability fix, not a runtime security fix.
Changed components
rust/MakefileInspect captured patch +3 / −3
diff --git a/rust/Makefile b/rust/Makefile
index 2d6ab389..4a4ca221 100644
--- a/rust/Makefile
+++ b/rust/Makefile
@@ -12,21 +12,21 @@ style:
); done
style_check:
- @for D in $(CRATES); do ( \
+ @set -e; for D in $(CRATES); do ( \
echo "[STYLE_CHECK $$D]"; \
cd $$D; \
cargo fmt -- --check \
); done
clippy:
- @for D in $(CRATES); do ( \
+ @set -e; for D in $(CRATES); do ( \
echo "[CLIPPY $$D]"; \
cd $$D; \
cargo clippy \
); done
test:
- @for D in $(CRATES_TEST); do ( \
+ @set -e; for D in $(CRATES_TEST); do ( \
echo "[TEST $$D]"; \
cd $$D; \
cargo test \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.