What the developer wrote
Authored by Ioan Bizău
fix: make default consistent
[no changelog]
What changed, and why it matters
This commit changes the default value of an optional UI parameter called `info` from `True` to `False` in a function that displays confirmation screens on Trezor hardware wallets. The change only affects documentation-style comments and a generated mock file, making the documented default match the actual implementation. There is no direct evidence this fixes a security vulnerability.
Treat as a low-risk documentation/consistency fix. If the `info` parameter controls display of additional information on confirmation screens, verify that callers relying on the old default were updated and that the intended runtime behavior is unchanged. No urgent security action is warranted based solely on this diff.
Security signals we found
Default parameter value changed from True to False in UI confirmation API
Change is limited to comments/type stubs; no executable code diff shown
No changelog entry suggests minor/internal fix
Evidence from the diff
The patch updates the docstring/default annotation for confirm_value() in firmware_micropython.rs and the corresponding generated stub in trezorui_api.pyi. The info: bool parameter default is changed from True to False. This is a consistency fix between the Rust module’s documented interface and the generated Python type stub. No runtime code logic is modified in the visible diff.
Changed components
core/embed/rust/src/ui/api/firmware_micropython.rscore/mocks/generated/trezorui_api.pyiTrezor UI confirmation flow (confirm_value API)Inspect captured patch +2 / −2
diff --git a/core/embed/rust/src/ui/api/firmware_micropython.rs b/core/embed/rust/src/ui/api/firmware_micropython.rs
index 7aab0407..361c3b0f 100644
--- a/core/embed/rust/src/ui/api/firmware_micropython.rs
+++ b/core/embed/rust/src/ui/api/firmware_micropython.rs
@@ -1536,7 +1536,7 @@ pub static mp_module_trezorui_api: Module = obj_module! {
/// subtitle: str | None = None,
/// verb: str | None = None,
/// verb_cancel: str | None = None,
- /// info: bool = True,
+ /// info: bool = False,
/// hold: bool = False,
/// chunkify: bool = False,
/// page_counter: bool = False,
diff --git a/core/mocks/generated/trezorui_api.pyi b/core/mocks/generated/trezorui_api.pyi
index 44e10a1f..09b2cbb2 100644
--- a/core/mocks/generated/trezorui_api.pyi
+++ b/core/mocks/generated/trezorui_api.pyi
@@ -161,7 +161,7 @@ def confirm_value(
subtitle: str | None = None,
verb: str | None = None,
verb_cancel: str | None = None,
- info: bool = True,
+ info: bool = False,
hold: bool = False,
chunkify: bool = False,
page_counter: bool = False,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.