AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

fix(core): avoid failing ButtonRequest handling at `ContinueOnErrors`

Public commit record

What the developer wrote

Authored by Roman Zeyde

85/100 · Strong
fix(core): avoid failing ButtonRequest handling at `ContinueOnErrors`

No more button requests / errors will be sent later during
the backup workflow after an I/O-related error/timeout.

Host will be ignored until the backup workflow is over -
sending the final "Success" response may fail.

Other workflows can be aborted after user cancellation via `_waiting_screen()`.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This update fixes a bug in how the Trezor device handles on-screen button prompts when communication with the host computer hits errors or timeouts. Previously, an input/output problem during a backup could cause the device to send extra button requests or errors after the workflow should have ended, and the final 'Success' message could fail to send. The fix makes the device ignore further host messages until the backup workflow finishes, and lets users cancel other workflows through a new waiting screen. It is a reliability and defensive fix rather than a clear-cut remote exploit.

Recommended action

Treat as a defensive reliability fix. Review whether the new 'ignore host' behavior in ContinueOnErrors could be abused to keep a workflow alive longer than intended, and verify that the final Success write failure path does not leak sensitive state. No immediate emergency response is indicated by the diff alone.

Security signals we found

01

Prevents desynchronization of THP channel due to late ButtonRequest/Failure traffic after I/O errors

02

Disables host-side cancellation of a backup workflow once an unexpected error occurs

03

Adds user-visible 'communication trouble' warning with optional abort for other workflows

04

Changes ContinueOnErrors to swallow unexpected exceptions and stop processing further ButtonRequests

05

Changelog describes the fix as avoiding backup flow failure on I/O errors

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 7/15
Affected reach 8/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.