fix(tests): skip test on "THP" instead of on "eckhart"
What the developer wrote
Authored by M1nd3r
fix(tests): skip test on "THP" instead of on "eckhart"
- Skipped `test_apply_homescreen_jpeg_single_message` on all devices with THP, as the message is too big for the protocol.
[no changelog]
What changed, and why it matters
This commit only changes a test file. It adjusts which hardware models and protocol versions skip a test that sends a large JPEG homescreen image in a single message. The change is not a fix to product firmware and does not address a security vulnerability.
No security action needed. This is a test-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies tests/device_tests/test_msg_applysettings.py. It replaces skipping the test on the ‘eckhart’ model with marking the test to run only on protocol v1. The commit message explains that the single-message JPEG test is too big for the THP (Trezor Host Protocol), so it should be skipped on all THP devices rather than specifically on ‘eckhart’. This is a test-suite adjustment with no firmware code changes.
Changed components
tests/device_tests/test_msg_applysettings.pyInspect captured patch +2 / −1
diff --git a/tests/device_tests/test_msg_applysettings.py b/tests/device_tests/test_msg_applysettings.py
index 5984655e..ff8a51bc 100644
--- a/tests/device_tests/test_msg_applysettings.py
+++ b/tests/device_tests/test_msg_applysettings.py
@@ -249,7 +249,8 @@ def test_apply_homescreen_jpeg(session: Session):
device.apply_settings(session, homescreen=b"")
-@pytest.mark.models(skip=["legacy", "safe3", "eckhart"])
+@pytest.mark.models(skip=["legacy", "safe3"])
+@pytest.mark.protocol("v1")
def test_apply_homescreen_jpeg_single_message(session: Session):
with open(homescreen_jpeg_path(session.debug.layout_type), "rb") as f:
img = f.read()
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.