← Watch feed
chore(core): adjust JYH battery definition file for usage in a dynamically selected battery model
Public commit record
62/100 · Adequate
What the developer wrote
Authored by tychovrahe
chore(core): adjust JYH battery definition file for usage in a dynamically selected battery model
[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
What changed, and why it matters
This commit is a routine code cleanup that renames battery-related constants and arrays in a Trezor firmware header file to include the specific battery model name (JYHPFL333838). No values were changed, no new functionality was added, and there is no indication of any security issue being fixed.
Recommended action
No security action required. This is a non-functional refactoring change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff shows only symbol renaming in core/embed/sys/power_manager/fuel_gauge/battery_data_jyhpfl333838.h. All identifiers previously prefixed with BATTERY_ are now prefixed with BATTERY_JYHPFL333838_ to support dynamic battery model selection. The numeric coefficients, array dimensions, and data structure remain identical. No logic changes are present.
Changed components
core/embed/sys/power_manager/fuel_gauge/battery_data_jyhpfl333838.hInspect captured patch +198 / −193
diff --git a/core/embed/sys/power_manager/fuel_gauge/battery_data_jyhpfl333838.h b/core/embed/sys/power_manager/fuel_gauge/battery_data_jyhpfl333838.h
index 303c61945..5dd8073bd 100644
--- a/core/embed/sys/power_manager/fuel_gauge/battery_data_jyhpfl333838.h
+++ b/core/embed/sys/power_manager/fuel_gauge/battery_data_jyhpfl333838.h
@@ -34,214 +34,219 @@
*/
// Configuration
-#define BATTERY_NUM_TEMP_POINTS 10
+#define BATTERY_JYHPFL333838_NUM_TEMP_POINTS 10
// SOC breakpoints for piecewise functions
-#define BATTERY_SOC_BREAKPOINT_1 0.25f
-#define BATTERY_SOC_BREAKPOINT_2 0.8f
+#define BATTERY_JYHPFL333838_SOC_BREAKPOINT_1 0.25f
+#define BATTERY_JYHPFL333838_SOC_BREAKPOINT_2 0.8f
// Temperature points arrays (in Celsius)
// Discharge temperatures
-static const float BATTERY_TEMP_POINTS_DISCHG[BATTERY_NUM_TEMP_POINTS] = {
- 0.80f, 5.78f, 10.64f, 15.55f, 20.65f,
- 25.43f, 31.41f, 35.41f, 40.38f, 45.28f};
+static const float BATTERY_JYHPFL333838_TEMP_POINTS_DISCHG
+ [BATTERY_JYHPFL333838_NUM_TEMP_POINTS] = {0.80f, 5.78f, 10.64f, 15.55f,
+ 20.65f, 25.43f, 31.41f, 35.41f,
+ 40.38f, 45.28f};
// Charge temperatures
-static const float BATTERY_TEMP_POINTS_CHG[BATTERY_NUM_TEMP_POINTS] = {
- 2.32f, 7.28f, 12.60f, 17.51f, 22.50f,
- 27.38f, 32.31f, 37.36f, 42.34f, 47.37f};
+static const float
+ BATTERY_JYHPFL333838_TEMP_POINTS_CHG[BATTERY_JYHPFL333838_NUM_TEMP_POINTS] =
+ {2.32f, 7.28f, 12.60f, 17.51f, 22.50f,
+ 27.38f, 32.31f, 37.36f, 42.34f, 47.37f};
// Internal resistance curve parameters (rational function parameters
// a+b*t)/(c+d*t)
-static const float BATTERY_R_INT_PARAMS[4] = {
+static const float BATTERY_JYHPFL333838_R_INT_PARAMS[4] = {
// a, b, c, d for rational function (a + b*t)/(c + d*t)
3.700987f, 0.063115f, 4.059870f, 0.273364f};
// Discharge OCV curve parameters for each temperature
-static const float BATTERY_OCV_DISCHARGE_PARAMS[BATTERY_NUM_TEMP_POINTS][10] = {
- // Temperature: 0.80°C (key: 0)
- {
- 0.126550f, 3.211777f, // m, b (linear segment)
- 19.098931f, 149.532130f, 6.226951f,
- 44.749610f, // a1, b1, c1, d1 (first rational segment)
- 1209.541847f, -1204.643391f, 365.238423f,
- -363.797538f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 5.78°C (key: 5)
- {
- 0.118854f, 3.221712f, // m, b (linear segment)
- 510.794524f, 4147.718053f, 167.121531f,
- 1235.569720f, // a1, b1, c1, d1 (first rational segment)
- 2461.131197f, -2454.069820f, 742.268667f,
- -740.201672f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 10.64°C (key: 10)
- {
- 0.116679f, 3.228096f, // m, b (linear segment)
- 4.902604f, 39.346060f, 1.602605f,
- 11.689570f, // a1, b1, c1, d1 (first rational segment)
- 1195.141551f, -1192.318620f, 359.914069f,
- -359.086078f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 15.55°C (key: 15)
- {
- 0.114185f, 3.232650f, // m, b (linear segment)
- 60.048245f, 556.913282f, 19.591820f,
- 166.054156f, // a1, b1, c1, d1 (first rational segment)
- 3200.736593f, -3191.682291f, 963.249686f,
- -960.608735f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 20.65°C (key: 20)
- {
- 0.114688f, 3.233887f, // m, b (linear segment)
- 62.865854f, 711.447068f, 20.495367f,
- 213.158188f, // a1, b1, c1, d1 (first rational segment)
- 1180.804882f, -1178.074609f, 355.167808f,
- -354.373464f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 25.43°C (key: 25)
- {
- 0.117543f, 3.236008f, // m, b (linear segment)
- 78.102339f, 1077.942159f, 25.484299f,
- 323.846567f, // a1, b1, c1, d1 (first rational segment)
- 1130.318095f, -1127.865886f, 339.544458f,
- -338.836536f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 31.41°C (key: 30)
- {
- 0.117363f, 3.238875f, // m, b (linear segment)
- 88.813605f, 1434.949559f, 29.026877f,
- 431.654409f, // a1, b1, c1, d1 (first rational segment)
- 2953.178047f, -2947.773461f, 886.333650f,
- -884.769279f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 35.41°C (key: 35)
- {
- 0.123731f, 3.236223f, // m, b (linear segment)
- 129.239103f, 2182.616715f, 42.262528f,
- 657.226142f, // a1, b1, c1, d1 (first rational segment)
- 4774.132278f, -4767.725320f, 1431.719239f,
- -1429.869351f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 40.38°C (key: 40)
- {
- 0.123696f, 3.237016f, // m, b (linear segment)
- 221.044970f, 3715.383819f, 72.272903f,
- 1118.389323f, // a1, b1, c1, d1 (first rational segment)
- -4039.944265f, 4034.063152f, -1211.294227f,
- 1209.598810f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 45.28°C (key: 45)
- {
- 0.125006f, 3.235912f, // m, b (linear segment)
- 151.467401f, 2582.526900f, 49.550052f,
- 777.691108f, // a1, b1, c1, d1 (first rational segment)
- 1112.445343f, -1110.999778f, 333.537185f,
- -333.119361f // a3, b3, c3, d3 (third rational segment)
- }};
+static const float BATTERY_JYHPFL333838_OCV_DISCHARGE_PARAMS
+ [BATTERY_JYHPFL333838_NUM_TEMP_POINTS][10] = {
+ // Temperature: 0.80°C (key: 0)
+ {
+ 0.126550f, 3.211777f, // m, b (linear segment)
+ 19.098931f, 149.532130f, 6.226951f,
+ 44.749610f, // a1, b1, c1, d1 (first rational segment)
+ 1209.541847f, -1204.643391f, 365.238423f,
+ -363.797538f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 5.78°C (key: 5)
+ {
+ 0.118854f, 3.221712f, // m, b (linear segment)
+ 510.794524f, 4147.718053f, 167.121531f,
+ 1235.569720f, // a1, b1, c1, d1 (first rational segment)
+ 2461.131197f, -2454.069820f, 742.268667f,
+ -740.201672f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 10.64°C (key: 10)
+ {
+ 0.116679f, 3.228096f, // m, b (linear segment)
+ 4.902604f, 39.346060f, 1.602605f,
+ 11.689570f, // a1, b1, c1, d1 (first rational segment)
+ 1195.141551f, -1192.318620f, 359.914069f,
+ -359.086078f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 15.55°C (key: 15)
+ {
+ 0.114185f, 3.232650f, // m, b (linear segment)
+ 60.048245f, 556.913282f, 19.591820f,
+ 166.054156f, // a1, b1, c1, d1 (first rational segment)
+ 3200.736593f, -3191.682291f, 963.249686f,
+ -960.608735f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 20.65°C (key: 20)
+ {
+ 0.114688f, 3.233887f, // m, b (linear segment)
+ 62.865854f, 711.447068f, 20.495367f,
+ 213.158188f, // a1, b1, c1, d1 (first rational segment)
+ 1180.804882f, -1178.074609f, 355.167808f,
+ -354.373464f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 25.43°C (key: 25)
+ {
+ 0.117543f, 3.236008f, // m, b (linear segment)
+ 78.102339f, 1077.942159f, 25.484299f,
+ 323.846567f, // a1, b1, c1, d1 (first rational segment)
+ 1130.318095f, -1127.865886f, 339.544458f,
+ -338.836536f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 31.41°C (key: 30)
+ {
+ 0.117363f, 3.238875f, // m, b (linear segment)
+ 88.813605f, 1434.949559f, 29.026877f,
+ 431.654409f, // a1, b1, c1, d1 (first rational segment)
+ 2953.178047f, -2947.773461f, 886.333650f,
+ -884.769279f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 35.41°C (key: 35)
+ {
+ 0.123731f, 3.236223f, // m, b (linear segment)
+ 129.239103f, 2182.616715f, 42.262528f,
+ 657.226142f, // a1, b1, c1, d1 (first rational segment)
+ 4774.132278f, -4767.725320f, 1431.719239f,
+ -1429.869351f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 40.38°C (key: 40)
+ {
+ 0.123696f, 3.237016f, // m, b (linear segment)
+ 221.044970f, 3715.383819f, 72.272903f,
+ 1118.389323f, // a1, b1, c1, d1 (first rational segment)
+ -4039.944265f, 4034.063152f, -1211.294227f,
+ 1209.598810f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 45.28°C (key: 45)
+ {
+ 0.125006f, 3.235912f, // m, b (linear segment)
+ 151.467401f, 2582.526900f, 49.550052f,
+ 777.691108f, // a1, b1, c1, d1 (first rational segment)
+ 1112.445343f, -1110.999778f, 333.537185f,
+ -333.119361f // a3, b3, c3, d3 (third rational segment)
+ }};
// Charge OCV curve parameters for each temperature
-static const float BATTERY_OCV_CHARGE_PARAMS[BATTERY_NUM_TEMP_POINTS][10] = {
- // Temperature: 2.32°C (key: 0)
- {
- 0.133654f, 3.292145f, // m, b (linear segment)
- 2424.212366f, 87282.185143f, 753.227933f,
- 26148.817273f, // a1, b1, c1, d1 (first rational segment)
- -20885.884413f, 19421.324650f, -6263.752097f,
- 5862.671202f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 7.28°C (key: 5)
- {
- 0.119964f, 3.293413f, // m, b (linear segment)
- 2732.271006f, 75783.249716f, 850.221080f,
- 22690.534179f, // a1, b1, c1, d1 (first rational segment)
- -4317.842520f, 4121.656010f, -1290.625974f,
- 1236.917022f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 12.60°C (key: 10)
- {
- 0.129891f, 3.273207f, // m, b (linear segment)
- 846.503340f, 15988.928725f, 265.726589f,
- 4798.200588f, // a1, b1, c1, d1 (first rational segment)
- -60068.019107f, 55820.453762f, -18158.693048f,
- 16993.928616f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 17.51°C (key: 15)
- {
- 0.115653f, 3.274031f, // m, b (linear segment)
- 237.696958f, 1964.826751f, 74.429637f,
- 585.013431f, // a1, b1, c1, d1 (first rational segment)
- 968.862408f, -935.338129f, 290.869232f,
- -281.680851f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 22.50°C (key: 20)
- {
- 0.118277f, 3.272331f, // m, b (linear segment)
- -26.011330f, -198.086479f, -8.180144f,
- -58.781818f, // a1, b1, c1, d1 (first rational segment)
- 983.725464f, -950.493228f, 295.209174f,
- -286.098635f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 27.38°C (key: 25)
- {
- 0.111950f, 3.273751f, // m, b (linear segment)
- -25.521502f, -274.597696f, -8.095046f,
- -81.706277f, // a1, b1, c1, d1 (first rational segment)
- 1073.930068f, -1053.131703f, 321.219989f,
- -315.514254f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 32.31°C (key: 30)
- {
- 0.105879f, 3.276268f, // m, b (linear segment)
- 154.842986f, 1451.215812f, 48.865130f,
- 431.470258f, // a1, b1, c1, d1 (first rational segment)
- -3747.632139f, 3694.953159f, -1119.887101f,
- 1105.424025f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 37.36°C (key: 35)
- {
- 0.103781f, 3.277949f, // m, b (linear segment)
- 42.648170f, 582.113263f, 13.465663f,
- 173.961241f, // a1, b1, c1, d1 (first rational segment)
- 1109.000316f, -1096.490080f, 331.110598f,
- -327.675032f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 42.34°C (key: 40)
- {
- 0.105248f, 3.278675f, // m, b (linear segment)
- 86.330934f, 1157.715172f, 27.596520f,
- 344.393006f, // a1, b1, c1, d1 (first rational segment)
- 1018.218867f, -1006.960134f, 303.810937f,
- -300.720120f // a3, b3, c3, d3 (third rational segment)
- },
- // Temperature: 47.37°C (key: 45)
- {
- 0.102922f, 3.281457f, // m, b (linear segment)
- 133.236246f, 1680.463569f, 42.563832f,
- 499.016826f, // a1, b1, c1, d1 (first rational segment)
- 731.525161f, -722.630154f, 218.130924f,
- -215.651760f // a3, b3, c3, d3 (third rational segment)
- }};
+static const float BATTERY_JYHPFL333838_OCV_CHARGE_PARAMS
+ [BATTERY_JYHPFL333838_NUM_TEMP_POINTS][10] = {
+ // Temperature: 2.32°C (key: 0)
+ {
+ 0.133654f, 3.292145f, // m, b (linear segment)
+ 2424.212366f, 87282.185143f, 753.227933f,
+ 26148.817273f, // a1, b1, c1, d1 (first rational segment)
+ -20885.884413f, 19421.324650f, -6263.752097f,
+ 5862.671202f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 7.28°C (key: 5)
+ {
+ 0.119964f, 3.293413f, // m, b (linear segment)
+ 2732.271006f, 75783.249716f, 850.221080f,
+ 22690.534179f, // a1, b1, c1, d1 (first rational segment)
+ -4317.842520f, 4121.656010f, -1290.625974f,
+ 1236.917022f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 12.60°C (key: 10)
+ {
+ 0.129891f, 3.273207f, // m, b (linear segment)
+ 846.503340f, 15988.928725f, 265.726589f,
+ 4798.200588f, // a1, b1, c1, d1 (first rational segment)
+ -60068.019107f, 55820.453762f, -18158.693048f,
+ 16993.928616f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 17.51°C (key: 15)
+ {
+ 0.115653f, 3.274031f, // m, b (linear segment)
+ 237.696958f, 1964.826751f, 74.429637f,
+ 585.013431f, // a1, b1, c1, d1 (first rational segment)
+ 968.862408f, -935.338129f, 290.869232f,
+ -281.680851f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 22.50°C (key: 20)
+ {
+ 0.118277f, 3.272331f, // m, b (linear segment)
+ -26.011330f, -198.086479f, -8.180144f,
+ -58.781818f, // a1, b1, c1, d1 (first rational segment)
+ 983.725464f, -950.493228f, 295.209174f,
+ -286.098635f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 27.38°C (key: 25)
+ {
+ 0.111950f, 3.273751f, // m, b (linear segment)
+ -25.521502f, -274.597696f, -8.095046f,
+ -81.706277f, // a1, b1, c1, d1 (first rational segment)
+ 1073.930068f, -1053.131703f, 321.219989f,
+ -315.514254f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 32.31°C (key: 30)
+ {
+ 0.105879f, 3.276268f, // m, b (linear segment)
+ 154.842986f, 1451.215812f, 48.865130f,
+ 431.470258f, // a1, b1, c1, d1 (first rational segment)
+ -3747.632139f, 3694.953159f, -1119.887101f,
+ 1105.424025f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 37.36°C (key: 35)
+ {
+ 0.103781f, 3.277949f, // m, b (linear segment)
+ 42.648170f, 582.113263f, 13.465663f,
+ 173.961241f, // a1, b1, c1, d1 (first rational segment)
+ 1109.000316f, -1096.490080f, 331.110598f,
+ -327.675032f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 42.34°C (key: 40)
+ {
+ 0.105248f, 3.278675f, // m, b (linear segment)
+ 86.330934f, 1157.715172f, 27.596520f,
+ 344.393006f, // a1, b1, c1, d1 (first rational segment)
+ 1018.218867f, -1006.960134f, 303.810937f,
+ -300.720120f // a3, b3, c3, d3 (third rational segment)
+ },
+ // Temperature: 47.37°C (key: 45)
+ {
+ 0.102922f, 3.281457f, // m, b (linear segment)
+ 133.236246f, 1680.463569f, 42.563832f,
+ 499.016826f, // a1, b1, c1, d1 (first rational segment)
+ 731.525161f, -722.630154f, 218.130924f,
+ -215.651760f // a3, b3, c3, d3 (third rational segment)
+ }};
// Battery capacity data for each temperature
-static const float BATTERY_CAPACITY[BATTERY_NUM_TEMP_POINTS][2] = {
- // Temperature: 0.80°C (key: 0)
- {297.56f, 315.21f},
- // Temperature: 5.78°C (key: 5)
- {325.07f, 336.55f},
- // Temperature: 10.64°C (key: 10)
- {343.23f, 366.44f},
- // Temperature: 15.55°C (key: 15)
- {355.86f, 378.79f},
- // Temperature: 20.65°C (key: 20)
- {362.69f, 394.38f},
- // Temperature: 25.43°C (key: 25)
- {357.80f, 383.75f},
- // Temperature: 31.41°C (key: 30)
- {361.17f, 379.75f},
- // Temperature: 35.41°C (key: 35)
- {357.76f, 366.75f},
- // Temperature: 40.38°C (key: 40)
- {357.29f, 383.63f},
- // Temperature: 45.28°C (key: 45)
- {353.41f, 377.66f}};
+static const float
+ BATTERY_JYHPFL333838_CAPACITY[BATTERY_JYHPFL333838_NUM_TEMP_POINTS][2] = {
+ // Temperature: 0.80°C (key: 0)
+ {297.56f, 315.21f},
+ // Temperature: 5.78°C (key: 5)
+ {325.07f, 336.55f},
+ // Temperature: 10.64°C (key: 10)
+ {343.23f, 366.44f},
+ // Temperature: 15.55°C (key: 15)
+ {355.86f, 378.79f},
+ // Temperature: 20.65°C (key: 20)
+ {362.69f, 394.38f},
+ // Temperature: 25.43°C (key: 25)
+ {357.80f, 383.75f},
+ // Temperature: 31.41°C (key: 30)
+ {361.17f, 379.75f},
+ // Temperature: 35.41°C (key: 35)
+ {357.76f, 366.75f},
+ // Temperature: 40.38°C (key: 40)
+ {357.29f, 383.63f},
+ // Temperature: 45.28°C (key: 45)
+ {353.41f, 377.66f}};
Risk score
Our methodology →Why this scored 15/100
Human-validated context
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
No validated notes yet.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.