CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 23 Bitcoin

fix(core): set model variant in THP DeviceProperties

TZebf0d7c2 View source ↗
Public commit record

What the developer wrote

Authored by Martin Milata

62/100 · Adequate
fix(core): set model variant in THP DeviceProperties

[no changelog]
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit finishes a previously incomplete feature in Trezor's new wireless pairing protocol (THP). Before the fix, the device told the connecting computer/phone its model variant as 'None' (effectively blank). After the fix, it correctly reports the device's color, whether it is a Bitcoin-only edition, and its packaging type. This is mostly a correctness/functional fix, but an incorrect or missing model variant could in theory confuse host software during pairing or cause it to trust the wrong device identity. There is no direct evidence in the commit of an exploitable vulnerability.

Recommended action

Treat as a normal functional fix. Reviewers should confirm that model_variant values are consumed safely by host software and that no host-side logic misinterprets the new bitmask. No urgent security action is indicated by the diff alone.

Security signals we found

01

Previously hard-coded model_variant=None now populated with device-specific fields

02

Affects THP (Trezor Host Protocol) device identification during pairing

03

No input validation changes, no buffer/memory operations, no privilege changes

04

No changelog entry and no vendor security statement in commit

Risk score

Why this scored 23/100

Our methodology →
Potential impact 4/30
Exploitability 3/25
Stealth signal 2/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Trezor firmware

Related watches

Informational 15 AI analysisMessage 57 · Thin
TZ TrezorTrezor firmware BitcoinHardware wallets

chore: remove libtropic's pin to develop branch

This commit removes a single line from the project's Git submodule configuration. It stops pinning the libtropic submodule to the 'develop' branch, meaning the project will now use the submodule's default branch (likely 'main' or 'master')…

8290eeefby M1nd3r+0−11 file
No security note in commit
Open full analysis →Source commit ↗
Low 37 AI analysisMessage 70 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

chore(core/embed): clear temporary buffer across Optiga/Tropic calls

This is a hardening change for the random number generator inside Trezor hardware wallets. It makes sure that temporary memory holding secret random values from the Optiga and Tropic security chips is wiped immediately after use, rather th…

Sensitive intermediate buffer not cleared promptlyPotential stale-buffer reuse across RNG source boundariesDefense-in-depth memory sanitization for secure-element entropy
01ebda93by Roman Zeyde+2−21 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 72 · Adequate
TZ TrezorTrezor firmware BitcoinHardware wallets

test(core/ethereum): EIP-7702 tuple nonce must be non-zero

This commit only changes test data and expected screen fingerprints for Trezor's Ethereum EIP-7702 signing tests. It replaces one test case that used a nonce of 0 with the same scenario using a nonce of 67, because the real-world protocol …

Test-only change with no production code modificationEIP-7702 tuple nonce constraint reflected in test dataExpected UI test hashes regenerated for renamed test vector
76cd2ed4by Roman Zeyde+28−282 files
No security note in commit
Open full analysis →Source commit ↗