AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 57 Bitcoin

fix(core): fix device locking if only SD card protection is enabled

Public commit record

What the developer wrote

Authored by Roman Zeyde

77/100 · Adequate
fix(core): fix device locking if only SD card protection is enabled

(cherry picked from commit 5a123781d2fa463cf138b4ed97705237e7485434)
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
The short version

What changed, and why it matters

This update fixes a bug in Trezor hardware wallets where the device would not properly lock itself when only SD card protection was enabled and no PIN was set. In that configuration, an attacker with brief physical access could potentially keep the device unlocked and use it without needing to enter a PIN or provide the SD card secret, bypassing the intended security protection.

Recommended action

Apply this patch and ensure firmware builds for SD-card-capable models (T2T1/T3T1) include it. Run the new `test_sd_protect_lock` device tests to confirm the device locks correctly with SD-protect-only configurations. Consider auditing other authorization paths that may still assume PIN presence implies lockability.

Security signals we found

01

Bypass of device locking/autolock when only SD-card protection is enabled

02

Inconsistent authorization checks across lock_device, bootscreen, and homescreen

03

New regression test `test_sd_protect_lock` covers both session lock and auto-lock with PIN removed

04

Changelog entry explicitly labeled as a security fix (`265.security`)

05

Fix cherry-picked from another commit, indicating backport of a security-relevant change

Risk score

Why this scored 57/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 7/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.