What changed, and why it matters
This change is purely about how automated tests are run in the project's build system. It switches Rust unit tests to run through a helper tool called xtask and, as noted by the developer, temporarily disables those Rust unit tests in CI until a later update. There is no change to the actual wallet firmware code that users rely on, and no security vulnerability is introduced by this commit itself.
No security action required for this commit. Monitor the promised follow-up PR to ensure Rust unit tests are re-enabled in CI, since sustained loss of test coverage could eventually reduce assurance of firmware correctness.
Security signals we found
Commit message explicitly states Rust unit tests are disabled temporarily
No source code changes to firmware, crypto, or device logic
CI/build-system-only diff
Planned follow-up PR to re-enable tests
Evidence from the diff
The commit modifies CI workflow and Makefile targets for the Trezor core firmware. It replaces direct cargo build / Makefile.scons invocations with a unified make -C core test_rust that calls xtask test crypto. The commit message explicitly states this disables Rust unit tests in CI temporarily and that re-enabling them is planned in a follow-up PR. No firmware source code, cryptographic logic, or device behavior is changed.
Changed components
.github/workflows/core.ymlcore/MakefileInspect captured patch +3 / −9
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index ed0bd9c0..2487980d 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -277,13 +277,7 @@ jobs:
with:
submodules: recursive
- uses: ./.github/actions/environment
- - run: nix-shell --run "uv run make -C core -f Makefile.scons build_unix"
- # Ensure that "cargo build" works when NOT executed through our makefiles,
- # indicating that it does not rely on particular envvars or other flags.
- # This makes sure that rust-analyzer will work on our codebase.
- - run: nix-shell --run "cd core/embed/rust && cargo build"
- if: matrix.asan == 'noasan'
- - run: nix-shell --run "uv run make -C core -f Makefile.scons test_rust"
+ - run: nix-shell --run "uv run make -C core test_rust"
- run: nix-shell --run "uv run make -C core clippy"
core_rust_client_test:
diff --git a/core/Makefile b/core/Makefile
index 90f84a4b..7e8ee662 100644
--- a/core/Makefile
+++ b/core/Makefile
@@ -124,8 +124,8 @@ test: ## run unit tests
cd tests ; ./run_tests.sh $(TESTOPTS)
test_rust: ## run rs unit tests
- false # NOT IMPLEMENTED
- # xtask test crypto
+ xtask test crypto
+ # TODO:
# xtask test all
test_emu_sanity: ## make sure the emulator doesn't crash on startup
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.