fix(tests,eckhart): visit the whole flow
What the developer wrote
Authored by Ioan Bizău
fix(tests,eckhart): visit the whole flow
`press_yes` used to kill the flow so we would never visit the amount
screen.
[no changelog]
What changed, and why it matters
This is a minor test-only fix for the Trezor firmware test suite. It changes how a simulated user navigates through a device setup screen during automated testing so that the test visits an additional on-screen amount confirmation page. It does not change any production firmware code, cryptographic logic, or user-facing behavior, and there is no indication it fixes a security vulnerability.
No security action required. Treat as a normal test-quality fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies tests/input_flows.py in the lock_time_input_flow_eckhart test helper. Previously, debug.press_yes() advanced past the output confirmation and terminated the flow, so the subsequent amount screen was never reached. The patch replaces that single press_yes() with two debug.click(debug.screen_buttons.ok()) calls separated by yields, causing the test to visit the full expected flow. This is purely a test-automation correction; no firmware behavior is altered.
Changed components
tests/input_flows.pylock_time_input_flow_eckhart test helperInspect captured patch +4 / −1
diff --git a/tests/input_flows.py b/tests/input_flows.py
index 29b06662a..594173b56 100644
--- a/tests/input_flows.py
+++ b/tests/input_flows.py
@@ -1448,7 +1448,10 @@ def lock_time_input_flow_eckhart(
) -> BRGeneratorType:
yield # confirm output
debug.read_layout()
- debug.press_yes()
+ debug.click(debug.screen_buttons.ok())
+ yield # confirm output
+ debug.read_layout()
+ debug.click(debug.screen_buttons.ok())
br = yield # confirm locktime
layout_assert_func(debug, br)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.