What the developer wrote
Authored by Lukas Bielesch
fix(core/tests): wrong eckhart action
What changed, and why it matters
This commit fixes a test script, not the actual Trezor firmware. The test was performing the wrong on-screen action for a newer Trezor model (Eckhart) when simulating a user cancelling a backup. It now clicks the cancel button instead of navigating through a menu. This is a test-only correction and does not change device security.
No security action needed. This is a routine test-maintenance fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In tests/click_tests/reset.py, the cancel_backup helper for LayoutType.Eckhart previously always opened the menu, navigated to item 0, and clicked OK. The fix branches on the confirm parameter: when confirm is true it keeps that menu flow, and when confirm is false it directly clicks the cancel button. This aligns the test automation with the actual UI flow for cancelling a backup on the Eckhart layout. No firmware code is modified.
Changed components
tests/click_tests/reset.pyInspect captured patch +6 / −3
diff --git a/tests/click_tests/reset.py b/tests/click_tests/reset.py
index 6fb84d593..2f982adde 100644
--- a/tests/click_tests/reset.py
+++ b/tests/click_tests/reset.py
@@ -65,9 +65,12 @@ def cancel_backup(
debug.swipe_up()
debug.click(debug.screen_buttons.tap_to_confirm())
elif debug.layout_type is LayoutType.Eckhart:
- debug.click(debug.screen_buttons.menu())
- debug.button_actions.navigate_to_menu_item(0)
- debug.click(debug.screen_buttons.ok())
+ if confirm:
+ debug.click(debug.screen_buttons.menu())
+ debug.button_actions.navigate_to_menu_item(0)
+ debug.click(debug.screen_buttons.ok())
+ else:
+ debug.click(debug.screen_buttons.cancel())
else:
raise RuntimeError("Unknown model")
debug.read_layout()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.