chore(python): remove an old helper script
What the developer wrote
Authored by Roman Zeyde
chore(python): remove an old helper script
[no changelog]
What changed, and why it matters
This commit simply deletes an old internal helper script that was used to update minimum firmware version numbers in the Python library. The script fetched public release data from Trezor's servers and rewrote a source file. Removing it does not change any runtime code, device firmware, or installed library behavior, and there is no indication it fixed or introduced a security problem.
No security action needed. Treat as routine repository cleanup. If the script is still needed for maintenance, ensure any replacement uses HTTPS certificate validation, pinned/verified release metadata, and does not blindly rewrite source files.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The deleted file python/helper-scripts/bump-required-fw-versions.py is a standalone maintenance script, not part of the installed trezorlib package. It used requests.get() to read https://data.trezor.io/firmware/{1,2}/releases.json, parsed the JSON, found the latest ‘required’ release per model, and overwrote the MINIMUM_FIRMWARE_VERSION dictionary in trezorlib/init.py. The commit removes this script entirely (78 lines deleted, 0 added). No executable code, configuration, or firmware logic is modified.
Changed components
python/helper-scripts/bump-required-fw-versions.py (deleted)Inspect captured patch +0 / −78
diff --git a/python/helper-scripts/bump-required-fw-versions.py b/python/helper-scripts/bump-required-fw-versions.py
deleted file mode 100755
index 4442d9654..000000000
--- a/python/helper-scripts/bump-required-fw-versions.py
+++ /dev/null
@@ -1,78 +0,0 @@
-#!/usr/bin/env python3
-
-# This file is part of the Trezor project.
-#
-# Copyright (C) SatoshiLabs and contributors
-#
-# This library is free software: you can redistribute it and/or modify
-# it under the terms of the GNU Lesser General Public License version 3
-# as published by the Free Software Foundation.
-#
-# This library is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
-# GNU Lesser General Public License for more details.
-#
-# You should have received a copy of the License along with this library.
-# If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>.
-
-import os
-from typing import Iterable, List
-
-import requests
-
-RELEASES_URL = "https://data.trezor.io/firmware/{}/releases.json"
-MODELS = ("1", "T")
-
-FILENAME = os.path.join(
- os.path.dirname(__file__), "..", "src", "trezorlib", "__init__.py"
-)
-START_LINE = "MINIMUM_FIRMWARE_VERSION = {\n"
-END_LINE = "}\n"
-
-
-def version_str(vtuple: Iterable[int]) -> str:
- return ".".join(map(str, vtuple))
-
-
-def fetch_releases(model: str) -> List[dict]:
- version = model
- if model == "T":
- version = "2"
-
- url = RELEASES_URL.format(version)
- releases = requests.get(url).json()
- releases.sort(key=lambda r: r["version"], reverse=True)
- return releases
-
-
-def find_latest_required(model: str) -> dict:
- releases = fetch_releases(model)
- return next(r for r in releases if r["required"])
-
-
-with open(FILENAME, "r+") as f:
- output: List[str] = []
- line = None
- # copy up to & incl START_LINE
- while line != START_LINE:
- line = next(f)
- output.append(line)
- # throw away until END_LINE
- while line != END_LINE:
- line = next(f)
- # append models
- for model in MODELS:
- rel = find_latest_required(model)
- version_tuple = tuple(rel["version"])
- line = f' "{model}": {version_tuple!r},\n'
- output.append(line)
- output.append(END_LINE)
- # finish reading file
- for line in f:
- output.append(line)
-
- f.seek(0)
- f.truncate(0)
- for line in output:
- f.write(line)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.