ci(core): disable `core_flash_size_compare:` job
What the developer wrote
Authored by Roman Zeyde
ci(core): disable `core_flash_size_compare:` job
Since currently it uses GitLab.
[no changelog]
What changed, and why it matters
This commit simply removes a GitHub Actions CI job that compared the firmware's flash size against the master branch. It is a routine build-pipeline change with no effect on the actual Trezor firmware code, device behavior, or user security.
No security action required. Treat as a normal CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the core_flash_size_compare job from .github/workflows/core.yml. This job downloaded a built firmware artifact and ran core/tools/size/compare_master.py to compare flash usage against master and fail if growth exceeded a threshold. The removal is explicitly motivated by the job’s dependency on GitLab. No firmware source code, cryptographic logic, or runtime behavior is modified.
Changed components
.github/workflows/core.ymlInspect captured patch +0 / −29
diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index ec9ac7a01..17052fac9 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -527,35 +527,6 @@ jobs:
- uses: ./.github/actions/environment
- run: nix-shell --run "poetry run core/tools/size/checker.py core/build/firmware/firmware.elf"
- # Compares the current flash space with the situation in the current master
- # Fails if the new binary is significantly larger than the master one
- # (the threshold is defined in the script, currently 5kb).
- # Also generates a report with the current situation
- core_flash_size_compare:
- name: Flash size comparison
- runs-on: ubuntu-latest
- needs: core_firmware
- strategy:
- fail-fast: false
- matrix:
- model: [T2T1] # FIXME: T2T1 url is hardcoded in compare_master.py
- steps:
- - uses: actions/checkout@v4
- with:
- submodules: recursive
- fetch-depth: 0
- - uses: actions/download-artifact@v4
- with:
- name: core-firmware-${{ matrix.model }}-universal-normal
- path: core/build
- - uses: ./.github/actions/environment
- - run: nix-shell --run "poetry run core/tools/size/compare_master.py core/build/firmware/firmware.elf -r firmware_elf_size_report.txt"
- - uses: actions/upload-artifact@v4
- with:
- name: core-test-flash-size-${{ matrix.model }}
- path: firmware_elf_size_report.txt
- retention-days: 7
-
# Monero tests.
core_monero_test:
name: Monero test (${{ matrix.model }}, ${{ matrix.asan }})
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.