What the developer wrote
Authored by Ioan Bizău
chore: let br_code be Warning
[no changelog]
What changed, and why it matters
This is a minor internal cleanup change in the Trezor hardware wallet firmware. It removes explicit button-request type labels from two warning screens in the Ripple and Stellar cryptocurrency apps, letting them default to a generic 'Warning' category instead of 'ConfirmOutput'. There is no visible security bug or vulnerability being fixed.
No security action required. Treat as a routine UI categorization cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit removes the br_code=ButtonRequestType.ConfirmOutput argument from show_warning() calls in core/src/apps/ripple/sign_tx.py and core/src/apps/stellar/layout.py. The show_warning helper now defaults its button-request code to ButtonRequestType.Warning. This is a UI/UX categorization change for host-device communication messages, not a security patch.
Changed components
core/src/apps/ripple/sign_tx.pycore/src/apps/stellar/layout.pyInspect captured patch +0 / −3
diff --git a/core/src/apps/ripple/sign_tx.py b/core/src/apps/ripple/sign_tx.py
index d8002cc7..aaa30e04 100644
--- a/core/src/apps/ripple/sign_tx.py
+++ b/core/src/apps/ripple/sign_tx.py
@@ -15,7 +15,6 @@ async def sign_tx(msg: RippleSignTx, keychain: Keychain) -> RippleSignedTx:
from trezor.crypto import der
from trezor.crypto.curve import secp256k1
from trezor.crypto.hashlib import sha512
- from trezor.enums import ButtonRequestType
from trezor.messages import RippleSignedTx
from trezor.ui.layouts import show_continue_in_app, show_warning
from trezor.wire import ProcessError
@@ -67,7 +66,6 @@ async def sign_tx(msg: RippleSignTx, keychain: Keychain) -> RippleSignedTx:
await show_warning(
br_name="confirm_destination_tag",
content=TR.ripple__destination_tag_missing,
- br_code=ButtonRequestType.ConfirmOutput,
)
await layout.require_confirm_tx(
diff --git a/core/src/apps/stellar/layout.py b/core/src/apps/stellar/layout.py
index 12795ffc..a6244e00 100644
--- a/core/src/apps/stellar/layout.py
+++ b/core/src/apps/stellar/layout.py
@@ -45,7 +45,6 @@ async def require_confirm_memo(memo_type: StellarMemoType, memo_text: str) -> No
return await layouts.show_warning(
br_name="confirm_memo",
content=TR.stellar__exchanges_require_memo,
- br_code=ButtonRequestType.ConfirmOutput,
)
await layouts.confirm_text(
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.