AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 17 Bitcoin

feat(core): rework haptic driver.

Public commit record

What the developer wrote

Authored by kopecdav

80/100 · Strong
feat(core): rework haptic driver.

Major rework of the haptic driver to improve the haptic feedback of the T3W1 click
- Rename driver from `drv2625` to `drv262x`, since we use it to control compatible models drv2624 and drv2625
- Fix driver configuration to properly configure close loop and open loop operation. T3W1 driver was configured to work in close_loop mode.
- Add waveform playbacks on drv2624 + new button click haptic effect
- Update actuator configuration files with more control parameters.
- Add error handling and tidy up the driver API comments.
- Removed `haptic_test` function since it could be directly replaced with `haptic_play_custom`

[no changelog]
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit is a routine hardware-driver refactor for the vibration motor (haptic feedback) in Trezor devices. It renames the driver, adds support for a second chip model, fixes how closed-loop vs open-loop motor control is configured, and improves error handling. There is no direct evidence in the commit that this fixes an exploitable security vulnerability; it appears to be a product-quality and maintainability improvement.

Recommended action

Treat as a normal firmware improvement. No urgent security action is indicated by the commit content alone. If auditing, verify that the new closed-loop parameters match the actuator datasheet and that error return values from haptic_init are handled appropriately in production code (the prodtest stub currently has an empty if-block).

Security signals we found

01

Driver configuration correction for closed-loop/open-loop haptic actuator operation

02

Addition of error-handling return codes (ts_t) to haptic API

03

Removal of haptic_test() production-test function, replaced by haptic_play_custom

04

No evidence of memory corruption, authentication bypass, or cryptographic weakness in the diff

Risk score

Why this scored 17/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 2/15
Confidence 8/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.